Title: Refactor classes by maxkorp · Pull Request #250 · nodegit/nodegit · GitHub
Open Graph Title: Refactor classes by maxkorp · Pull Request #250 · nodegit/nodegit
X Title: Refactor classes by maxkorp · Pull Request #250 · nodegit/nodegit
Description: This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many methods like createCommit to create. Added a test to revwalk to make sure there is no segfault, but wont run on travis/appveyor because it requires a node argument. Might be worth moving out anyways, as its not really a revwalk test, that was just the mechanism that originally broke it.
Open Graph Description: This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many me...
X Description: This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many me...
Opengraph URL: https://github.com/nodegit/nodegit/pull/250
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fc389824-9145-fca7-eeba-1b611c4c9b4b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8896:3E6F8E:20CF13:2B52DC:6A6024BE |
| html-safe-nonce | 457a76d731860d87308d7ca4b6382558bbe02845f65a104ab577e17c5a844b27 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODk2OjNFNkY4RToyMENGMTM6MkI1MkRDOjZBNjAyNEJFIiwidmlzaXRvcl9pZCI6Ijg3MzQyNTYzMDEwNjgwMDI0OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d6725679bf02a9866858f76e80ea576cb8cf5c26c615143df92bf5b19275626a |
| hovercard-subject-tag | pull_request:23242106 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/250/files |
| twitter:image | https://avatars.githubusercontent.com/u/1302526?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1302526?s=400&v=4 |
| og:image:alt | This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many me... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60da8c2a42fa2bbf5f7567474990ec467836a84444262a58e200fa91b7f3d2d0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9824515e740d83d5eb82168a089b806ab0fe04a1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width