Title: Refactor classes by maxkorp · Pull Request #250 · nodegit/nodegit · GitHub
Open Graph Title: Refactor classes by maxkorp · Pull Request #250 · nodegit/nodegit
X Title: Refactor classes by maxkorp · Pull Request #250 · nodegit/nodegit
Description: This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many methods like createCommit to create. Added a test to revwalk to make sure there is no segfault, but wont run on travis/appveyor because it requires a node argument. Might be worth moving out anyways, as its not really a revwalk test, that was just the mechanism that originally broke it.
Open Graph Description: This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many me...
X Description: This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many me...
Opengraph URL: https://github.com/nodegit/nodegit/pull/250
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5779fb43-6492-851e-b6e7-f0b753c870e1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 975E:6A317:1939601:239F2F8:6A5FB4A0 |
| html-safe-nonce | f8c785d30ddf3dbef3824d6b3b0d7a8b8c97555abe85522bc7a13b0ca1975955 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzVFOjZBMzE3OjE5Mzk2MDE6MjM5RjJGODo2QTVGQjRBMCIsInZpc2l0b3JfaWQiOiI2OTE4OTU5OTE5MjU1MjM3NzkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ccf048968d5b57153750bfab3e29961a87de59f2d04101d0c045ff3ca89e6413 |
| hovercard-subject-tag | pull_request:23242106 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/250/files |
| twitter:image | https://avatars.githubusercontent.com/u/1302526?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1302526?s=400&v=4 |
| og:image:alt | This changes the way memory is handled (so that only root level objects free themselves, all lower level objects expect to be freed by their parents because libgit 2 is weird). Also changes many me... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1ec7085bd7214c509393537f93bc21c48856549e31538b70bdb3cc4df7eb5f70 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b0ff0ab699186747983f122c82d4ebc71a1c22b4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width