René's URL Explorer Experiment


Title: UNSAFE Temporary workaround for LFS checkout performance regression by AlexaXs · Pull Request #1883 · nodegit/nodegit · GitHub

Open Graph Title: UNSAFE Temporary workaround for LFS checkout performance regression by AlexaXs · Pull Request #1883 · nodegit/nodegit

X Title: UNSAFE Temporary workaround for LFS checkout performance regression by AlexaXs · Pull Request #1883 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: After a Threadpool rewrite for context-awareness, LFS checkouts started suffering long delays. We found the reason is that libgit2 callbacks that were being run in parallel started being run in seq...

X Description: After a Threadpool rewrite for context-awareness, LFS checkouts started suffering long delays. We found the reason is that libgit2 callbacks that were being run in parallel started being run in seq...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1883

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f48b46a0-bf4d-d668-759b-0c48926a5da2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAE4:3081D4:2FADC5A:3EA17C2:6A5CF931
html-safe-noncee819e813fbc049845220932073118b9b7a6e2980d5f135ef723131043a2ea61d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUU0OjMwODFENDoyRkFEQzVBOjNFQTE3QzI6NkE1Q0Y5MzEiLCJ2aXNpdG9yX2lkIjoiMjgxNTEwMzM5MDcyODM4Njg2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4585b791b9f5dee58abee8bfa77dcddb9097d816c9a2980b00cf772443845dcf
hovercard-subject-tagpull_request:802368124
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1883/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a37e24fe6a54e8ce59e62d5fda046ce97f96ac9be14943a708d78abe4ae1611/nodegit/nodegit/pull/1883
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a37e24fe6a54e8ce59e62d5fda046ce97f96ac9be14943a708d78abe4ae1611/nodegit/nodegit/pull/1883
og:image:altAfter a Threadpool rewrite for context-awareness, LFS checkouts started suffering long delays. We found the reason is that libgit2 callbacks that were being run in parallel started being run in seq...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexaXs
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1883#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1883
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1883
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1883
Reloadhttps://github.com/nodegit/nodegit/pull/1883
Reloadhttps://github.com/nodegit/nodegit/pull/1883
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
ianhattendorfhttps://github.com/ianhattendorf
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
AlexaXs:fix/LFS-checkout-performance-regressionhttps://github.com/AlexaXs/nodegit/tree/fix/LFS-checkout-performance-regression
Conversationhttps://github.com/nodegit/nodegit/pull/1883
Commits4 (4)https://github.com/nodegit/nodegit/pull/1883/commits
Checkshttps://github.com/nodegit/nodegit/pull/1883/checks
Files changedhttps://github.com/nodegit/nodegit/pull/1883/files
UNSAFE Temporary workaround for LFS checkout performance regressionhttps://github.com/nodegit/nodegit/pull/1883#top
ianhattendorfhttps://github.com/ianhattendorf
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
AlexaXs:fix/LFS-checkout-performance-regressionhttps://github.com/AlexaXs/nodegit/tree/fix/LFS-checkout-performance-regression
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
Dec 14, 2021https://github.com/nodegit/nodegit/pull/1883#issue-1079786681
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
MikeJerredhttps://github.com/MikeJerred
Dec 17, 2021 https://github.com/nodegit/nodegit/pull/1883#ref-commit-29c7ab7
https://github.com/MikeJerred
Apply changes fromhttps://github.com/LogicOverSnacks/glint-nodegit/commit/29c7ab758b3a42a5a62957e17d517f7eb19ca93e
nodegit#1883https://github.com/nodegit/nodegit/pull/1883
29c7ab7https://github.com/LogicOverSnacks/glint-nodegit/commit/29c7ab758b3a42a5a62957e17d517f7eb19ca93e
https://github.com/implausible
implausiblehttps://github.com/implausible
Dec 29, 2021 https://github.com/nodegit/nodegit/pull/1883#pullrequestreview-841550630
View reviewed changes https://github.com/nodegit/nodegit/pull/1883/files
implausiblehttps://github.com/implausible
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/nodegit/nodegit/pull/1883#pullrequestreview-841550630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@AlexaXshttps://github.com/AlexaXs
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
Jan 3, 2022https://github.com/nodegit/nodegit/pull/1883#issuecomment-1004176789
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
@implausiblehttps://github.com/implausible
Threading model #827https://github.com/nodegit/nodegit/issues/827
Thread safety implementation using locking #836https://github.com/nodegit/nodegit/pull/836
Run async libgit2 calls on custom threadpool #1019https://github.com/nodegit/nodegit/pull/1019
This temporaryUnlockhttps://github.com/nodegit/nodegit/blob/bae468cf3da6ae5ef6d3f89d11bf89f83e8db94a/generate/templates/manual/src/thread_pool.cc#L381
This waitinghttps://github.com/nodegit/nodegit/blob/bae468cf3da6ae5ef6d3f89d11bf89f83e8db94a/generate/templates/manual/src/thread_pool.cc#L394
synchronous NodeGit APIs never lock any objecthttps://github.com/nodegit/nodegit/blob/bae468cf3da6ae5ef6d3f89d11bf89f83e8db94a/generate/templates/partials/sync_function.cc#L38
the COMPLETED event is receivedhttps://github.com/nodegit/nodegit/blob/bae468cf3da6ae5ef6d3f89d11bf89f83e8db94a/generate/templates/manual/src/thread_pool.cc#L371
the Worker finishes with the async executionhttps://github.com/nodegit/nodegit/blob/bae468cf3da6ae5ef6d3f89d11bf89f83e8db94a/generate/templates/manual/src/thread_pool.cc#L179
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
January 14, 2022 15:17https://github.com/nodegit/nodegit/pull/1883#event-5895470645
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
Jan 24, 2022https://github.com/nodegit/nodegit/pull/1883#event-5942932501
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
Jan 24, 2022https://github.com/nodegit/nodegit/pull/1883#event-5942935748
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
force-pushedhttps://github.com/nodegit/nodegit/compare/8af36d5fc4fd2df45dec7133776b573cb45c9f7d..b4ccac5695f4e609d1991e20221db314ab4539ec
8af36d5https://github.com/nodegit/nodegit/commit/8af36d5fc4fd2df45dec7133776b573cb45c9f7d
b4ccac5https://github.com/nodegit/nodegit/commit/b4ccac5695f4e609d1991e20221db314ab4539ec
Compare https://github.com/nodegit/nodegit/compare/8af36d5fc4fd2df45dec7133776b573cb45c9f7d..b4ccac5695f4e609d1991e20221db314ab4539ec
January 24, 2022 14:52https://github.com/nodegit/nodegit/pull/1883#event-5943098713
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
Jan 24, 2022https://github.com/nodegit/nodegit/pull/1883#issuecomment-1020217518
@implausiblehttps://github.com/implausible
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
January 24, 2022 15:27https://github.com/nodegit/nodegit/pull/1883#event-5943385133
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
implausiblehttps://github.com/implausible
January 24, 2022 15:28https://github.com/nodegit/nodegit/pull/1883#event-5943391862
https://github.com/implausible
implausiblehttps://github.com/implausible
Feb 3, 2022https://github.com/nodegit/nodegit/pull/1883#issuecomment-1029182734
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/implausible
implausiblehttps://github.com/implausible
Feb 3, 2022https://github.com/nodegit/nodegit/pull/1883#issuecomment-1029190063
https://github.com/nodegit/nodegit/blob/master/test/tests/worker.jshttps://github.com/nodegit/nodegit/blob/master/test/tests/worker.js
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
AlexaXshttps://github.com/AlexaXs
February 11, 2022 14:59https://github.com/nodegit/nodegit/pull/1883#commits-pushed-01fceca
https://github.com/AlexaXs
Remove unused codehttps://github.com/nodegit/nodegit/pull/1883/commits/01fcecab12a8298aa373266a2a9a17986fec8bc5
01fcecahttps://github.com/nodegit/nodegit/pull/1883/commits/01fcecab12a8298aa373266a2a9a17986fec8bc5
https://github.com/AlexaXs
Test deadlock in callbackshttps://github.com/nodegit/nodegit/pull/1883/commits/1aaf2ee148664854f49b623dc7dadad7192f1952
1aaf2eehttps://github.com/nodegit/nodegit/pull/1883/commits/1aaf2ee148664854f49b623dc7dadad7192f1952
https://github.com/AlexaXs
Unsafe temporary workaround for LFS checkout lost performancehttps://github.com/nodegit/nodegit/pull/1883/commits/7b248d9b7900796a79e58da85980c023def873d7
7b248d9https://github.com/nodegit/nodegit/pull/1883/commits/7b248d9b7900796a79e58da85980c023def873d7
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
force-pushedhttps://github.com/nodegit/nodegit/compare/b4ccac5695f4e609d1991e20221db314ab4539ec..7b248d9b7900796a79e58da85980c023def873d7
b4ccac5https://github.com/nodegit/nodegit/commit/b4ccac5695f4e609d1991e20221db314ab4539ec
7b248d9https://github.com/nodegit/nodegit/commit/7b248d9b7900796a79e58da85980c023def873d7
Compare https://github.com/nodegit/nodegit/compare/b4ccac5695f4e609d1991e20221db314ab4539ec..7b248d9b7900796a79e58da85980c023def873d7
February 11, 2022 14:20https://github.com/nodegit/nodegit/pull/1883#event-6051634634
https://github.com/AlexaXs
Tests on worker thread terminate while doing a checkouthttps://github.com/nodegit/nodegit/pull/1883/commits/caec8195155d169495b53cf16238c01c9597f114
caec819https://github.com/nodegit/nodegit/pull/1883/commits/caec8195155d169495b53cf16238c01c9597f114
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
Feb 17, 2022https://github.com/nodegit/nodegit/pull/1883#issuecomment-1042727024
@implausiblehttps://github.com/implausible
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/implausible
implausiblehttps://github.com/implausible
Feb 24, 2022 https://github.com/nodegit/nodegit/pull/1883#pullrequestreview-892918032
View reviewed changes https://github.com/nodegit/nodegit/pull/1883/files/caec8195155d169495b53cf16238c01c9597f114
https://github.com/ianhattendorf
ianhattendorfhttps://github.com/ianhattendorf
4602913https://github.com/nodegit/nodegit/commit/4602913a9bf1e01866b568e1f7b0f37bb7e55c01
Mar 17, 2022https://github.com/nodegit/nodegit/pull/1883#event-6254797752
https://github.com/AlexaXs
AlexaXshttps://github.com/AlexaXs
March 29, 2022 14:03https://github.com/nodegit/nodegit/pull/1883#event-6326976539
ianhattendorfhttps://github.com/ianhattendorf
Oct 4, 2022 https://github.com/nodegit/nodegit/pull/1883#ref-commit-9ee0f10
https://github.com/ianhattendorf
Partial reverthttps://github.com/ianhattendorf/nodegit/commit/9ee0f1036e7b5c373b167f14a9b0eca1120b1c89
nodegit#1883https://github.com/nodegit/nodegit/pull/1883
9ee0f10https://github.com/ianhattendorf/nodegit/commit/9ee0f1036e7b5c373b167f14a9b0eca1120b1c89
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1883
https://github.com/implausible
implausible https://github.com/implausible
https://github.com/nodegit/nodegit/pull/1883/files/caec8195155d169495b53cf16238c01c9597f114
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1883
https://github.com/AlexaXs
https://github.com/implausible
https://github.com/ianhattendorf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.