René's URL Explorer Experiment


Title: Implement support for Node 12 by tiggerite · Pull Request #1696 · nodegit/nodegit · GitHub

Open Graph Title: Implement support for Node 12 by tiggerite · Pull Request #1696 · nodegit/nodegit

X Title: Implement support for Node 12 by tiggerite · Pull Request #1696 · nodegit/nodegit

Description: Fixes #1680 - tested on Node 10.16.0 and Node 12.6.0

Open Graph Description: Fixes #1680 - tested on Node 10.16.0 and Node 12.6.0

X Description: Fixes #1680 - tested on Node 10.16.0 and Node 12.6.0

Opengraph URL: https://github.com/nodegit/nodegit/pull/1696

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0790ca70-95ae-1032-0620-e28abe130353
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA78E:2DE302:A262B0:E3EC85:6970B96D
html-safe-nonceb7ef07f71f1befbbdedf6c2590af5c7779149b0eed27600e3ee15ee9e33bd5ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzhFOjJERTMwMjpBMjYyQjA6RTNFQzg1OjY5NzBCOTZEIiwidmlzaXRvcl9pZCI6IjU4NDI4MjcxNzcxNDAyMDU5MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccbfa34507b2e07af2af255c774dbcbd1d990751aee1b7176ecf2f97900fb7438
hovercard-subject-tagpull_request:296111679
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1696/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b12316c95ecb049673c047ebb1083aea2e958b55d353a14be6164075b4bef976/nodegit/nodegit/pull/1696
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b12316c95ecb049673c047ebb1083aea2e958b55d353a14be6164075b4bef976/nodegit/nodegit/pull/1696
og:image:altFixes #1680 - tested on Node 10.16.0 and Node 12.6.0
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametiggerite
hostnamegithub.com
expected-hostnamegithub.com
None8e0be80373b724b033cdf8a7b1f78bf5fb6a5d7a2182a9a403aa30894606e390
turbo-cache-controlno-preview
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84d9d5bf3b01412ea10f7c2429cbfc735ccce9ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1696#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1696
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1696
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1696
Reloadhttps://github.com/nodegit/nodegit/pull/1696
Reloadhttps://github.com/nodegit/nodegit/pull/1696
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 697 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 19 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects 0 https://github.com/nodegit/nodegit/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodegit/nodegit/security
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodegit/nodegit/pull/1696#issue-comment-box
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tiggerite:masterhttps://github.com/tiggerite/nodegit/tree/master
Implement support for Node 12 https://github.com/nodegit/nodegit/pull/1696#top
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tiggerite:masterhttps://github.com/tiggerite/nodegit/tree/master
Conversation 12 https://github.com/nodegit/nodegit/pull/1696
Commits 13 https://github.com/nodegit/nodegit/pull/1696/commits
Checks 0 https://github.com/nodegit/nodegit/pull/1696/checks
Files changed https://github.com/nodegit/nodegit/pull/1696/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 10, 2019https://github.com/nodegit/nodegit/pull/1696#issue-466232597
#1680https://github.com/nodegit/nodegit/issues/1680
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
tiggeritehttps://github.com/tiggerite
July 10, 2019 09:23https://github.com/nodegit/nodegit/pull/1696#commits-pushed-c7d9e10
https://github.com/tiggerite
⬆️ Make templates compatible with Node 12https://github.com/nodegit/nodegit/pull/1696/commits/c7d9e100516d00ec91ba99d5285d1b0fc9a70444
c7d9e10https://github.com/nodegit/nodegit/pull/1696/commits/c7d9e100516d00ec91ba99d5285d1b0fc9a70444
https://github.com/tiggerite
⬆️ GetPropertyNames also needs to be changed for Node 12https://github.com/nodegit/nodegit/pull/1696/commits/59bad990829711ee4e499ed27892ecb6cef5900a
59bad99https://github.com/nodegit/nodegit/pull/1696/commits/59bad990829711ee4e499ed27892ecb6cef5900a
https://github.com/tiggerite
🎨 Extra space for Utf8Strings to line up betterhttps://github.com/nodegit/nodegit/pull/1696/commits/eb2df373ec490679b2b9aa69e26b5d85f56feadf
eb2df37https://github.com/nodegit/nodegit/pull/1696/commits/eb2df373ec490679b2b9aa69e26b5d85f56feadf
https://github.com/tiggerite
⬆️ BooleanValue also needs changing for Node 12https://github.com/nodegit/nodegit/pull/1696/commits/8e723ef46635b912c5d47a3b389f075a58547fe4
8e723efhttps://github.com/nodegit/nodegit/pull/1696/commits/8e723ef46635b912c5d47a3b389f075a58547fe4
https://github.com/tiggerite
⬆️ Minor amends for a few manual templateshttps://github.com/nodegit/nodegit/pull/1696/commits/77b615a6ebd0f910a816b76142eabea830dc9a2e
77b615ahttps://github.com/nodegit/nodegit/pull/1696/commits/77b615a6ebd0f910a816b76142eabea830dc9a2e
https://github.com/tiggerite
⬆️ Nan::Call requires ToLocalCheckedhttps://github.com/nodegit/nodegit/pull/1696/commits/a470a678b4204f28b4e4de607a103ae2b254b5a1
a470a67https://github.com/nodegit/nodegit/pull/1696/commits/a470a678b4204f28b4e4de607a103ae2b254b5a1
https://github.com/tiggerite
🎨 Final spacing amends for manual str_array_converterhttps://github.com/nodegit/nodegit/pull/1696/commits/a10a61677a479d5e83b9d7b4ff962f2dd8439098
a10a616https://github.com/nodegit/nodegit/pull/1696/commits/a10a61677a479d5e83b9d7b4ff962f2dd8439098
https://github.com/implausible
implausiblehttps://github.com/implausible
Jul 11, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-510615129
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/implausible
implausiblehttps://github.com/implausible
Jul 11, 2019 https://github.com/nodegit/nodegit/pull/1696#pullrequestreview-260906701
View reviewed changes https://github.com/nodegit/nodegit/pull/1696/files/a10a61677a479d5e83b9d7b4ff962f2dd8439098
implausiblehttps://github.com/implausible
https://github.com/nodegit/nodegit/pull/1696#pullrequestreview-260906701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
✅ Start building for Node 12https://github.com/nodegit/nodegit/pull/1696/commits/4db16704391f058e11c8fd7cab00a7cfc315200f
4db1670https://github.com/nodegit/nodegit/pull/1696/commits/4db16704391f058e11c8fd7cab00a7cfc315200f
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 12, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-510790870
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
⬆️ Update versions of nan and node-pre-gyphttps://github.com/nodegit/nodegit/pull/1696/commits/9bc65c6d242bb0e3cd1350408925c79c8426bdd7
9bc65c6https://github.com/nodegit/nodegit/pull/1696/commits/9bc65c6d242bb0e3cd1350408925c79c8426bdd7
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 12, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-510797404
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
tiggeritehttps://github.com/tiggerite
July 12, 2019 11:48https://github.com/nodegit/nodegit/pull/1696#commits-pushed-658936e
https://github.com/tiggerite
♻️ Remove last depreciated warnings so everything is now cleanhttps://github.com/nodegit/nodegit/pull/1696/commits/658936e8faa97eb555ea58f21c888e1925299861
658936ehttps://github.com/nodegit/nodegit/pull/1696/commits/658936e8faa97eb555ea58f21c888e1925299861
https://github.com/tiggerite
🎨 Minor spacing for parameters in Nan::Sethttps://github.com/nodegit/nodegit/pull/1696/commits/a0f0c608a2594e9c99dbd08e4dbd15b96b905e86
a0f0c60https://github.com/nodegit/nodegit/pull/1696/commits/a0f0c608a2594e9c99dbd08e4dbd15b96b905e86
https://github.com/tiggerite
♻️ Missed one Callback->Call without async_resourcehttps://github.com/nodegit/nodegit/pull/1696/commits/04558820578180cae9ae9446569e70ac22eb97ee
0455882https://github.com/nodegit/nodegit/pull/1696/commits/04558820578180cae9ae9446569e70ac22eb97ee
https://github.com/rcjsuen
rcjsuenhttps://github.com/rcjsuen
Jul 12, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-510845970
@tiggeritehttps://github.com/tiggerite
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
🐛 Needs the reference to callback, not the pointerhttps://github.com/nodegit/nodegit/pull/1696/commits/e82db052c4ed9f23ba0117cea08e0eed513f1b23
e82db05https://github.com/nodegit/nodegit/pull/1696/commits/e82db052c4ed9f23ba0117cea08e0eed513f1b23
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 12, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-510862472
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 15, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-511368199
@implausiblehttps://github.com/implausible
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/implausible
implausiblehttps://github.com/implausible
Jul 15, 2019 https://github.com/nodegit/nodegit/pull/1696#pullrequestreview-262005036
View reviewed changes https://github.com/nodegit/nodegit/pull/1696/files/e82db052c4ed9f23ba0117cea08e0eed513f1b23
implausiblehttps://github.com/implausible
https://github.com/nodegit/nodegit/pull/1696#pullrequestreview-262005036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/implausible
implausiblehttps://github.com/implausible
485d675https://github.com/nodegit/nodegit/commit/485d675f9060110b9f9f6ce581b9b1cff3befdc7
Jul 15, 2019https://github.com/nodegit/nodegit/pull/1696#event-2483872772
https://github.com/implausible
implausiblehttps://github.com/implausible
Jul 19, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-513390077
https://travis-ci.org/nodegit/nodegit/jobs/559068365https://travis-ci.org/nodegit/nodegit/jobs/559068365
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 20, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-513480098
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
tiggeritehttps://github.com/tiggerite
Jul 20, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-513480399
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/implausible
implausiblehttps://github.com/implausible
Jul 22, 2019https://github.com/nodegit/nodegit/pull/1696#issuecomment-513817380
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Feb 23, 2020 https://github.com/nodegit/nodegit/pull/1696#ref-pullrequest-569442418
[Snyk] Upgrade nodegit from 0.4.1 to 0.26.4 saurabharch/Breezeblocks#1 https://github.com/saurabharch/Breezeblocks/pull/1
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 22, 2020 https://github.com/nodegit/nodegit/pull/1696#ref-pullrequest-604472000
[Snyk] Upgrade nodegit from 0.24.3 to 0.26.5 aminatakonate000/Graviton-App#4 https://github.com/aminatakonate000/Graviton-App/pull/4
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
May 5, 2020 https://github.com/nodegit/nodegit/pull/1696#ref-pullrequest-612362441
[Snyk] Upgrade nodegit from 0.24.3 to 0.26.5 Barnstorm-Online/ngp-openapi-generator#1 https://github.com/Barnstorm-Online/ngp-openapi-generator/pull/1
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1696
https://github.com/implausible
implausible https://github.com/implausible
https://github.com/nodegit/nodegit/pull/1696/files/e82db052c4ed9f23ba0117cea08e0eed513f1b23
Need to implement support for node 12 https://github.com/nodegit/nodegit/issues/1680
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1696
https://github.com/tiggerite
https://github.com/implausible
https://github.com/rcjsuen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.