Title: Catch errors and pass them to libgit2 as error codes in rebase signingcb by implausible · Pull Request #1636 · nodegit/nodegit · GitHub
Open Graph Title: Catch errors and pass them to libgit2 as error codes in rebase signingcb by implausible · Pull Request #1636 · nodegit/nodegit
X Title: Catch errors and pass them to libgit2 as error codes in rebase signingcb by implausible · Pull Request #1636 · nodegit/nodegit
Description: It seems we expected that the signing CB would never throw or reject when returning a failure code. This PR should help alleviate unexpected behavior where throwing or rejecting should check for an error code and return that or should return a generic -1 error.
Open Graph Description: It seems we expected that the signing CB would never throw or reject when returning a failure code. This PR should help alleviate unexpected behavior where throwing or rejecting should check for an...
X Description: It seems we expected that the signing CB would never throw or reject when returning a failure code. This PR should help alleviate unexpected behavior where throwing or rejecting should check for an...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1636
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f53dbf92-c430-32ad-d5d9-2719aa73e8e8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C94C:3948C3:29F443C:3CF5845:6A60CF25 |
| html-safe-nonce | 9e588edfc3574c78fbac891d03f2d012ba41e1c56a71c0d790f114c5eca45ae2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTRDOjM5NDhDMzoyOUY0NDNDOjNDRjU4NDU6NkE2MENGMjUiLCJ2aXNpdG9yX2lkIjoiMTMyMDE4NDQxNjQxNDI1NjkzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 662fe77c5ce19236cda8861bd0054d30b1c9e75c4df9b97acb8e4a290b15593e |
| hovercard-subject-tag | pull_request:254436030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1636/files |
| twitter:image | https://avatars.githubusercontent.com/u/5742591?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5742591?s=400&v=4 |
| og:image:alt | It seems we expected that the signing CB would never throw or reject when returning a failure code. This PR should help alleviate unexpected behavior where throwing or rejecting should check for an... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a9556c67fd2e63f5fecafc192915a3b089ef8170a9384ff6b59d7b4a2f6b73f8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f464e59c3a800187a50f3c89c36ee16df9992c1b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width