Title: Handle new gyp information for electron builds by implausible · Pull Request #1623 · nodegit/nodegit · GitHub
Open Graph Title: Handle new gyp information for electron builds by implausible · Pull Request #1623 · nodegit/nodegit
X Title: Handle new gyp information for electron builds by implausible · Pull Request #1623 · nodegit/nodegit
Description: Since Electron is now at version >4, the iojs qualifier on the version number in the folder name for node headers stored in ~/.node-gyp is no longer appended. This is because iojs and node merged at node v4. So that's the reason the <4 electron headers had iojs appended onto their header folder name. Now we need to support >4. I tried messing about a bit with the exported config.gypi that is provided in the electron headers, but it doesn't seem to be included from the start :(. In lieu of going back to some sort of pangyp again, I've just parsed the config.gypi with json5 and am hoping for the best. We'll probably be back here in a year or 2 going, why? Why?!
Open Graph Description: Since Electron is now at version >4, the iojs qualifier on the version number in the folder name for node headers stored in ~/.node-gyp is no longer appended. This is because iojs and node merge...
X Description: Since Electron is now at version >4, the iojs qualifier on the version number in the folder name for node headers stored in ~/.node-gyp is no longer appended. This is because iojs and node m...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1623
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e586c935-91a7-fab2-64a9-b965e209c923 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD28:1B5925:D41D5F:11E6D04:6A582BEE |
| html-safe-nonce | 135a82114cad36ff6c2b66de2e69f379447d018371398d658ce925d5af84e675 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDI4OjFCNTkyNTpENDFENUY6MTFFNkQwNDo2QTU4MkJFRSIsInZpc2l0b3JfaWQiOiI3MTI4MTU3MTcxOTY4NjUwMjIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ea4310cf3b142988e303428e633fe85e6f6d5f04f9fd56695217ef0e243d9dd9 |
| hovercard-subject-tag | pull_request:251276083 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1623/files |
| twitter:image | https://avatars.githubusercontent.com/u/5742591?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5742591?s=400&v=4 |
| og:image:alt | Since Electron is now at version >4, the iojs qualifier on the version number in the folder name for node headers stored in ~/.node-gyp is no longer appended. This is because iojs and node merge... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width