René's URL Explorer Experiment


Title: Use same API for signingCb in all places that can be crypto signed by implausible · Pull Request #1621 · nodegit/nodegit · GitHub

Open Graph Title: Use same API for signingCb in all places that can be crypto signed by implausible · Pull Request #1621 · nodegit/nodegit

X Title: Use same API for signingCb in all places that can be crypto signed by implausible · Pull Request #1621 · nodegit/nodegit

Description: Any place where we implement a callback pattern for signing commits/tags follows the same API: type SigningCB = (content: string) => { code: number, field?: string, signedData?: string }; What still needs to be done: Add new test cases for amend Add new test cases for commit Add new test cases for rebase Add new test cases for tag

Open Graph Description: Any place where we implement a callback pattern for signing commits/tags follows the same API: type SigningCB = (content: string) => { code: number, field?: string, signedData?: string }; What s...

X Description: Any place where we implement a callback pattern for signing commits/tags follows the same API: type SigningCB = (content: string) => { code: number, field?: string, signedData?: string }; Wh...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1621

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5485812d-29e9-137e-fd2f-fa7e44582985
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF42:3A2E8:77DD134:A37C092:6A5E555A
html-safe-nonce79e0f6bfc755686f5b9b0c41d40f480e96c3e76b57d116a95fa9b5e20b395546
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjQyOjNBMkU4Ojc3REQxMzQ6QTM3QzA5Mjo2QTVFNTU1QSIsInZpc2l0b3JfaWQiOiI0ODM5MzA5ODU5NDQ2NzQwMzE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac80d2f3b9ab95a00bfdea28f75e6822e5e953567402c117f755f4f98ae46cfa29
hovercard-subject-tagpull_request:250245114
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1621/files
twitter:imagehttps://avatars.githubusercontent.com/u/5742591?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5742591?s=400&v=4
og:image:altAny place where we implement a callback pattern for signing commits/tags follows the same API: type SigningCB = (content: string) => { code: number, field?: string, signedData?: string }; What s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7034b9f0130cdfcbd93bbcf3e8c0f4cc3007af54a2804bfd31f70d472b22852b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee75cd8524a0802713165f77a0088258ff9261683
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1621/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1621%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1621%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1621/files
Reloadhttps://github.com/nodegit/nodegit/pull/1621/files
Reloadhttps://github.com/nodegit/nodegit/pull/1621/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1621/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
implausible:fix/unify-signing-callback-apishttps://github.com/implausible/nodegit/tree/fix/unify-signing-callback-apis
Conversation 7 https://github.com/nodegit/nodegit/pull/1621
Commits 2 https://github.com/nodegit/nodegit/pull/1621/commits
Checks 0 https://github.com/nodegit/nodegit/pull/1621/checks
Files changed https://github.com/nodegit/nodegit/pull/1621/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1621/files
Use same API for signingCb in all places that can be crypto signed https://github.com/nodegit/nodegit/pull/1621/files#top
Show all changes 2 commits https://github.com/nodegit/nodegit/pull/1621/files
874e653 Use same API for signingCb in all places that can be crypto signed implausible Feb 5, 2019 https://github.com/nodegit/nodegit/pull/1621/commits/874e6530532edee61b699d57411bad33b7568b28
4ee0ca9 Use enum here for consistency in test implausible Feb 5, 2019 https://github.com/nodegit/nodegit/pull/1621/commits/4ee0ca9c7c5ca68a6e8893db3f6289354e64d5bd
Clear filters https://github.com/nodegit/nodegit/pull/1621/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1621/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1621/files
commit.js https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
rebase.js https://github.com/nodegit/nodegit/pull/1621/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
repository.js https://github.com/nodegit/nodegit/pull/1621/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
tag.js https://github.com/nodegit/nodegit/pull/1621/files#diff-c84cda2455a263a7c7e7dcd578dea49a2957d159e1e2ecad56414bd4eae76775
commit.js https://github.com/nodegit/nodegit/pull/1621/files#diff-3b419ffc8348f4dcf124be8438ac97fb674f372518b8a17bb389d6a30779ac78
rebase.js https://github.com/nodegit/nodegit/pull/1621/files#diff-76a7726b4f6a77683d9b7137945849a67913f57d68cf1d12a144710c5fabcc6c
tag.js https://github.com/nodegit/nodegit/pull/1621/files#diff-0dd9abaec0235ec715e1646a5285e9693bd988bd0d8acb5965dbd4f85e494c8f
lib/commit.jshttps://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
View file https://github.com/implausible/nodegit/blob/4ee0ca9c7c5ca68a6e8893db3f6289354e64d5bd/lib/commit.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1621/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1621/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
lib/rebase.jshttps://github.com/nodegit/nodegit/pull/1621/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
View file https://github.com/implausible/nodegit/blob/4ee0ca9c7c5ca68a6e8893db3f6289354e64d5bd/lib/rebase.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1621/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1621/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
https://github.com/nodegit/nodegit/pull/1621/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
https://github.com/nodegit/nodegit/pull/1621/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
lib/repository.jshttps://github.com/nodegit/nodegit/pull/1621/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
View file https://github.com/implausible/nodegit/blob/4ee0ca9c7c5ca68a6e8893db3f6289354e64d5bd/lib/repository.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1621/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1621/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1621/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1621/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1621/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
lib/tag.jshttps://github.com/nodegit/nodegit/pull/1621/files#diff-c84cda2455a263a7c7e7dcd578dea49a2957d159e1e2ecad56414bd4eae76775
View file https://github.com/implausible/nodegit/blob/4ee0ca9c7c5ca68a6e8893db3f6289354e64d5bd/lib/tag.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1621/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1621/files#diff-c84cda2455a263a7c7e7dcd578dea49a2957d159e1e2ecad56414bd4eae76775
https://github.com/nodegit/nodegit/pull/1621/files#diff-c84cda2455a263a7c7e7dcd578dea49a2957d159e1e2ecad56414bd4eae76775
https://github.com/nodegit/nodegit/pull/1621/files#diff-c84cda2455a263a7c7e7dcd578dea49a2957d159e1e2ecad56414bd4eae76775
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1621/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.