René's URL Explorer Experiment


Title: Breaking: Repository.prototype.continueRebase enhancements by emmax86 · Pull Request #1619 · nodegit/nodegit · GitHub

Open Graph Title: Breaking: Repository.prototype.continueRebase enhancements by emmax86 · Pull Request #1619 · nodegit/nodegit

X Title: Breaking: Repository.prototype.continueRebase enhancements by emmax86 · Pull Request #1619 · nodegit/nodegit

Description: Enhancement to the Repository.prototype.continueRebase method which allows a RebaseOptions to be passed in. This achieves parity with Repository.prototype.rebaseBranches. Also introduces a breaking change from the error handling pattern introduced to continueRebase in #1348. Previously, all errors which occurred in the middle of a continueRebase operation would be swallowed. However, the introduction of signingCb as a field on RebaseOptions shed light on legitimate use cases where continueRebase should throw. My solution was to swallow the EAPPLIED error (specifically mentioned in the review of #1348) and throw all others.

Open Graph Description: Enhancement to the Repository.prototype.continueRebase method which allows a RebaseOptions to be passed in. This achieves parity with Repository.prototype.rebaseBranches. Also introduces a breaki...

X Description: Enhancement to the Repository.prototype.continueRebase method which allows a RebaseOptions to be passed in. This achieves parity with Repository.prototype.rebaseBranches. Also introduces a breaki...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1619

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8e803105-b145-da7d-1b1e-b710113420cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB886:19756B:195AE0:222272:6A5FEA6D
html-safe-nonce5e0b0e37fc1353676c1da003a9b9dc6b8accd739510d989df8e07696979cfda8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODg2OjE5NzU2QjoxOTVBRTA6MjIyMjcyOjZBNUZFQTZEIiwidmlzaXRvcl9pZCI6IjQwNTAyNjM3MTM2NDM0ODk5MDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0110c4e0cb58410fbbf739e8c9a6202b6949b4dc5fd7c45b8c10df13def5934c
hovercard-subject-tagpull_request:249717927
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1619/files
twitter:imagehttps://avatars.githubusercontent.com/u/35500807?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35500807?s=400&v=4
og:image:altEnhancement to the Repository.prototype.continueRebase method which allows a RebaseOptions to be passed in. This achieves parity with Repository.prototype.rebaseBranches. Also introduces a breaki...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneba296ecd3a3521238fe43b3b3b08cc09207ddc21173e16ee656db03803de8e2b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6e50fb37e29e4aa0df6386cb485e58b0e3ca97ab
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1619/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1619%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1619%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1619/files
Reloadhttps://github.com/nodegit/nodegit/pull/1619/files
Reloadhttps://github.com/nodegit/nodegit/pull/1619/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1619/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
emmax86:feature/continue-rebase-enhancementshttps://github.com/emmax86/nodegit/tree/feature/continue-rebase-enhancements
Conversation 0 https://github.com/nodegit/nodegit/pull/1619
Commits 2 https://github.com/nodegit/nodegit/pull/1619/commits
Checks 0 https://github.com/nodegit/nodegit/pull/1619/checks
Files changed https://github.com/nodegit/nodegit/pull/1619/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1619/files
Breaking: Repository.prototype.continueRebase enhancements https://github.com/nodegit/nodegit/pull/1619/files#top
Show all changes 2 commits https://github.com/nodegit/nodegit/pull/1619/files
8083f33 Add a `rebaseOptions` parameter to `Repository.prototype.continueRebase` emmax86 Feb 1, 2019 https://github.com/nodegit/nodegit/pull/1619/commits/8083f33c9e4659d1122cecdab19fa0b3f8625532
74e7c1e Only swallow EAPPLIED errors in `Repository.prototype.continueRebase` emmax86 Feb 1, 2019 https://github.com/nodegit/nodegit/pull/1619/commits/74e7c1e89ab21801ca6ee13443ef813c05e04b93
Clear filters https://github.com/nodegit/nodegit/pull/1619/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1619/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1619/files
lib/repository.jshttps://github.com/nodegit/nodegit/pull/1619/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
View file https://github.com/emmax86/nodegit/blob/74e7c1e89ab21801ca6ee13443ef813c05e04b93/lib/repository.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1619/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1619/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1619/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1619/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1619/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1619/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.