René's URL Explorer Experiment


Title: Fix issues with Commit#amendWithSignature by emmax86 · Pull Request #1617 · nodegit/nodegit · GitHub

Open Graph Title: Fix issues with Commit#amendWithSignature by emmax86 · Pull Request #1617 · nodegit/nodegit

X Title: Fix issues with Commit#amendWithSignature by emmax86 · Pull Request #1617 · nodegit/nodegit

Description: Fixes two issues with the Commit#amendWithSignature method: Non-null arguments which override the values from the commit object were being ignored. An extra newline was being inserted into the commit message. This caused extraneous newlines to be appended to commit messages, esp. when the amend operation was repeated.

Open Graph Description: Fixes two issues with the Commit#amendWithSignature method: Non-null arguments which override the values from the commit object were being ignored. An extra newline was being inserted into the com...

X Description: Fixes two issues with the Commit#amendWithSignature method: Non-null arguments which override the values from the commit object were being ignored. An extra newline was being inserted into the com...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1617

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ee6583f6-2039-9333-013c-bcf4361d9744
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5C2:1E7DF5:1DBEA82:29797AA:6A5F3D4F
html-safe-noncea39b577ab5a273df3b05976a3fc1010ed56c3c2e4a81fa1c827218912ab7626c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUMyOjFFN0RGNToxREJFQTgyOjI5Nzk3QUE6NkE1RjNENEYiLCJ2aXNpdG9yX2lkIjoiNjM3OTY5MjU3MDEyMjg2MTkwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6893b031d0567fdee594a1fa5a58ee36f2135f8867a63b3f8ac5c9d6c90c9718
hovercard-subject-tagpull_request:248670164
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1617/files
twitter:imagehttps://avatars.githubusercontent.com/u/35500807?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35500807?s=400&v=4
og:image:altFixes two issues with the Commit#amendWithSignature method: Non-null arguments which override the values from the commit object were being ignored. An extra newline was being inserted into the com...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneab2497d9345a59709926b385d88458fa5932c82ec066288448eb68b34cbcbbda
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseba0ac57287507693938b0a2de45402a22cda0785
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1617/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1617%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1617%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1617/files
Reloadhttps://github.com/nodegit/nodegit/pull/1617/files
Reloadhttps://github.com/nodegit/nodegit/pull/1617/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1617/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
emmax86:fix/amend-with-signature-issueshttps://github.com/emmax86/nodegit/tree/fix/amend-with-signature-issues
Conversation 1 https://github.com/nodegit/nodegit/pull/1617
Commits 4 https://github.com/nodegit/nodegit/pull/1617/commits
Checks 0 https://github.com/nodegit/nodegit/pull/1617/checks
Files changed https://github.com/nodegit/nodegit/pull/1617/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1617/files
Fix issues with Commit#amendWithSignature https://github.com/nodegit/nodegit/pull/1617/files#top
Show all changes 4 commits https://github.com/nodegit/nodegit/pull/1617/files
6fd42e2 Fix order of `fp.assign` args emmax86 Jan 29, 2019 https://github.com/nodegit/nodegit/pull/1617/commits/6fd42e2244d34e9e9c7320252365750a17f4a2f4
94313ea Do not append an additional newline to `amend` commit buffers emmax86 Jan 29, 2019 https://github.com/nodegit/nodegit/pull/1617/commits/94313ea4447217e4c0283cd731f1e8b5ef2f8ec3
b0c33bf Update tests emmax86 Jan 29, 2019 https://github.com/nodegit/nodegit/pull/1617/commits/b0c33bf51b88d00697b101d1f3677f5f72cf8881
b6498b0 Pad commit buffer with newline only if it does not already end with n… emmax86 Jan 30, 2019 https://github.com/nodegit/nodegit/pull/1617/commits/b6498b0a2f69d2ac9ed78d48b521f4c0c2b1b637
Clear filters https://github.com/nodegit/nodegit/pull/1617/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1617/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1617/files
commit.js https://github.com/nodegit/nodegit/pull/1617/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
repository.js https://github.com/nodegit/nodegit/pull/1617/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
commit.js https://github.com/nodegit/nodegit/pull/1617/files#diff-3b419ffc8348f4dcf124be8438ac97fb674f372518b8a17bb389d6a30779ac78
lib/commit.jshttps://github.com/nodegit/nodegit/pull/1617/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
View file https://github.com/emmax86/nodegit/blob/b6498b0a2f69d2ac9ed78d48b521f4c0c2b1b637/lib/commit.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1617/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1617/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1617/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
https://github.com/nodegit/nodegit/pull/1617/files#diff-d14b3272eca693bb1d44260bb832434e303d8eb7ea7efb6096431819c7a50431
lib/repository.jshttps://github.com/nodegit/nodegit/pull/1617/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
View file https://github.com/emmax86/nodegit/blob/b6498b0a2f69d2ac9ed78d48b521f4c0c2b1b637/lib/repository.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1617/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1617/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1617/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
test/tests/commit.jshttps://github.com/nodegit/nodegit/pull/1617/files#diff-3b419ffc8348f4dcf124be8438ac97fb674f372518b8a17bb389d6a30779ac78
View file https://github.com/emmax86/nodegit/blob/b6498b0a2f69d2ac9ed78d48b521f4c0c2b1b637/test/tests/commit.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1617/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1617/files#diff-3b419ffc8348f4dcf124be8438ac97fb674f372518b8a17bb389d6a30779ac78
https://github.com/nodegit/nodegit/pull/1617/files#diff-3b419ffc8348f4dcf124be8438ac97fb674f372518b8a17bb389d6a30779ac78
https://github.com/nodegit/nodegit/pull/1617/files#diff-3b419ffc8348f4dcf124be8438ac97fb674f372518b8a17bb389d6a30779ac78
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.