Title: Use static `libssh2_config.h` on MacOS builds by emmax86 · Pull Request #1569 · nodegit/nodegit · GitHub
Open Graph Title: Use static `libssh2_config.h` on MacOS builds by emmax86 · Pull Request #1569 · nodegit/nodegit
X Title: Use static `libssh2_config.h` on MacOS builds by emmax86 · Pull Request #1569 · nodegit/nodegit
Description: Background: Per the discussion in #1566, we are opting to use a static libssh2_config.h for MacOS builds. tl;dr: The libssh2_config.h header file is generated as a side effect of running vendor/libssh2/configure, and necessary for libssh2 to build. The script it is trying to use the system headers to compile and test dynamic links to OpenSSL from libssh2. Node already these headers and links for us, or we provide our own (in the case of Electron). The configured header is safe and stable to provide statically. Summary of Changes Add a new directory in vendor called static_config. This is where statically provided configurations for our vendored dependencies will be found. Move openssl_distributions.json into vendor/static_config. Also updated the related utility scripts to use this location. Move vendor/libssh2/win32 files into vendor/static_config/libssh2/win32. Add vendor/darwin/libssh2_config.h. Copy win32 or darwin directories from vendor/static_config/libssh2 into vendor/libssh2 during the Configure Libssh2 build step. Add vendor/libssh2/darwin to the include_dirs for MacOS builds of libssh2. (Windows already did this respective action).
Open Graph Description: Background: Per the discussion in #1566, we are opting to use a static libssh2_config.h for MacOS builds. tl;dr: The libssh2_config.h header file is generated as a side effect of running vendor/lib...
X Description: Background: Per the discussion in #1566, we are opting to use a static libssh2_config.h for MacOS builds. tl;dr: The libssh2_config.h header file is generated as a side effect of running vendor/lib...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1569
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:973ae718-db9b-8f28-fedc-6af85ccf05df |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C22:126C1F:2F7AC2:417D48:6A602989 |
| html-safe-nonce | 8c88c28211276740031f09984466ab56218be9ff56bea078da9cf36779014a90 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzIyOjEyNkMxRjoyRjdBQzI6NDE3RDQ4OjZBNjAyOTg5IiwidmlzaXRvcl9pZCI6IjcxMzYyODk4MTI4MDMyMzQxODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e7c86fab05559d62d6215bc424c3b1c281491f61e5ee072819285bf4fa8d3276 |
| hovercard-subject-tag | pull_request:223382938 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1569/files |
| twitter:image | https://avatars.githubusercontent.com/u/35500807?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/35500807?s=400&v=4 |
| og:image:alt | Background: Per the discussion in #1566, we are opting to use a static libssh2_config.h for MacOS builds. tl;dr: The libssh2_config.h header file is generated as a side effect of running vendor/lib... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60da8c2a42fa2bbf5f7567474990ec467836a84444262a58e200fa91b7f3d2d0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9824515e740d83d5eb82168a089b806ab0fe04a1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width