René's URL Explorer Experiment


Title: Fix asynchronous testing of signatures by tniessen · Pull Request #1505 · nodegit/nodegit · GitHub

Open Graph Title: Fix asynchronous testing of signatures by tniessen · Pull Request #1505 · nodegit/nodegit

X Title: Fix asynchronous testing of signatures by tniessen · Pull Request #1505 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: The previous implementation mixed promises and callbacks in a way that was incompatible with mocha. This patch removes the callback and uses promises only. If the test failed, an "unhandled pr...

X Description: The previous implementation mixed promises and callbacks in a way that was incompatible with mocha. This patch removes the callback and uses promises only. If the test failed, an "unhandle...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1505

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:98258b49-a141-5849-128a-7f183bc6f8b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB382:46C19:538A78:6F54FE:6A5FCD71
html-safe-nonce8c37b6501c35dc8dca75cc432a3958ee2b90de7c343cf39b912f2ef45b6b8641
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzgyOjQ2QzE5OjUzOEE3ODo2RjU0RkU6NkE1RkNENzEiLCJ2aXNpdG9yX2lkIjoiODYxOTE2NDQzOTI3NjI5MTY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd6257a45d0dd5826d7e92b785cea13e88fc0a38554f71767fcb30fe9e6f75a6d
hovercard-subject-tagpull_request:192427700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1505/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf695b48eb2a10baf8e28bbd557d1690a9283684d3c48c5b135ce9f7ce618c0e/nodegit/nodegit/pull/1505
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf695b48eb2a10baf8e28bbd557d1690a9283684d3c48c5b135ce9f7ce618c0e/nodegit/nodegit/pull/1505
og:image:altThe previous implementation mixed promises and callbacks in a way that was incompatible with mocha. This patch removes the callback and uses promises only. If the test failed, an "unhandled pr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None53a28a7799cbf673993ab89fc44869fea4c4a6545a861a4d1445e83e8d03aabd
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedc08399f879d576f0edbb8c52a0a1a30d498b203
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1505#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1505
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1505
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1505
Reloadhttps://github.com/nodegit/nodegit/pull/1505
Reloadhttps://github.com/nodegit/nodegit/pull/1505
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1505
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
tbranyenhttps://github.com/tbranyen
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tniessen:test-fix-signature-promise-rejectionhttps://github.com/tniessen/nodegit/tree/test-fix-signature-promise-rejection
Conversationhttps://github.com/nodegit/nodegit/pull/1505
Commits1 (1)https://github.com/nodegit/nodegit/pull/1505/commits
Checkshttps://github.com/nodegit/nodegit/pull/1505/checks
Files changedhttps://github.com/nodegit/nodegit/pull/1505/files
Fix asynchronous testing of signatureshttps://github.com/nodegit/nodegit/pull/1505#top
tbranyenhttps://github.com/tbranyen
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
tniessen:test-fix-signature-promise-rejectionhttps://github.com/tniessen/nodegit/tree/test-fix-signature-promise-rejection
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 4, 2018https://github.com/nodegit/nodegit/pull/1505#issue-329081348
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1505
https://github.com/tniessen
Fix asynchronous testing of signatureshttps://github.com/nodegit/nodegit/pull/1505/commits/92b3506eee7466fa4cfb95951e2e6c24c7af95ba
92b3506https://github.com/nodegit/nodegit/pull/1505/commits/92b3506eee7466fa4cfb95951e2e6c24c7af95ba
https://github.com/tbranyen
tbranyenhttps://github.com/tbranyen
Jun 5, 2018https://github.com/nodegit/nodegit/pull/1505#issuecomment-394782577
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1505
https://github.com/tbranyen
tbranyenhttps://github.com/tbranyen
fc56c94https://github.com/nodegit/nodegit/commit/fc56c94a7340409188fd01e1d785b8d3ddd00674
Jun 5, 2018https://github.com/nodegit/nodegit/pull/1505#event-1664217588
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1505
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1505
https://github.com/tniessen
https://github.com/tbranyen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.