Title: Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault by cjhoward92 · Pull Request #1368 · nodegit/nodegit · GitHub
Open Graph Title: Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault by cjhoward92 · Pull Request #1368 · nodegit/nodegit
X Title: Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault by cjhoward92 · Pull Request #1368 · nodegit/nodegit
Description: In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger buffers. Also removed some special case logic in the async_functions template that would prevent proper buffer method generation, and then updated descriptors for methods that require proper buffer allocations to be "shouldAlloc": true
Open Graph Description: In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger...
X Description: In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1368
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ba7c7759-0870-4f01-3152-af018e217dee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C03A:2658D0:6840B25:8F32443:6A5E9566 |
| html-safe-nonce | 831e424c918bd3ce705449cb7866914a39ecf918dbbb5779a6e7c1d04d7b6e50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDNBOjI2NThEMDo2ODQwQjI1OjhGMzI0NDM6NkE1RTk1NjYiLCJ2aXNpdG9yX2lkIjoiNTU3NjM0MzQ0MDE5NDQ0MjU5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4261c18a682f8f5ac939a8a193ed22a2361e8e268614e031af29c758f5ce699b |
| hovercard-subject-tag | pull_request:139681445 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1368/files |
| twitter:image | https://avatars.githubusercontent.com/u/4052959?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4052959?s=400&v=4 |
| og:image:alt | In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d2ac9bdd71d5f53f2b731c9330677e38624e301 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width