René's URL Explorer Experiment


Title: Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault by cjhoward92 · Pull Request #1368 · nodegit/nodegit · GitHub

Open Graph Title: Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault by cjhoward92 · Pull Request #1368 · nodegit/nodegit

X Title: Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfault by cjhoward92 · Pull Request #1368 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger...

X Description: In GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1368

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:122c2a23-f2fd-7d4c-df03-48cb908ab771
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEABA:2A4911:4367E3E:5838A12:6A5D3410
html-safe-nonceae5558415ebfc70b12811bec3ff89fa73578512687db26eff652ed1ff9e8504f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUJBOjJBNDkxMTo0MzY3RTNFOjU4MzhBMTI6NkE1RDM0MTAiLCJ2aXNpdG9yX2lkIjoiMTc0MDUwNTA3Mjk0MDE2ODIwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac562f1d300b8781d3b60a9846e759e60db3ffa76d1afd0e89fe64005e277db018
hovercard-subject-tagpull_request:139681445
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1368/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77f5ea91095e2ea07e6e45a13533272bc2413f3df72bac748847637c1a490029/nodegit/nodegit/pull/1368
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77f5ea91095e2ea07e6e45a13533272bc2413f3df72bac748847637c1a490029/nodegit/nodegit/pull/1368
og:image:altIn GitBuf::Set and GitBuf::Grow the buffers could only accept a maximum buffer of 256MB because of limits with v8 string sizes. Removed the conversion to string in those methods to allow for larger...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjhoward92
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1368#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1368
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1368
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1368
Reloadhttps://github.com/nodegit/nodegit/pull/1368
Reloadhttps://github.com/nodegit/nodegit/pull/1368
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1368
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
cjhoward92:fix_large_buffer_crasheshttps://github.com/cjhoward92/nodegit/tree/fix_large_buffer_crashes
Conversationhttps://github.com/nodegit/nodegit/pull/1368
Commits4 (4)https://github.com/nodegit/nodegit/pull/1368/commits
Checkshttps://github.com/nodegit/nodegit/pull/1368/checks
Files changedhttps://github.com/nodegit/nodegit/pull/1368/files
Fixed an issue where large buffer allocations in filters (> 256MB) causes a segfaulthttps://github.com/nodegit/nodegit/pull/1368#top
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
cjhoward92:fix_large_buffer_crasheshttps://github.com/cjhoward92/nodegit/tree/fix_large_buffer_crashes
https://github.com/cjhoward92
cjhoward92https://github.com/cjhoward92
Sep 6, 2017https://github.com/nodegit/nodegit/pull/1368#issue-255764466
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1368
cjhoward92https://github.com/cjhoward92
September 12, 2017 09:05https://github.com/nodegit/nodegit/pull/1368#commits-pushed-572f573
https://github.com/cjhoward92
Fixed filter tests to work with massive bufferhttps://github.com/nodegit/nodegit/pull/1368/commits/572f573a9a7d13b263e4d72d83ab8a45adc3635f
572f573https://github.com/nodegit/nodegit/pull/1368/commits/572f573a9a7d13b263e4d72d83ab8a45adc3635f
https://github.com/cjhoward92
Added variable for size and allocUnsafe for large allocationshttps://github.com/nodegit/nodegit/pull/1368/commits/a7f61ee1f4b90729f9fda7a804a03365fce41e1a
a7f61eehttps://github.com/nodegit/nodegit/pull/1368/commits/a7f61ee1f4b90729f9fda7a804a03365fce41e1a
https://github.com/cjhoward92
Updated methods to be shouldAlloc when an allocated buffer is neededhttps://github.com/nodegit/nodegit/pull/1368/commits/1cb96b490bdd16c12419cf6930164ea8c814aa65
1cb96b4https://github.com/nodegit/nodegit/pull/1368/commits/1cb96b490bdd16c12419cf6930164ea8c814aa65
https://github.com/implausible
implausiblehttps://github.com/implausible
force-pushedhttps://github.com/nodegit/nodegit/compare/9a4a6d72b0c90237ed136f7813e92b760581af25..9febe5d97b65b6db514f27c21810cb1811d1bf75
9a4a6d7https://github.com/nodegit/nodegit/commit/9a4a6d72b0c90237ed136f7813e92b760581af25
9febe5dhttps://github.com/nodegit/nodegit/commit/9febe5d97b65b6db514f27c21810cb1811d1bf75
Compare https://github.com/nodegit/nodegit/compare/9a4a6d72b0c90237ed136f7813e92b760581af25..9febe5d97b65b6db514f27c21810cb1811d1bf75
September 13, 2017 15:29https://github.com/nodegit/nodegit/pull/1368#event-1247500951
https://github.com/implausible
32 bit CI does not like 500 meg buffers.https://github.com/nodegit/nodegit/pull/1368/commits/658f5b7af814d57069fc16ebfa623b3d3dbe7daf
658f5b7https://github.com/nodegit/nodegit/pull/1368/commits/658f5b7af814d57069fc16ebfa623b3d3dbe7daf
https://github.com/implausible
implausiblehttps://github.com/implausible
force-pushedhttps://github.com/nodegit/nodegit/compare/9febe5d97b65b6db514f27c21810cb1811d1bf75..658f5b7af814d57069fc16ebfa623b3d3dbe7daf
9febe5dhttps://github.com/nodegit/nodegit/commit/9febe5d97b65b6db514f27c21810cb1811d1bf75
658f5b7https://github.com/nodegit/nodegit/commit/658f5b7af814d57069fc16ebfa623b3d3dbe7daf
Compare https://github.com/nodegit/nodegit/compare/9febe5d97b65b6db514f27c21810cb1811d1bf75..658f5b7af814d57069fc16ebfa623b3d3dbe7daf
September 13, 2017 15:49https://github.com/nodegit/nodegit/pull/1368#event-1247540931
https://github.com/implausible
implausiblehttps://github.com/implausible
d77f418https://github.com/nodegit/nodegit/commit/d77f418884ab95be7f07bec97ddeaf38be2c2a57
Sep 13, 2017https://github.com/nodegit/nodegit/pull/1368#event-1248061442
https://github.com/cjhoward92
cjhoward92https://github.com/cjhoward92
Oct 4, 2017 https://github.com/nodegit/nodegit/pull/1368#ref-issue-256094282
NodeGit does not expose a proper API for displaying large binary diffs #1369 https://github.com/nodegit/nodegit/issues/1369
https://github.com/cjhoward92
cjhoward92https://github.com/cjhoward92
October 16, 2017 18:44https://github.com/nodegit/nodegit/pull/1368#event-1295449900
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1368
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1368
https://github.com/cjhoward92
https://github.com/implausible
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.