René's URL Explorer Experiment


Title: BREAKING: Convert sync methods to async methods by cjhoward92 · Pull Request #1348 · nodegit/nodegit · GitHub

Open Graph Title: BREAKING: Convert sync methods to async methods by cjhoward92 · Pull Request #1348 · nodegit/nodegit

X Title: BREAKING: Convert sync methods to async methods by cjhoward92 · Pull Request #1348 · nodegit/nodegit

Description: Convert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that read from or write to disk should be asynchronous. This is a breaking change since the functions now return a promise and not the original return value. The addition of filters in #1331 caused issues with some core synchronous methods that cause deadlocks, such as merge and disk-reading methods. This PR replaces #1342

Open Graph Description: Convert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that...

X Description: Convert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1348

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:efbe5ba0-568f-8e17-3db0-f39c2485d50d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBBC:33B318:9C6718B:D37E456:6A5E955E
html-safe-noncefd64bf4efae71805d31a8504fed4b9f6db73f341b46295c3b1252300ebfe7d6e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkJDOjMzQjMxODo5QzY3MThCOkQzN0U0NTY6NkE1RTk1NUUiLCJ2aXNpdG9yX2lkIjoiNzczOTQ0MDM3NjY0NzE2MTE4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac46d21cda500a445fbb8d9f2af6259987b8feaa53589d9da0135744004a30196e
hovercard-subject-tagpull_request:134688521
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1348/files
twitter:imagehttps://avatars.githubusercontent.com/u/4052959?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4052959?s=400&v=4
og:image:altConvert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1348/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1348%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1348%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1348/files
Reloadhttps://github.com/nodegit/nodegit/pull/1348/files
Reloadhttps://github.com/nodegit/nodegit/pull/1348/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348/files
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
cjhoward92:fix/asyncify_methodshttps://github.com/cjhoward92/nodegit/tree/fix/asyncify_methods
Conversation 6 https://github.com/nodegit/nodegit/pull/1348
Commits 14 https://github.com/nodegit/nodegit/pull/1348/commits
Checks 0 https://github.com/nodegit/nodegit/pull/1348/checks
Files changed https://github.com/nodegit/nodegit/pull/1348/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348/files
BREAKING: Convert sync methods to async methods https://github.com/nodegit/nodegit/pull/1348/files#top
Show all changes 14 commits https://github.com/nodegit/nodegit/pull/1348/files
945b09d Convert git_status_file to an async method cjhoward92 Aug 2, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/945b09d79f4b34a7e709287acbed660bdc33e802
54a2786 removed comments Aug 2, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/54a278624740fdc4e049556d15010432080919d1
89c3489 BREAKING: Made Merge.merge async Aug 8, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/89c34899db978b618ff49a3b286595bd993d4927
9927174 updated rebase.commit to be async Aug 8, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/9927174ba75cb48e55896126778f203b82c39488
0f38993 Converted rebase abort to async mohseenrm Aug 9, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/0f389936116c033927f1099ef1923c063122b1f1
766d3dd Fixed error in continueRebase Aug 9, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/766d3dda0e5f1bc7dd72573c6afdabb2db005338
7e65c09 fixed linter error Aug 10, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/7e65c095343156b557c58441db89d2b3f72acbb4
6ded1d2 converted commit amend to async mohseenrm Aug 10, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/6ded1d23b278b8165896b7d103e4a9b335b9bc1d
63f4db0 Converting git_reflog_write to async mohseenrm Aug 10, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/63f4db04626503ae99ea3ae2b6b785eaea81897c
080e8aa babel cli fix for travis mohseenrm Aug 11, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/080e8aafe7354010f08cce842256070c313160ee
34a9e59 Reverted unnecessary babel changes. Aug 14, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/34a9e594ffcc3e4324325b3b4af7a340964c6fd2
2e32eeb Fixed status_file special case Aug 15, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/2e32eeb14f0e6c0b5e9afdef5387bc05d2188e2f
f39bf86 removed old callback style code Aug 15, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/f39bf863c123ff77cf85f51edc766313bdfd07c8
3b54899 Formatting; removed unnecessary return of 0 Aug 15, 2017 https://github.com/nodegit/nodegit/pull/1348/commits/3b548992f5cccd5c560d1460b8bf9253157408f0
Clear filters https://github.com/nodegit/nodegit/pull/1348/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348/files
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348/files
descriptor.json https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
rebase.js https://github.com/nodegit/nodegit/pull/1348/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
repository.js https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
merge.js https://github.com/nodegit/nodegit/pull/1348/files#diff-5eb8b43dbafa5405634bb41bca7a764882bdb088ab8071169bf9d8663aa7c727
rebase.js https://github.com/nodegit/nodegit/pull/1348/files#diff-76a7726b4f6a77683d9b7137945849a67913f57d68cf1d12a144710c5fabcc6c
generate/input/descriptor.jsonhttps://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
View file https://github.com/cjhoward92/nodegit/blob/3b548992f5cccd5c560d1460b8bf9253157408f0/generate/input/descriptor.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1348/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
https://github.com/nodegit/nodegit/pull/1348/files#diff-ff00cd010b7df4b1f1cd901205bce54d2c39c0752d2ab09b09bbe4a2ead48bf2
lib/rebase.jshttps://github.com/nodegit/nodegit/pull/1348/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
View file https://github.com/cjhoward92/nodegit/blob/3b548992f5cccd5c560d1460b8bf9253157408f0/lib/rebase.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1348/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1348/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
https://github.com/nodegit/nodegit/pull/1348/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
https://github.com/nodegit/nodegit/pull/1348/files#diff-dcc4f1e7063edd95dfa1718e8e0aaff10ba7120d6735135e65cd8d968bdfa4f7
lib/repository.jshttps://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
View file https://github.com/cjhoward92/nodegit/blob/3b548992f5cccd5c560d1460b8bf9253157408f0/lib/repository.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1348/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
https://github.com/nodegit/nodegit/pull/1348/files#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
test/tests/merge.jshttps://github.com/nodegit/nodegit/pull/1348/files#diff-5eb8b43dbafa5405634bb41bca7a764882bdb088ab8071169bf9d8663aa7c727
View file https://github.com/cjhoward92/nodegit/blob/3b548992f5cccd5c560d1460b8bf9253157408f0/test/tests/merge.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1348/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1348/files#diff-5eb8b43dbafa5405634bb41bca7a764882bdb088ab8071169bf9d8663aa7c727
https://github.com/nodegit/nodegit/pull/1348/files#diff-5eb8b43dbafa5405634bb41bca7a764882bdb088ab8071169bf9d8663aa7c727
test/tests/rebase.jshttps://github.com/nodegit/nodegit/pull/1348/files#diff-76a7726b4f6a77683d9b7137945849a67913f57d68cf1d12a144710c5fabcc6c
View file https://github.com/cjhoward92/nodegit/blob/3b548992f5cccd5c560d1460b8bf9253157408f0/test/tests/rebase.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/1348/{{ revealButtonHref }}
https://github.com/nodegit/nodegit/pull/1348/files#diff-76a7726b4f6a77683d9b7137945849a67913f57d68cf1d12a144710c5fabcc6c
https://github.com/nodegit/nodegit/pull/1348/files#diff-76a7726b4f6a77683d9b7137945849a67913f57d68cf1d12a144710c5fabcc6c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.