René's URL Explorer Experiment


Title: BREAKING: Convert sync methods to async methods by cjhoward92 · Pull Request #1348 · nodegit/nodegit · GitHub

Open Graph Title: BREAKING: Convert sync methods to async methods by cjhoward92 · Pull Request #1348 · nodegit/nodegit

X Title: BREAKING: Convert sync methods to async methods by cjhoward92 · Pull Request #1348 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: Convert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that...

X Description: Convert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that...

Opengraph URL: https://github.com/nodegit/nodegit/pull/1348

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3d52d8a-8f82-5190-c7dd-b9565cf950a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8078:251DF3:4875800:6041D2B:6A5D8DE0
html-safe-nonceedda3f3c291e568fa7cd7b6899a8083358be987ab82b3aff9ba604ff3d22475c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDc4OjI1MURGMzo0ODc1ODAwOjYwNDFEMkI6NkE1RDhERTAiLCJ2aXNpdG9yX2lkIjoiNzkxNzA3NzI0NzU5NzMxNzYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8e6a678f913ba0fc1e250e42300104f990e2fe4282377bfc4613c3c75cad8ea7
hovercard-subject-tagpull_request:134688521
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1348/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b54eb23b895c1907c411c74f5f2501ca50c395cfeba6fd7c555a1f1de4c78e7d/nodegit/nodegit/pull/1348
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b54eb23b895c1907c411c74f5f2501ca50c395cfeba6fd7c555a1f1de4c78e7d/nodegit/nodegit/pull/1348
og:image:altConvert the following routines to be async routines: NodeGit.Status.file NodeGit.Merge.merge rebase.commit rebase.abort Commit.amend Reflog.write This is to help avoid deadlocks as functions that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjhoward92
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1348#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1348
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1348
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1348
Reloadhttps://github.com/nodegit/nodegit/pull/1348
Reloadhttps://github.com/nodegit/nodegit/pull/1348
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
cjhoward92:fix/asyncify_methodshttps://github.com/cjhoward92/nodegit/tree/fix/asyncify_methods
Conversationhttps://github.com/nodegit/nodegit/pull/1348
Commits14 (14)https://github.com/nodegit/nodegit/pull/1348/commits
Checkshttps://github.com/nodegit/nodegit/pull/1348/checks
Files changedhttps://github.com/nodegit/nodegit/pull/1348/files
BREAKING: Convert sync methods to async methodshttps://github.com/nodegit/nodegit/pull/1348#top
implausiblehttps://github.com/implausible
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
cjhoward92:fix/asyncify_methodshttps://github.com/cjhoward92/nodegit/tree/fix/asyncify_methods
https://github.com/cjhoward92
cjhoward92https://github.com/cjhoward92
Aug 8, 2017https://github.com/nodegit/nodegit/pull/1348#issue-248752782
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
#1331https://github.com/nodegit/nodegit/pull/1331
#1342https://github.com/nodegit/nodegit/pull/1342
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
cjhoward92https://github.com/cjhoward92
August 2, 2017 15:23https://github.com/nodegit/nodegit/pull/1348#commits-pushed-945b09d
https://github.com/cjhoward92
Convert git_status_file to an async methodhttps://github.com/nodegit/nodegit/pull/1348/commits/945b09d79f4b34a7e709287acbed660bdc33e802
945b09dhttps://github.com/nodegit/nodegit/pull/1348/commits/945b09d79f4b34a7e709287acbed660bdc33e802
removed commentshttps://github.com/nodegit/nodegit/pull/1348/commits/54a278624740fdc4e049556d15010432080919d1
54a2786https://github.com/nodegit/nodegit/pull/1348/commits/54a278624740fdc4e049556d15010432080919d1
BREAKING: Made Merge.merge asynchttps://github.com/nodegit/nodegit/pull/1348/commits/89c34899db978b618ff49a3b286595bd993d4927
89c3489https://github.com/nodegit/nodegit/pull/1348/commits/89c34899db978b618ff49a3b286595bd993d4927
https://github.com/cjhoward92
cjhoward92https://github.com/cjhoward92
Aug 8, 2017 https://github.com/nodegit/nodegit/pull/1348#ref-pullrequest-247540847
BREAKING: Convert git_status_file to an async method #1342 https://github.com/nodegit/nodegit/pull/1342
August 8, 2017 12:11https://github.com/nodegit/nodegit/pull/1348#commits-pushed-9927174
updated rebase.commit to be asynchttps://github.com/nodegit/nodegit/pull/1348/commits/9927174ba75cb48e55896126778f203b82c39488
9927174https://github.com/nodegit/nodegit/pull/1348/commits/9927174ba75cb48e55896126778f203b82c39488
https://github.com/mohseenrm
Converted rebase abort to asynchttps://github.com/nodegit/nodegit/pull/1348/commits/0f389936116c033927f1099ef1923c063122b1f1
0f38993https://github.com/nodegit/nodegit/pull/1348/commits/0f389936116c033927f1099ef1923c063122b1f1
Fixed error in continueRebasehttps://github.com/nodegit/nodegit/pull/1348/commits/766d3dda0e5f1bc7dd72573c6afdabb2db005338
766d3ddhttps://github.com/nodegit/nodegit/pull/1348/commits/766d3dda0e5f1bc7dd72573c6afdabb2db005338
https://github.com/rcjsuen
rcjsuenhttps://github.com/rcjsuen
Aug 10, 2017 https://github.com/nodegit/nodegit/pull/1348#pullrequestreview-55419493
View reviewed changes https://github.com/nodegit/nodegit/pull/1348/files/766d3dda0e5f1bc7dd72573c6afdabb2db005338
lib/repository.jshttps://github.com/nodegit/nodegit/pull/1348/files/0f389936116c033927f1099ef1923c063122b1f1..766d3dda0e5f1bc7dd72573c6afdabb2db005338#diff-a5a24674185f8dddf909d0208f70be34ba44b2a6070948169ac766671a185ddc
rcjsuenhttps://github.com/rcjsuen
Aug 10, 2017https://github.com/nodegit/nodegit/pull/1348#discussion_r132349164
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
cjhoward92https://github.com/cjhoward92
Aug 10, 2017https://github.com/nodegit/nodegit/pull/1348#discussion_r132475215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
August 10, 2017 08:03https://github.com/nodegit/nodegit/pull/1348#commits-pushed-7e65c09
fixed linter errorhttps://github.com/nodegit/nodegit/pull/1348/commits/7e65c095343156b557c58441db89d2b3f72acbb4
7e65c09https://github.com/nodegit/nodegit/pull/1348/commits/7e65c095343156b557c58441db89d2b3f72acbb4
https://github.com/mohseenrm
converted commit amend to asynchttps://github.com/nodegit/nodegit/pull/1348/commits/6ded1d23b278b8165896b7d103e4a9b335b9bc1d
6ded1d2https://github.com/nodegit/nodegit/pull/1348/commits/6ded1d23b278b8165896b7d103e4a9b335b9bc1d
https://github.com/mohseenrm
Converting git_reflog_write to asynchttps://github.com/nodegit/nodegit/pull/1348/commits/63f4db04626503ae99ea3ae2b6b785eaea81897c
63f4db0https://github.com/nodegit/nodegit/pull/1348/commits/63f4db04626503ae99ea3ae2b6b785eaea81897c
https://github.com/mohseenrm
babel cli fix for travishttps://github.com/nodegit/nodegit/pull/1348/commits/080e8aafe7354010f08cce842256070c313160ee
080e8aahttps://github.com/nodegit/nodegit/pull/1348/commits/080e8aafe7354010f08cce842256070c313160ee
https://github.com/cjhoward92
cjhoward92https://github.com/cjhoward92
Aug 14, 2017 https://github.com/nodegit/nodegit/pull/1348#pullrequestreview-56104822
View reviewed changes https://github.com/nodegit/nodegit/pull/1348/files/080e8aafe7354010f08cce842256070c313160ee
package.jsonhttps://github.com/nodegit/nodegit/pull/1348/files/63f4db04626503ae99ea3ae2b6b785eaea81897c..080e8aafe7354010f08cce842256070c313160ee#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
cjhoward92https://github.com/cjhoward92
Aug 14, 2017https://github.com/nodegit/nodegit/pull/1348#discussion_r132973905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mohseenrmhttps://github.com/mohseenrm
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
mohseenrmhttps://github.com/mohseenrm
Aug 14, 2017https://github.com/nodegit/nodegit/pull/1348#discussion_r133032193
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
Reverted unnecessary babel changes.https://github.com/nodegit/nodegit/pull/1348/commits/34a9e594ffcc3e4324325b3b4af7a340964c6fd2
34a9e59https://github.com/nodegit/nodegit/pull/1348/commits/34a9e594ffcc3e4324325b3b4af7a340964c6fd2
https://github.com/implausible
implausiblehttps://github.com/implausible
Aug 15, 2017 https://github.com/nodegit/nodegit/pull/1348#pullrequestreview-56479330
View reviewed changes https://github.com/nodegit/nodegit/pull/1348/files/080e8aafe7354010f08cce842256070c313160ee
generate/templates/partials/async_function.cchttps://github.com/nodegit/nodegit/pull/1348/files/080e8aafe7354010f08cce842256070c313160ee#diff-75aa5e6f48aaf84e3ba76da9670589713cd82043e55a5509e7c197742e5032ca
implausiblehttps://github.com/implausible
Aug 15, 2017https://github.com/nodegit/nodegit/pull/1348#discussion_r133311936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
generate/templates/partials/async_function.cchttps://github.com/nodegit/nodegit/pull/1348/files/080e8aafe7354010f08cce842256070c313160ee#diff-75aa5e6f48aaf84e3ba76da9670589713cd82043e55a5509e7c197742e5032ca
implausiblehttps://github.com/implausible
Aug 15, 2017https://github.com/nodegit/nodegit/pull/1348#discussion_r133312051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
August 15, 2017 14:52https://github.com/nodegit/nodegit/pull/1348#commits-pushed-2e32eeb
Fixed status_file special casehttps://github.com/nodegit/nodegit/pull/1348/commits/2e32eeb14f0e6c0b5e9afdef5387bc05d2188e2f
2e32eebhttps://github.com/nodegit/nodegit/pull/1348/commits/2e32eeb14f0e6c0b5e9afdef5387bc05d2188e2f
removed old callback style codehttps://github.com/nodegit/nodegit/pull/1348/commits/f39bf863c123ff77cf85f51edc766313bdfd07c8
f39bf86https://github.com/nodegit/nodegit/pull/1348/commits/f39bf863c123ff77cf85f51edc766313bdfd07c8
Formatting; removed unnecessary return of 0https://github.com/nodegit/nodegit/pull/1348/commits/3b548992f5cccd5c560d1460b8bf9253157408f0
3b54899https://github.com/nodegit/nodegit/pull/1348/commits/3b548992f5cccd5c560d1460b8bf9253157408f0
https://github.com/implausible
implausiblehttps://github.com/implausible
Aug 16, 2017 https://github.com/nodegit/nodegit/pull/1348#pullrequestreview-56654671
View reviewed changes https://github.com/nodegit/nodegit/pull/1348/files/3b548992f5cccd5c560d1460b8bf9253157408f0
https://github.com/implausible
implausiblehttps://github.com/implausible
427f987https://github.com/nodegit/nodegit/commit/427f9872db4f63c0ba92934ea5bbab4c12b137b4
Aug 16, 2017https://github.com/nodegit/nodegit/pull/1348#event-1208428229
emmax86https://github.com/emmax86
Feb 1, 2019 https://github.com/nodegit/nodegit/pull/1348#ref-commit-74e7c1e
https://github.com/emmax86
Only swallow EAPPLIED errors in Repository.prototype.continueRebasehttps://github.com/emmax86/nodegit/commit/74e7c1e89ab21801ca6ee13443ef813c05e04b93
74e7c1ehttps://github.com/emmax86/nodegit/commit/74e7c1e89ab21801ca6ee13443ef813c05e04b93
nodegit#1348https://github.com/nodegit/nodegit/pull/1348
https://github.com/emmax86
emmax86https://github.com/emmax86
Feb 1, 2019 https://github.com/nodegit/nodegit/pull/1348#ref-pullrequest-405850375
Breaking: Repository.prototype.continueRebase enhancements #1619 https://github.com/nodegit/nodegit/pull/1619
https://github.co/hiddenchars
https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1348
https://github.com/rcjsuen
rcjsuen https://github.com/rcjsuen
https://github.com/nodegit/nodegit/pull/1348/files/766d3dda0e5f1bc7dd72573c6afdabb2db005338
https://github.com/implausible
implausible https://github.com/implausible
https://github.com/nodegit/nodegit/pull/1348/files/3b548992f5cccd5c560d1460b8bf9253157408f0
https://github.com/mohseenrm
mohseenrm https://github.com/mohseenrm
https://github.com/nodegit/nodegit/pull/1348/files/080e8aafe7354010f08cce842256070c313160ee
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1348
https://github.com/cjhoward92
https://github.com/implausible
https://github.com/mohseenrm
https://github.com/rcjsuen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.