| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:01b5f48d-0be7-7dc9-d47e-e51f418b0a16 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA9E:250F5A:3EE1918:51A25D3:69751577 |
| html-safe-nonce | 8c600ac49d47d0201804070d0a493e65a0b015073620b947135c0fb017f2f55b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTlFOjI1MEY1QTozRUUxOTE4OjUxQTI1RDM6Njk3NTE1NzciLCJ2aXNpdG9yX2lkIjoiNDc4OTYwMzQ4OTk1MDI3NDkzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b0c50f29b85994867bac128abd233a4d77a691f19235334aa58d50c97aeb8709 |
| hovercard-subject-tag | pull_request:87935361 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1143/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8607983c30882d87911c37680817cd2b46fd3977b4d1926a0b33e7917fb53081/nodegit/nodegit/pull/1143 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8607983c30882d87911c37680817cd2b46fd3977b4d1926a0b33e7917fb53081/nodegit/nodegit/pull/1143 |
| og:image:alt | Even though we had the /EHsc option in the gyp file, it was not being applied correctly. With the change, the option does get applied, which also takes care of numerous build warnings like this on... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | srajko |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodegit/nodegit/pull/1143#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1143 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1143 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodegit%2Fnodegit |
| Reload | https://github.com/nodegit/nodegit/pull/1143 |
| Reload | https://github.com/nodegit/nodegit/pull/1143 |
| Reload | https://github.com/nodegit/nodegit/pull/1143 |
|
nodegit
| https://github.com/nodegit |
| nodegit | https://github.com/nodegit/nodegit |
|
Notifications
| https://github.com/login?return_to=%2Fnodegit%2Fnodegit |
|
Fork
697
| https://github.com/login?return_to=%2Fnodegit%2Fnodegit |
|
Star
5.8k
| https://github.com/login?return_to=%2Fnodegit%2Fnodegit |
|
Code
| https://github.com/nodegit/nodegit |
|
Issues
343
| https://github.com/nodegit/nodegit/issues |
|
Pull requests
19
| https://github.com/nodegit/nodegit/pulls |
|
Actions
| https://github.com/nodegit/nodegit/actions |
|
Projects
0
| https://github.com/nodegit/nodegit/projects |
|
Security
0
| https://github.com/nodegit/nodegit/security |
|
Insights
| https://github.com/nodegit/nodegit/pulse |
|
Code
| https://github.com/nodegit/nodegit |
|
Issues
| https://github.com/nodegit/nodegit/issues |
|
Pull requests
| https://github.com/nodegit/nodegit/pulls |
|
Actions
| https://github.com/nodegit/nodegit/actions |
|
Projects
| https://github.com/nodegit/nodegit/projects |
|
Security
| https://github.com/nodegit/nodegit/security |
|
Insights
| https://github.com/nodegit/nodegit/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodegit%2Fnodegit%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodegit/nodegit/pull/1143#issue-comment-box |
| johnhaley81 | https://github.com/johnhaley81 |
| nodegit:master | https://github.com/nodegit/nodegit/tree/master |
| srajko:win-exception-handling | https://github.com/srajko/nodegit/tree/win-exception-handling |
|
Fix windows exception handling in build
| https://github.com/nodegit/nodegit/pull/1143#top |
| johnhaley81 | https://github.com/johnhaley81 |
| nodegit:master | https://github.com/nodegit/nodegit/tree/master |
| srajko:win-exception-handling | https://github.com/srajko/nodegit/tree/win-exception-handling |
|
Conversation
6
| https://github.com/nodegit/nodegit/pull/1143 |
|
Commits
2
| https://github.com/nodegit/nodegit/pull/1143/commits |
|
Checks
0
| https://github.com/nodegit/nodegit/pull/1143/checks |
|
Files changed
| https://github.com/nodegit/nodegit/pull/1143/files |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.co/hiddenchars |
| https://github.com/nodegit/nodegit/pull/{{ revealButtonHref }} |
|
| https://github.com/srajko |
| srajko | https://github.com/srajko |
| Oct 4, 2016 | https://github.com/nodegit/nodegit/pull/1143#issue-180950842 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.com/saper |
| saper | https://github.com/saper |
| Oct 5, 2016 | https://github.com/nodegit/nodegit/pull/1143#issuecomment-251595669 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.com/srajko |
| srajko | https://github.com/srajko |
| force-pushed | https://github.com/nodegit/nodegit/compare/7e3532bd37ff66c15e61add800228c02884f3a01..26f65e1e94cf904168643ddc4564e632a60d09a3 |
| 7e3532b | https://github.com/nodegit/nodegit/commit/7e3532bd37ff66c15e61add800228c02884f3a01 |
| 26f65e1 | https://github.com/nodegit/nodegit/commit/26f65e1e94cf904168643ddc4564e632a60d09a3 |
|
Compare
| https://github.com/nodegit/nodegit/compare/7e3532bd37ff66c15e61add800228c02884f3a01..26f65e1e94cf904168643ddc4564e632a60d09a3 |
| October 5, 2016 18:03 | https://github.com/nodegit/nodegit/pull/1143#event-813664794 |
| https://github.com/srajko |
| srajko | https://github.com/srajko |
| Oct 5, 2016 | https://github.com/nodegit/nodegit/pull/1143#issuecomment-251771816 |
| @saper | https://github.com/saper |
| https://ci.appveyor.com/project/TimBranyen/nodegit/build/3029 | https://ci.appveyor.com/project/TimBranyen/nodegit/build/3029 |
| https://ci.appveyor.com/project/TimBranyen/nodegit/build/3031 | https://ci.appveyor.com/project/TimBranyen/nodegit/build/3031 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.com/saper |
| saper | https://github.com/saper |
| Oct 5, 2016 | https://github.com/nodegit/nodegit/pull/1143#issuecomment-251782849 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.com/saper |
| saper | https://github.com/saper |
| Oct 5, 2016 | https://github.com/nodegit/nodegit/pull/1143#issuecomment-251783561 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.com/srajko |
| srajko | https://github.com/srajko |
| force-pushed | https://github.com/nodegit/nodegit/compare/26f65e1e94cf904168643ddc4564e632a60d09a3..315208f28ef3d0ec5fdbc18a40672a1772095d32 |
| 26f65e1 | https://github.com/nodegit/nodegit/commit/26f65e1e94cf904168643ddc4564e632a60d09a3 |
| 315208f | https://github.com/nodegit/nodegit/commit/315208f28ef3d0ec5fdbc18a40672a1772095d32 |
|
Compare
| https://github.com/nodegit/nodegit/compare/26f65e1e94cf904168643ddc4564e632a60d09a3..315208f28ef3d0ec5fdbc18a40672a1772095d32 |
| October 5, 2016 20:09 | https://github.com/nodegit/nodegit/pull/1143#event-813831259 |
| https://github.com/srajko |
| srajko | https://github.com/srajko |
| Oct 5, 2016 | https://github.com/nodegit/nodegit/pull/1143#issuecomment-251794113 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://ci.appveyor.com/project/TimBranyen/nodegit/build/3032 | https://ci.appveyor.com/project/TimBranyen/nodegit/build/3032 |
| https://ci.appveyor.com/project/TimBranyen/nodegit/build/3030 | https://ci.appveyor.com/project/TimBranyen/nodegit/build/3030 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| https://github.com/saper |
| saper | https://github.com/saper |
| Oct 6, 2016 | https://github.com/nodegit/nodegit/pull/1143#issuecomment-251876686 |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
| srajko | https://github.com/srajko |
| October 7, 2016 09:17 | https://github.com/nodegit/nodegit/pull/1143#commits-pushed-1318e7e |
|
| https://github.com/srajko |
| Fix application of /EHsc option | https://github.com/nodegit/nodegit/pull/1143/commits/1318e7eae1202dc8ebc22754fc970f2c020fff0c |
| 1318e7e | https://github.com/nodegit/nodegit/pull/1143/commits/1318e7eae1202dc8ebc22754fc970f2c020fff0c |
|
| https://github.com/srajko |
| Pull in identical settings to shared section | https://github.com/nodegit/nodegit/pull/1143/commits/e3d58995c05a89af0e701daaba07ee167ba5130a |
| e3d5899 | https://github.com/nodegit/nodegit/pull/1143/commits/e3d58995c05a89af0e701daaba07ee167ba5130a |
| https://github.com/srajko |
| srajko | https://github.com/srajko |
| force-pushed | https://github.com/nodegit/nodegit/compare/315208f28ef3d0ec5fdbc18a40672a1772095d32..e3d58995c05a89af0e701daaba07ee167ba5130a |
| 315208f | https://github.com/nodegit/nodegit/commit/315208f28ef3d0ec5fdbc18a40672a1772095d32 |
| e3d5899 | https://github.com/nodegit/nodegit/commit/e3d58995c05a89af0e701daaba07ee167ba5130a |
|
Compare
| https://github.com/nodegit/nodegit/compare/315208f28ef3d0ec5fdbc18a40672a1772095d32..e3d58995c05a89af0e701daaba07ee167ba5130a |
| October 7, 2016 16:18 | https://github.com/nodegit/nodegit/pull/1143#event-816460013 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
|
Oct 7, 2016
| https://github.com/nodegit/nodegit/pull/1143#pullrequestreview-3380269 |
|
View reviewed changes
| https://github.com/nodegit/nodegit/pull/1143/files/e3d58995c05a89af0e701daaba07ee167ba5130a |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| bd54fa8 | https://github.com/nodegit/nodegit/commit/bd54fa822ca9a9c02da6ac998ce18c14c3a341be |
| Oct 7, 2016 | https://github.com/nodegit/nodegit/pull/1143#event-816806954 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| October 7, 2016 21:16 | https://github.com/nodegit/nodegit/pull/1143#event-816806980 |
| https://github.com/johnhaley81 |
| johnhaley81 | https://github.com/johnhaley81 |
| Feb 6, 2017 | https://github.com/nodegit/nodegit/pull/1143#event-950916036 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1143 |
|
| https://github.com/johnhaley81 |
|
johnhaley81
| https://github.com/johnhaley81 |
|
| https://github.com/nodegit/nodegit/pull/1143/files/e3d58995c05a89af0e701daaba07ee167ba5130a |
| Please reload this page | https://github.com/nodegit/nodegit/pull/1143 |
|
| https://github.com/srajko |
|
| https://github.com/saper |
|
| https://github.com/johnhaley81 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |