Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit · GitHub
Open Graph Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit
X Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit
Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.
Open Graph Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.
X Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.
Opengraph URL: https://github.com/nodegit/nodegit/pull/1047
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c0d437b4-ee5d-4f95-a6bf-03ec5b9f7d79 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A582:17BD60:7BFAB1:A775BE:6A5EE3FD |
| html-safe-nonce | 9c4f962d1646817302bdfe0c7afc675e38195d468c271a1b0b50976f09f662fa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTgyOjE3QkQ2MDo3QkZBQjE6QTc3NUJFOjZBNUVFM0ZEIiwidmlzaXRvcl9pZCI6IjQ0OTUwNzc0ODUyMDg0NjMzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6176b5b57d53ad4c09a8d213887454978950d12dcc6b9180ebf8fcd1abda998e |
| hovercard-subject-tag | pull_request:72995566 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1047/files |
| twitter:image | https://avatars.githubusercontent.com/u/1152779?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1152779?s=400&v=4 |
| og:image:alt | When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 82d0004a35927bdb00c652a57f456c55aa0eda4ade1bc7956d7510fdea6e454b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d2d913dd727d2d7ac189fb4d05b10bc34ecd03ee |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width