René's URL Explorer Experiment


Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit · GitHub

Open Graph Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit

X Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit

Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.

Open Graph Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.

X Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.

Opengraph URL: https://github.com/nodegit/nodegit/pull/1047

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:4ca4df3b-8fcf-f3fb-1110-eb6893d8ab0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8316:2CAC3A:9639605:CA9B28E:6A5E8280
html-safe-nonce824b465496e869d5cfa9d51c30152d8f0c525deb346f0cdc70a086ab15c55aae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzE2OjJDQUMzQTo5NjM5NjA1OkNBOUIyOEU6NkE1RTgyODAiLCJ2aXNpdG9yX2lkIjoiMTc0OTM4ODkxMjE0NDMxOTEwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf501e0d8cb7b6deb7a95ed61c6272e4637a083aacbf7318cab9b81526774e22b
hovercard-subject-tagpull_request:72995566
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1047/commits
twitter:imagehttps://opengraph.githubassets.com/407aa0e1f6b9fed5cd415628e5f8d56fea7c9c654566416a69fe4b013592885c/nodegit/nodegit/pull/1047
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/407aa0e1f6b9fed5cd415628e5f8d56fea7c9c654566416a69fe4b013592885c/nodegit/nodegit/pull/1047
og:image:altWhen using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewasadigi
hostnamegithub.com
expected-hostnamegithub.com
Nonee0c30ec4bc4cc128be7eee7ef869507723a2ac9916267b7e0d370b3580a5e7ba
turbo-cache-controlno-cache
go-importgithub.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id1383170
octolytics-dimension-repository_nwonodegit/nodegit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1383170
octolytics-dimension-repository_network_root_nwonodegit/nodegit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release68ef39d284f7f48d37e751bc9bc0a9a4166228d5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/nodegit/pull/1047/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1047%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Fnodegit%2Fpull%2F1047%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodegit%2Fnodegit
Reloadhttps://github.com/nodegit/nodegit/pull/1047/commits
Reloadhttps://github.com/nodegit/nodegit/pull/1047/commits
Reloadhttps://github.com/nodegit/nodegit/pull/1047/commits
Please reload this pagehttps://github.com/nodegit/nodegit/pull/1047/commits
nodegit https://github.com/nodegit
nodegithttps://github.com/nodegit/nodegit
Notifications https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Fork 698 https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Star 5.8k https://github.com/login?return_to=%2Fnodegit%2Fnodegit
Code https://github.com/nodegit/nodegit
Issues 343 https://github.com/nodegit/nodegit/issues
Pull requests 20 https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality 0 https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
Code https://github.com/nodegit/nodegit
Issues https://github.com/nodegit/nodegit/issues
Pull requests https://github.com/nodegit/nodegit/pulls
Actions https://github.com/nodegit/nodegit/actions
Projects https://github.com/nodegit/nodegit/projects
Security and quality https://github.com/nodegit/nodegit/security
Insights https://github.com/nodegit/nodegit/pulse
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
wasadigi:masterhttps://github.com/wasadigi/nodegit/tree/master
Conversationhttps://github.com/nodegit/nodegit/pull/1047
Commits1 (1)https://github.com/nodegit/nodegit/pull/1047/commits
Checkshttps://github.com/nodegit/nodegit/pull/1047/checks
Files changedhttps://github.com/nodegit/nodegit/pull/1047/files
Replace then() with done(), so that error callback is not swalled by …https://github.com/nodegit/nodegit/pull/1047/commits#top
johnhaley81https://github.com/johnhaley81
nodegit:masterhttps://github.com/nodegit/nodegit/tree/master
wasadigi:masterhttps://github.com/wasadigi/nodegit/tree/master
Replace then() with done(), so that error callback is not swalled by revwalk walkerhttps://github.com/nodegit/nodegit/pull/1047/commits/80e1a01b7c633362f198f7b0db8cab815e1c6d54
https://github.com/wasadigi
wasadigihttps://github.com/nodegit/nodegit/commits?author=wasadigi
80e1a01https://github.com/nodegit/nodegit/pull/1047/commits/80e1a01b7c633362f198f7b0db8cab815e1c6d54
https://github.com/nodegit/nodegit/tree/80e1a01b7c633362f198f7b0db8cab815e1c6d54
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.