Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit · GitHub
Open Graph Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit
X Title: Replace then() with done(), so that error callback is not swalled by … by wasadigi · Pull Request #1047 · nodegit/nodegit
Description: Native Node bindings to Git. Contribute to nodegit/nodegit development by creating an account on GitHub.
Open Graph Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.
X Description: When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue.
Opengraph URL: https://github.com/nodegit/nodegit/pull/1047
X: @github
Domain: github.com
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e8d58e4a-0624-e77a-1924-76b582454bc9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8270:33615A:17CDB41:1FDA918:6A5D3410 |
| html-safe-nonce | 9c7463570e187a185f79e526bb785568d96c3786b586e96796e6ea216ce8f431 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjcwOjMzNjE1QToxN0NEQjQxOjFGREE5MTg6NkE1RDM0MTAiLCJ2aXNpdG9yX2lkIjoiMzE4NDgxMDA5NDIyOTcxOTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 15ac1543daf1f409dfc12779bf17e64cb002c436c0149d7c920552ae504f75be |
| hovercard-subject-tag | pull_request:72995566 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodegit/nodegit/1047/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/407aa0e1f6b9fed5cd415628e5f8d56fea7c9c654566416a69fe4b013592885c/nodegit/nodegit/pull/1047 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/407aa0e1f6b9fed5cd415628e5f8d56fea7c9c654566416a69fe4b013592885c/nodegit/nodegit/pull/1047 |
| og:image:alt | When using the revwalk.walk function, if I make an error in the implementation of my callback, it is swalled by the code. Replacing then() with done() fixes the issue. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | wasadigi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width