René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Threading model","articleBody":":wave: \n\nI've been plumbing the depths of nodegit to understand how all the pieces fit together. I'm a bit concerned about the threading model.\n\nMy understanding:\n1. We enqueue asynchronous work with [`Nan::AsyncQueueWorker`](https://github.com/nodegit/nodegit/blob/c4292de4adb091c1fa7daed8515c105776714310/generate/templates/partials/async_function.cc#L77).\n2. `Nan::AsyncQueueWorker` calls [`uv_queue_work`](https://github.com/nodejs/nan/blob/367e82a60fbaa52716232cc89db1cc3f685d77d9/nan.h#L1702-L1709).\n3. `uv_queue_work` [enqueues the work on a threadpool](http://docs.libuv.org/en/v1.x/threadpool.html#c.uv_queue_work).\n\nThis means:\n1. We could do work on multiple threads at once.\n2. libgit2 says its objects [shouldn't be used across multiple threads at once](https://github.com/libgit2/libgit2/blob/6aa06b65cfcce164d7ad3ef184f40acb68406078/THREADING.md#sharing-objects).\n3. We could end up accessing the same objects across multiple threads at once, most often the repository object.\n4. Potential :boom:, definite violation of libgit2's threading model.\n\nIs my understanding correct? Am I missing something?\n","author":{"url":"https://github.com/joshaber","@type":"Person","name":"joshaber"},"datePublished":"2015-12-11T15:59:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":15},"url":"https://github.com/827/nodegit/issues/827"}