René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect commit oid's when aggregated from commit.history()","articleBody":"If we take the example code that mirrors git log. And have it run on the aggregated commits rather than on each commit event like so:\n\n``` javascript\nvar git = require('nodegit'),\n    async = require('async');\n\n// Open the repository in the current directory.\ngit.repo('.git', function(error, repository) {\n  if (error) {\n    throw error;\n  }\n\n  // Use the master branch.\n  repository.branch('master', function(error, branch) {\n    if (error) {\n      throw error;\n    }\n\n    branch.history().on('end', function(err, commits){\n        commits.forEach(function(commit){\n                 // Print out `git log` emulation.\n            async.series([\n                function(callback) {\n                    commit.sha(callback);\n                },\n                function(callback) {\n                    commit.time(callback);\n                },\n                function(callback) {\n                    commit.author(function(error, author) {\n                        author.name(callback);\n                    });\n                },\n                function(callback) {\n                    commit.author(function(error, author) {\n                        author.email(callback);\n                    });\n                },\n                function(callback) {\n                    commit.message(callback);\n                }\n            ], function printCommit(error, results) {\n                console.log('SHA ' + results[0]);\n                console.log(new Date(results[1] * 1000));\n                console.log(results[2] + ' \u003c' + results[3] + '\u003e');\n                console.log(results[4]);\n            });\n        });\n    });\n  });\n});\n```\n\nThen all the commit sha's are wrong. And most if not all of them point to nonexistant commits. Compare the outputs of the two versions of the program:\n(I edited out the emails)\n\nOriginal in README.md:\n\n```\nSHA a581e81d0205f27ede6a5557431a7ad16b4d4c60\nMon Jan 03 45538 18:06:40 GMT-0500 (EST)\nademoss \u003c------------------------\u003e\nInitial commit\n\nSHA 38e52f3dea8aac939168b4968f7f2688b9ce5a2e\nWed Jul 04 45551 06:20:00 GMT-0400 (EDT)\nAnthony De Moss \u003c------------------------\u003e\n- initial commit\n\nSHA 9976fc4546bca7d152453be2c0c9ca59ca9bad7a\nSat Mar 01 45552 11:03:20 GMT-0500 (EST)\nJohn renner \u003c------------------------\u003e\nInitial implementation\n\nSHA 700636e2d84f29a4ca8cfcc9b1c003c3c018fc7f\nThu Mar 13 45552 10:10:00 GMT-0400 (EDT)\nJohn renner \u003c------------------------\u003e\nFixed silly naming conventions\n```\n\nModified aggregating version:\n\n```\nSHA 0000000046bca7d1f01d00d4607f0000d0c92101\nMon Jan 03 45538 18:06:40 GMT-0500 (EST)\nademoss \u003c------------------------\u003e\nInitial commit\n\nSHA 0000000046bca7d1f01d00d4607f0000d0c92101\nWed Jul 04 45551 06:20:00 GMT-0400 (EDT)\nAnthony De Moss \u003c------------------------\u003e\n- initial commit\n\nSHA 0000000046bca7d1f01d00d4607f0000d0c92101\nSat Mar 01 45552 11:03:20 GMT-0500 (EST)\nJohn renner \u003c------------------------\u003e\nInitial implementation\n\nSHA 48fcde000000000070cd21010000000020fcde00\nThu Mar 13 45552 10:10:00 GMT-0400 (EDT)\nJohn renner \u003c------------------------\u003e\nFixed silly naming conventions\n```\n\nThe original matches the `git log` perfectly. The same thing happens if I try to manually aggregate them instead of using the aggregate provided in `history().on('end')`.\n\nI'm guessing this issue is due to some variable being reused improperly when creating the commits/oid's.\n","author":{"url":"https://github.com/djrenren","@type":"Person","name":"djrenren"},"datePublished":"2013-08-02T20:04:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/81/nodegit/issues/81"}