René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Doesn't work with Electron","articleBody":"The installation instructions for Electron http://www.nodegit.org/guides/install/electron/ have us add to package.json:\n\n```\n  \"engines\": {\n    \"electron\": \"0.20.7\"\n  }\n```\n\nAnd run `npm install`, which in turn runs `lifecycleScripts/install.js`. However, that install script is still based off the old \"atom-shell\" and not Electron:\n\nhttps://github.com/nodegit/nodegit/blob/master/lifecycleScripts/install.js#L29\nhttps://github.com/nodegit/nodegit/blob/master/lifecycleScripts/install.js#L106-L107\n\n.. so when you run `npm install nodegit` with the package.json above it will build against the current Node version, not Electron. Unsurprisingly, Electron blows if you try to require `nodegit` in it.\n\nI've tried working around this by taking the instructions from Electron's docs (https://github.com/atom/electron/blob/master/docs/tutorial/using-native-node-modules.md) and patching `lifecycleScripts/install.js` accordingly, e.g.:\n\n``` diff\ndiff --git a/lifecycleScripts/install.js b/lifecycleScripts/install.js\nindex 65b8031..7550fe0 100644\n--- a/lifecycleScripts/install.js\n+++ b/lifecycleScripts/install.js\n@@ -18,7 +18,7 @@ var local = path.join.bind(path, __dirname);\n return whichNativeNodish(\"..\")\n   .then(function(results) {\n     nwVersion = results.nwVersion;\n-    asVersion = results.asVersion;\n+    asVersion = '0.26.0';\n   })\n   .then(function() {\n     if (nwVersion) {\n@@ -103,8 +103,7 @@ function build() {\n\n     target = \"--target=\" + asVersion;\n\n-    distUrl = \"--dist-url=https://gh-contractor-zcbenz.s3.\" +\n-      \"amazonaws.com/atom-shell/dist\";\n+    distUrl = \"--dist-url=https://atom.io/download/atom-shell\";\n   }\n   else if (nwVersion) {\n     builder = \"nw-gyp\";\n```\n\nHowever, the build fails:\n\n```\n$ node lifecycleScripts/install\n[nodegit] Must build for atom-shell\n[nodegit] Making sure dependencies are available and native code is generated\n[nodegit] Everything is ready to go, attempting compilation\n[nodegit] Building native node module.\n{ [Error: Command failed: /bin/sh -c HOME=~/.atom-shell-gyp /Users/aadib/temp/nodegit/node_modules/.bin/pangyp rebuild --target=0.26.0  --dist-url=https://atom.io/download/atom-shell\ngyp info it worked if it ends with ok\ngyp info using pangyp@2.2.0\ngyp info using node@2.0.2 | darwin | x64\ngyp info spawn python\ngyp info spawn args [ '/Users/aadib/temp/nodegit/node_modules/pangyp/gyp/gyp_main.py',\ngyp info spawn args   'binding.gyp',\ngyp info spawn args   '-f',\ngyp info spawn args   'make',\ngyp info spawn args   '-I',\ngyp info spawn args   '/Users/aadib/temp/nodegit/build/config.gypi',\ngyp info spawn args   '-I',\ngyp info spawn args   '/Users/aadib/temp/nodegit/node_modules/pangyp/addon.gypi',\ngyp info spawn args   '-I',\ngyp info spawn args   '/Users/aadib/.atom-shell-gyp/.node-gyp/0.26.0/common.gypi',\ngyp info spawn args   '-Dlibrary=shared_library',\ngyp info spawn args   '-Dvisibility=default',\ngyp info spawn args   '-Dnode_root_dir=/Users/aadib/.atom-shell-gyp/.node-gyp/0.26.0',\ngyp info spawn args   '-Druntime=iojs',\ngyp info spawn args   '-Dmodule_root_dir=/Users/aadib/temp/nodegit',\ngyp info spawn args   '--depth=.',\ngyp info spawn args   '--no-parallel',\ngyp info spawn args   '--generator-output',\ngyp info spawn args   'build',\ngyp info spawn args   '-Goutput_dir=.' ]\ngyp info spawn make\ngyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\n../vendor/libgit2/src/attr.c:10:1: warning: unused function 'kh_clear_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:74:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/attr.c:10:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:88:1: note: expanded from here\nkh_del_str\n^\n2 warnings generated.\n../vendor/libgit2/src/attrcache.c:8:1: warning: unused function 'kh_clear_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:74:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/attrcache.c:8:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:88:1: note: expanded from here\nkh_del_str\n^\n2 warnings generated.\n../vendor/libgit2/src/clone.c:479:20: warning: unused function 'repository_base' [-Wunused-function]\nstatic const char *repository_base(git_repository *repo)\n                   ^\n1 warning generated.\n../vendor/libgit2/src/config_file.c:24:1: warning: unused function 'kh_clear_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:74:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/config_file.c:24:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:88:1: note: expanded from here\nkh_del_str\n^\n2 warnings generated.\n../vendor/libgit2/src/diff_driver.c:20:1: warning: unused function 'kh_clear_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:74:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/diff_driver.c:20:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:88:1: note: expanded from here\nkh_del_str\n^\n2 warnings generated.\n../vendor/libgit2/src/mwindow.c:17:1: warning: unused function 'kh_clear_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:121:1: note: expanded from here\nkh_clear_str\n^\n1 warning generated.\n../vendor/libgit2/src/odb_mempack.c:21:1: warning: unused function 'kh_destroy_oid' [-Wunused-function]\nGIT__USE_OIDMAP;\n^\n../vendor/libgit2/src/oidmap.h:30:2: note: expanded from macro 'GIT__USE_OIDMAP'\n        __KHASH_IMPL(oid, static kh_inline, const git_oid *, void *, 1, git_oidmap_hash, git_oid_equal)\n        ^\n../vendor/libgit2/src/khash.h:198:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_destroy_##name(kh_##name##_t *h)                                          \\\n                   ^\n\u003cscratch space\u003e:67:1: note: expanded from here\nkh_destroy_oid\n^\n../vendor/libgit2/src/odb_mempack.c:21:1: warning: unused function 'kh_clear_oid' [-Wunused-function]\n../vendor/libgit2/src/oidmap.h:30:2: note: expanded from macro 'GIT__USE_OIDMAP'\n        __KHASH_IMPL(oid, static kh_inline, const git_oid *, void *, 1, git_oidmap_hash, git_oid_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:70:1: note: expanded from here\nkh_clear_oid\n^\n../vendor/libgit2/src/odb_mempack.c:21:1: warning: unused function 'kh_del_oid' [-Wunused-function]\n../vendor/libgit2/src/oidmap.h:30:2: note: expanded from macro 'GIT__USE_OIDMAP'\n        __KHASH_IMPL(oid, static kh_inline, const git_oid *, void *, 1, git_oidmap_hash, git_oid_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:84:1: note: expanded from here\nkh_del_oid\n^\n3 warnings generated.\n../vendor/libgit2/src/refdb_fs.c:29:1: warning: unused function 'kh_init_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:195:23: note: expanded from macro '__KHASH_IMPL'\n        SCOPE kh_##name##_t *kh_init_##name(void) {                                                     \\\n                             ^\n\u003cscratch space\u003e:124:1: note: expanded from here\nkh_init_str\n^\n../vendor/libgit2/src/refdb_fs.c:29:1: warning: unused function 'kh_destroy_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:198:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_destroy_##name(kh_##name##_t *h)                                          \\\n                   ^\n\u003cscratch space\u003e:129:1: note: expanded from here\nkh_destroy_str\n^\n../vendor/libgit2/src/refdb_fs.c:29:1: warning: unused function 'kh_clear_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:132:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/refdb_fs.c:29:1: warning: unused function 'kh_get_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:213:16: note: expanded from macro '__KHASH_IMPL'\n        SCOPE khint_t kh_get_##name(const kh_##name##_t *h, khkey_t key)        \\\n                      ^\n\u003cscratch space\u003e:135:1: note: expanded from here\nkh_get_str\n^\n../vendor/libgit2/src/refdb_fs.c:29:1: warning: unused function 'kh_put_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:291:16: note: expanded from macro '__KHASH_IMPL'\n        SCOPE khint_t kh_put_##name(kh_##name##_t *h, khkey_t key, int *ret) \\\n                      ^\n\u003cscratch space\u003e:141:1: note: expanded from here\nkh_put_str\n^\n../vendor/libgit2/src/refdb_fs.c:29:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:146:1: note: expanded from here\nkh_del_str\n^\n6 warnings generated.\n../vendor/libgit2/src/refs.c:27:1: warning: unused function 'kh_init_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:195:23: note: expanded from macro '__KHASH_IMPL'\n        SCOPE kh_##name##_t *kh_init_##name(void) {                                                     \\\n                             ^\n\u003cscratch space\u003e:124:1: note: expanded from here\nkh_init_str\n^\n../vendor/libgit2/src/refs.c:27:1: warning: unused function 'kh_destroy_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:198:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_destroy_##name(kh_##name##_t *h)                                          \\\n                   ^\n\u003cscratch space\u003e:129:1: note: expanded from here\nkh_destroy_str\n^\n../vendor/libgit2/src/refs.c:27:1: warning: unused function 'kh_clear_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:132:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/refs.c:27:1: warning: unused function 'kh_get_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:213:16: note: expanded from macro '__KHASH_IMPL'\n        SCOPE khint_t kh_get_##name(const kh_##name##_t *h, khkey_t key)        \\\n                      ^\n\u003cscratch space\u003e:135:1: note: expanded from here\nkh_get_str\n^\n../vendor/libgit2/src/refs.c:27:1: warning: unused function 'kh_put_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:291:16: note: expanded from macro '__KHASH_IMPL'\n        SCOPE khint_t kh_put_##name(kh_##name##_t *h, khkey_t key, int *ret) \\\n                      ^\n\u003cscratch space\u003e:141:1: note: expanded from here\nkh_put_str\n^\n../vendor/libgit2/src/refs.c:27:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:146:1: note: expanded from here\nkh_del_str\n^\n6 warnings generated.\n../vendor/libgit2/src/submodule.c:86:1: warning: unused function 'kh_clear_str' [-Wunused-function]\n__KHASH_IMPL(\n^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:74:1: note: expanded from here\nkh_clear_str\n^\n1 warning generated.\n../vendor/libgit2/src/transaction.c:20:1: warning: unused function 'kh_clear_str' [-Wunused-function]\nGIT__USE_STRMAP;\n^\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:206:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_clear_##name(kh_##name##_t *h)                                            \\\n                   ^\n\u003cscratch space\u003e:74:1: note: expanded from here\nkh_clear_str\n^\n../vendor/libgit2/src/transaction.c:20:1: warning: unused function 'kh_del_str' [-Wunused-function]\n../vendor/libgit2/src/strmap.h:23:2: note: expanded from macro 'GIT__USE_STRMAP'\n        __KHASH_IMPL(str, static kh_inline, const char *, void *, 1, kh_str_hash_func, kh_str_hash_equal)\n        ^\n../vendor/libgit2/src/khash.h:333:13: note: expanded from macro '__KHASH_IMPL'\n        SCOPE void kh_del_##name(kh_##name##_t *h, khint_t x)                           \\\n                   ^\n\u003cscratch space\u003e:88:1: note: expanded from here\nkh_del_str\n^\n2 warnings generated.\n../vendor/libssh2/src/misc.c:214:19: warning: unused variable 'base64_table' [-Wunused-const-variable]\nstatic const char base64_table[] =\n                  ^\n../vendor/libssh2/src/misc.c:223:19: warning: unused variable 'base64_pad' [-Wunused-const-variable]\nstatic const char base64_pad = '=';\n                  ^\n2 warnings generated.\n../vendor/openssl/openssl/ssl/d1_srtp.c:147:7: warning: missing field 'id' initializer [-Wmissing-field-initializers]\n    {0}\n      ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/asn1/x_bignum.c:85:1: warning: missing field 'prim_print' initializer [-Wmissing-field-initializers]\n};\n^\n1 warning generated.\n../vendor/openssl/openssl/crypto/cmac/cm_ameth.c:96:2: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/dh/dh_ameth.c:500:2: warning: missing field 'old_priv_decode' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/dsa/dsa_ameth.c:650:3: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]\n                },\n                ^\n../vendor/openssl/openssl/crypto/dsa/dsa_ameth.c:656:3: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]\n                },\n                ^\n../vendor/openssl/openssl/crypto/dsa/dsa_ameth.c:662:3: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]\n                },\n                ^\n../vendor/openssl/openssl/crypto/dsa/dsa_ameth.c:668:3: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]\n                },\n                ^\n../vendor/openssl/openssl/crypto/dsa/dsa_ameth.c:702:3: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]\n                }\n                ^\n5 warnings generated.\n../vendor/openssl/openssl/crypto/ec/ec_ameth.c:660:2: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/ec/ec_lib.c:71:19: warning: unused variable 'EC_version' [-Wunused-const-variable]\nstatic const char EC_version[] = \"EC\" OPENSSL_VERSION_PTEXT;\n                  ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/engine/eng_dyn.c:117:30: warning: unused variable 'dynamic_cmd_defns_empty' [-Wunused-const-variable]\nstatic const ENGINE_CMD_DEFN dynamic_cmd_defns_empty[] = {\n                             ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/engine/eng_openssl.c:344:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_dss.c:94:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_dss1.c:96:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_ecdsa.c:144:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_md4.c:97:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_md5.c:96:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_mdc2.c:97:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_null.c:88:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_ripemd.c:96:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_sha.c:95:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/evp/m_sha1.c:97:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n../vendor/openssl/openssl/crypto/evp/m_sha1.c:134:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n../vendor/openssl/openssl/crypto/evp/m_sha1.c:153:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n../vendor/openssl/openssl/crypto/evp/m_sha1.c:184:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n../vendor/openssl/openssl/crypto/evp/m_sha1.c:203:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n5 warnings generated.\n../vendor/openssl/openssl/crypto/evp/m_wp.c:37:2: warning: missing field 'md_ctrl' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/hmac/hm_ameth.c:166:2: warning: missing field 'item_verify' initializer [-Wmissing-field-initializers]\n        };\n        ^\n1 warning generated.\n../vendor/openssl/openssl/crypto/pem/pem_lib.c:473:6: warning: variable 'i' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]\n        if (o)\n            ^\n../vendor/openssl/openssl/crypto/pem/pem_lib.c:480:5: note: uninitialized use occurs here\n        j+=i;\n           ^\n../vendor/openssl/openssl/crypto/pem/pem_lib.c:473:2: note: remove the 'if' if its condition is always true\n        if (o)\n        ^~~~~~\n../vendor/openssl/openssl/crypto/pem/pem_lib.c:443:7: note: initialize the variable 'i' to silence this warning\n        int i,j,o,klen;\n             ^\n              = 0\n1 warning generated.\n../vendor/openssl/openssl/crypto/rsa/rsa_ameth.c:697:3: warning: missing field 'pem_str' initializer [-Wmissing-field-initializers]\n                }\n                ^\n1 warning generated.\nIn file included from ../src/nodegit.cc:6:\nIn file included from ../src/../include/wrapper.h:11:\nIn file included from ../node_modules/nan/nan.h:80:\nIn file included from ../node_modules/nan/nan_new.h:190:\n../node_modules/nan/nan_implementation_12_inl.h:181:66: error: too many arguments to function call, expected at most 2, have 4\n  return v8::Signature::New(v8::Isolate::GetCurrent(), receiver, argc, argv);\n         ~~~~~~~~~~~~~~~~~~                                      ^~~~~~~~~~\n/Users/aadib/.atom-shell-gyp/.node-gyp/0.26.0/deps/v8/include/v8.h:4170:3: note: 'New' declared here\n  static Local\u003cSignature\u003e New(\n  ^\n1 error generated.\nmake: *** [Release/obj.target/nodegit/src/nodegit.o] Error 1\ngyp ERR! build error \ngyp ERR! stack Error: `make` failed with exit code: 2\ngyp ERR! stack     at ChildProcess.onExit (/Users/aadib/temp/nodegit/node_modules/pangyp/lib/build.js:271:23)\ngyp ERR! stack     at emitTwo (events.js:87:13)\ngyp ERR! stack     at ChildProcess.emit (events.js:172:7)\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1009:12)\ngyp ERR! System Darwin 14.3.0\ngyp ERR! command \"/Users/aadib/.nvm/versions/io.js/v2.0.2/bin/iojs\" \"/Users/aadib/temp/nodegit/node_modules/.bin/pangyp\" \"rebuild\" \"--target=0.26.0\" \"--dist-url=https://atom.io/download/atom-shell\"\ngyp ERR! cwd /Users/aadib/temp/nodegit\ngyp ERR! node -v v2.0.2\ngyp ERR! pangyp -v v2.2.0\ngyp ERR! not ok \n]\n  killed: false,\n  code: 1,\n  signal: null,\n  cmd: '/bin/sh -c HOME=~/.atom-shell-gyp /Users/aadib/temp/nodegit/node_modules/.bin/pangyp rebuild --target=0.26.0  --dist-url=https://atom.io/download/atom-shell' }\nundefined\n```\n","author":{"url":"https://github.com/arturadib","@type":"Person","name":"arturadib"},"datePublished":"2015-05-17T01:51:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":15},"url":"https://github.com/574/nodegit/issues/574"}