Title: Potential example issue in add-and-commit.js L45-48 · Issue #409 · nodegit/nodegit · GitHub
Open Graph Title: Potential example issue in add-and-commit.js L45-48 · Issue #409 · nodegit/nodegit
X Title: Potential example issue in add-and-commit.js L45-48 · Issue #409 · nodegit/nodegit
Description: At line 45 of https://github.com/nodegit/nodegit/blob/master/examples/add-and-commit.js#L45 the sample calls return index.addByPath(fileName); line 48 then calls the same method but with the directory name as well: return index.addByPath...
Open Graph Description: At line 45 of https://github.com/nodegit/nodegit/blob/master/examples/add-and-commit.js#L45 the sample calls return index.addByPath(fileName); line 48 then calls the same method but with the direct...
X Description: At line 45 of https://github.com/nodegit/nodegit/blob/master/examples/add-and-commit.js#L45 the sample calls return index.addByPath(fileName); line 48 then calls the same method but with the direct...
Opengraph URL: https://github.com/nodegit/nodegit/issues/409
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Potential example issue in add-and-commit.js L45-48","articleBody":"At line 45 of https://github.com/nodegit/nodegit/blob/master/examples/add-and-commit.js#L45 the sample calls `return index.addByPath(fileName)`; line 48 then calls the same method but with the directory name as well: `return index.addByPath(path.join(directoryName, fileName));`\n\nShould l45 be removed? They feel redundant, and in the case that you're working with a subdirectory and similarly named files (like index.html), it's possible that this code could actually add two different fles to the index...\n","author":{"url":"https://github.com/jeffwilcox","@type":"Person","name":"jeffwilcox"},"datePublished":"2015-02-16T21:46:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/409/nodegit/issues/409"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d4a3e4c0-58ed-6168-3704-2fb52efe3d40 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B388:1712DC:35410F2:4531F51:6A5CE6E2 |
| html-safe-nonce | 212ce5ec1398c9791ad2e51af473e3e213a742b31de086e9b1afa05a59e767a0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzg4OjE3MTJEQzozNTQxMEYyOjQ1MzFGNTE6NkE1Q0U2RTIiLCJ2aXNpdG9yX2lkIjoiMzMzNDk1NDEwMzI0ODU3ODI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dfbb99a76e463090f2e70da3ebe42b04ff71211a750f034aeba494a18d14967a |
| hovercard-subject-tag | issue:57854869 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/409/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5637f07a2c286ccce6944f267f3e682bf217f053ba6f292f15221028810447d9/nodegit/nodegit/issues/409 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5637f07a2c286ccce6944f267f3e682bf217f053ba6f292f15221028810447d9/nodegit/nodegit/issues/409 |
| og:image:alt | At line 45 of https://github.com/nodegit/nodegit/blob/master/examples/add-and-commit.js#L45 the sample calls return index.addByPath(fileName); line 48 then calls the same method but with the direct... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jeffwilcox |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width