Title: Can't build for node-webkit · Issue #335 · nodegit/nodegit · GitHub
Open Graph Title: Can't build for node-webkit · Issue #335 · nodegit/nodegit
X Title: Can't build for node-webkit · Issue #335 · nodegit/nodegit
Description: Using version 0.2.4 I am unable to build nodegit for node-webkit. I have the node-webkit engine defined in a package.json file located a couple directories above where nodegit sits and it appears that the detectNodeWebkit function (in in...
Open Graph Description: Using version 0.2.4 I am unable to build nodegit for node-webkit. I have the node-webkit engine defined in a package.json file located a couple directories above where nodegit sits and it appears t...
X Description: Using version 0.2.4 I am unable to build nodegit for node-webkit. I have the node-webkit engine defined in a package.json file located a couple directories above where nodegit sits and it appears t...
Opengraph URL: https://github.com/nodegit/nodegit/issues/335
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Can't build for node-webkit","articleBody":"Using version 0.2.4 I am unable to build nodegit for node-webkit. \n\nI have the node-webkit engine defined in a package.json file located a couple directories above where nodegit sits and it appears that the detectNodeWebkit function (in install.js) doesn't finish recursively searching directories before the \"fetch\" function is called. It gets called once and then \"fetch\" fires.\n\nOnce I found that issue I tried to just hardcode the nodeWebkit flag in install.js to true. Once I did this i get an error when running npm install. Here is the stack trace.\n\nCommand failed: \nmodule.js:340\n throw err;\n ^\nError: Cannot find module '/Users/adamchrist/Documents/Projects/Macaw/Code/scarlet/src/node_modules/nodegit/generate'\n at Function.Module._resolveFilename (module.js:338:15)\n at Function.Module._load (module.js:280:25)\n at Function.Module.runMain (module.js:497:10)\n at startup (node.js:119:16)\n at node.js:906:3\n\nAnd one final note. It looks like the nodeWebkit flag is a boolean value only:\n\nline 229 of install.js\nnodeWebkit = pkg.engines \u0026\u0026 pkg.engines[\"node-webkit\"];\n\nBut later in the \"buildNative\" function it is being used as the \"--target\" argument for nw-gyp which expects a version number.\n","author":{"url":"https://github.com/achrist","@type":"Person","name":"achrist"},"datePublished":"2015-01-06T20:24:26.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/335/nodegit/issues/335"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b492d16d-f908-b498-e6ac-c7c24902d374 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D224:2AF233:4834448:630469C:6A5E1ACC |
| html-safe-nonce | 27619e90304aec5ecd262f0ab34b8237569e5c77fd2a929071dda4c4e1071f80 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjI0OjJBRjIzMzo0ODM0NDQ4OjYzMDQ2OUM6NkE1RTFBQ0MiLCJ2aXNpdG9yX2lkIjoiMTg1MzE4NTA5OTAyMzkxNTcyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1c3b7f916c85193722d425d3d3a280d094108a39b370d0c45a9327681c562005 |
| hovercard-subject-tag | issue:53558726 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/335/issue_layout |
| twitter:image | https://opengraph.githubassets.com/61adaa854626098f5766c20fa8a769d7c9717861fbcb453de86857c1eeed5639/nodegit/nodegit/issues/335 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61adaa854626098f5766c20fa8a769d7c9717861fbcb453de86857c1eeed5639/nodegit/nodegit/issues/335 |
| og:image:alt | Using version 0.2.4 I am unable to build nodegit for node-webkit. I have the node-webkit engine defined in a package.json file located a couple directories above where nodegit sits and it appears t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | achrist |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7a60e060dad2c24f72179d36247204b454da37845d1728020cd42046a433f87f |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0ae7f3ea7b1bb2f1f4623bb093bbf54cee05d830 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width