Title: repo.getReferenceNames( nodegit.Reference.TYPE.DIRECT ) does not work. · Issue #1935 · nodegit/nodegit · GitHub
Open Graph Title: repo.getReferenceNames( nodegit.Reference.TYPE.DIRECT ) does not work. · Issue #1935 · nodegit/nodegit
X Title: repo.getReferenceNames( nodegit.Reference.TYPE.DIRECT ) does not work. · Issue #1935 · nodegit/nodegit
Description: System information node version: v16.14.2 npm or yarn version: 8.5.0 OS/version/architecture: debian Applicable nodegit version: 0.27.0 (or HEAD) Issue const refNames = await repo.getReferenceNames( nodegit.Reference.TYPE.DIRECT ); will ...
Open Graph Description: System information node version: v16.14.2 npm or yarn version: 8.5.0 OS/version/architecture: debian Applicable nodegit version: 0.27.0 (or HEAD) Issue const refNames = await repo.getReferenceNames...
X Description: System information node version: v16.14.2 npm or yarn version: 8.5.0 OS/version/architecture: debian Applicable nodegit version: 0.27.0 (or HEAD) Issue const refNames = await repo.getReferenceNames...
Opengraph URL: https://github.com/nodegit/nodegit/issues/1935
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"repo.getReferenceNames( nodegit.Reference.TYPE.DIRECT ) does not work.","articleBody":"## System information\r\n - node version: v16.14.2\r\n - npm or yarn version: 8.5.0\r\n - OS/version/architecture: debian\r\n - Applicable nodegit version: 0.27.0 (or HEAD)\r\n\r\n## Issue\r\nconst refNames = await repo.getReferenceNames( nodegit.Reference.TYPE.DIRECT );\r\n\r\nwill return an empty array. TYPE.ALL will work.\r\n\r\n## Solution:\r\nhttps://github.com/nodegit/nodegit/blob/master/lib/repository.js#L343\r\n\r\nis missing a call.\r\n\r\nit should be:\r\n```\r\n return type === Reference.TYPE.ALL || reference.type( ) === type;\r\n```\r\ninstead of\r\n```\r\n return type === Reference.TYPE.ALL || reference.type === type;\r\n```","author":{"url":"https://github.com/axkibe","@type":"Person","name":"axkibe"},"datePublished":"2022-09-20T12:50:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1935/nodegit/issues/1935"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9c68312d-1f0b-5e33-3a20-3eac31b04b1d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DA94:3DC7AA:346A019:46BE655:69706D81 |
| html-safe-nonce | 31c9a82b106628085a996b7878cb5ebb8d2bf0a32bbb20b40251739889338c48 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTk0OjNEQzdBQTozNDZBMDE5OjQ2QkU2NTU6Njk3MDZEODEiLCJ2aXNpdG9yX2lkIjoiMzUxNDY1NTcxNTI4NjM0NzEzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c9b43ed1e335faa2c0e8b36255e7c1e5719d1b8467b4d4061f153ebcaff7dc71 |
| hovercard-subject-tag | issue:1379370917 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/1935/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1eeac9b4cc5cce3aa87572d8167bc601ea1055a74d71a188b9001d40c21fd649/nodegit/nodegit/issues/1935 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1eeac9b4cc5cce3aa87572d8167bc601ea1055a74d71a188b9001d40c21fd649/nodegit/nodegit/issues/1935 |
| og:image:alt | System information node version: v16.14.2 npm or yarn version: 8.5.0 OS/version/architecture: debian Applicable nodegit version: 0.27.0 (or HEAD) Issue const refNames = await repo.getReferenceNames... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | axkibe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width