Title: [refactor] use async/await syntax? · Issue #1867 · nodegit/nodegit · GitHub
Open Graph Title: [refactor] use async/await syntax? · Issue #1867 · nodegit/nodegit
X Title: [refactor] use async/await syntax? · Issue #1867 · nodegit/nodegit
Description: As I dig through the source, I'm noticing that there's a lot of messy manual Promise chaining, eg. https://github.com/nodegit/nodegit/blob/master/generate/scripts/generateNativeCode.js#L121-L171. Is there a reason not to use async/await ...
Open Graph Description: As I dig through the source, I'm noticing that there's a lot of messy manual Promise chaining, eg. https://github.com/nodegit/nodegit/blob/master/generate/scripts/generateNativeCode.js#L121-L171. I...
X Description: As I dig through the source, I'm noticing that there's a lot of messy manual Promise chaining, eg. https://github.com/nodegit/nodegit/blob/master/generate/scripts/generateNativeCode.js#L121...
Opengraph URL: https://github.com/nodegit/nodegit/issues/1867
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[refactor] use async/await syntax?","articleBody":"As I dig through the source, I'm noticing that there's a lot of messy manual Promise chaining, eg. https://github.com/nodegit/nodegit/blob/master/generate/scripts/generateNativeCode.js#L121-L171. Is there a reason not to use async/await syntax? I'd be happy to submit some PRs if maintainers would be interested.","author":{"url":"https://github.com/samuela","@type":"Person","name":"samuela"},"datePublished":"2021-10-17T03:05:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/1867/nodegit/issues/1867"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:52344b34-c54b-1efd-dc43-833511033e56 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9F0C:32E262:2736DB3:34C7365:69706DD1 |
| html-safe-nonce | 3386459565210e2f2fc72cc55bf37957b17321b449f0899b690e342364854707 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjBDOjMyRTI2MjoyNzM2REIzOjM0QzczNjU6Njk3MDZERDEiLCJ2aXNpdG9yX2lkIjoiNTYyNjcwNzEyODYzNDg2MzA1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1c907d7144e082cce5866d6800863b76a1ca084f9c63bc0aeb937357c3d7d166 |
| hovercard-subject-tag | issue:1028201532 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/1867/issue_layout |
| twitter:image | https://opengraph.githubassets.com/83ed70a813d9daf2e186c829d9b7bcc7fa00270659021c876e3f206cb6ab761e/nodegit/nodegit/issues/1867 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/83ed70a813d9daf2e186c829d9b7bcc7fa00270659021c876e3f206cb6ab761e/nodegit/nodegit/issues/1867 |
| og:image:alt | As I dig through the source, I'm noticing that there's a lot of messy manual Promise chaining, eg. https://github.com/nodegit/nodegit/blob/master/generate/scripts/generateNativeCode.js#L121-L171. I... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | samuela |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width