René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Diff Memory leaks - Expose git_diff_free","articleBody":"I'm running a script that check a repo for `Diff.indexToWorkdir` every interval, like so:\r\n```js\r\n   // runs in interval every 1s\r\n    .then(() =\u003e {\r\n        return git.Repository.open('../my_repo_path');\r\n    })\r\n    .then( (repo) =\u003e {\r\n      return git.Diff.indexToWorkdir(repo);\r\n    })\r\n    .then((repoDiff) =\u003e {\r\n        return repoDiff.toBuf(git.Diff.FORMAT.PATCH);\r\n    })\r\n```\r\nThis generates a memory leak.\r\n\r\nI know the repository needs to be freed using `repo.free()`: (or `repo.cleanup()`)\r\nhttps://www.nodegit.org/api/repository/#free\r\n\r\nAccording to the docs:\r\nhttps://libgit2.org/libgit2/#HEAD/group/repository/git_repository_free\r\n\r\n\u003e Note that after a repository is free'd, all the objects it has spawned **will still exist until they are manually closed by the user with git_object_free**, but accessing any of the attributes of an object without a backing repository will result in undefined behavior\r\n\r\nWhich means I also need to free up the Diff object;\r\nApparently there's a way to free a diff using `git_diff_free`\r\nhttps://libgit2.org/libgit2/#HEAD/group/diff/git_diff_free\r\n\r\nBut from what I understand nodegit doesn't expose this function, see:\r\nhttps://github.com/nodegit/nodegit/blob/c944ec6ae5c8fffbac8db7b1f0180ae1254560f2/generate/input/descriptor.json#L933-L935\r\n\r\n**EDIT**\r\nIt seems like I also need to free up the `Buf` I'm creating using `repoDiff.toBuf(git.Diff.FORMAT.PATCH);`\r\nhttps://www.nodegit.org/api/buf/#free\r\nhttps://libgit2.org/libgit2/#HEAD/group/buf/git_buf_free\r\n\r\nBut I didn't find a way to do this since `repoDiff.toBuf` return a Promise which returns a string.\r\nIt seems the `Buf` is only available in the C++ implementation. (see NAN_METHOD(GitDiff::ToBuf) )\r\n\r\nIs there another way to do this?\r\nThanks\r\n\r\nBTW, I'm guessing this also relates to: https://github.com/nodegit/nodegit/issues/766","author":{"url":"https://github.com/yelled3","@type":"Person","name":"yelled3"},"datePublished":"2018-08-21T13:44:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/1541/nodegit/issues/1541"}