Title: Failed to compile on Node 10.0.0 · Issue #1490 · nodegit/nodegit · GitHub
Open Graph Title: Failed to compile on Node 10.0.0 · Issue #1490 · nodegit/nodegit
X Title: Failed to compile on Node 10.0.0 · Issue #1490 · nodegit/nodegit
Description: nodegit fails to compile on Node 10.0.0 and NPM 5.6.0. Here's a way to reproduce the issue: cd ~ mkdir test_repo cd test_repo npm init npm i --save nodegit Here are my logs: https://gist.github.com/sadasant/4fce501d8cffda53bc8fb53f4950ea...
Open Graph Description: nodegit fails to compile on Node 10.0.0 and NPM 5.6.0. Here's a way to reproduce the issue: cd ~ mkdir test_repo cd test_repo npm init npm i --save nodegit Here are my logs: https://gist.github.com...
X Description: nodegit fails to compile on Node 10.0.0 and NPM 5.6.0. Here's a way to reproduce the issue: cd ~ mkdir test_repo cd test_repo npm init npm i --save nodegit Here are my logs: https://gist.github...
Opengraph URL: https://github.com/nodegit/nodegit/issues/1490
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Failed to compile on Node 10.0.0","articleBody":"nodegit fails to compile on Node 10.0.0 and NPM 5.6.0. Here's a way to reproduce the issue:\r\n\r\n```\r\ncd ~\r\nmkdir test_repo\r\ncd test_repo\r\nnpm init\r\nnpm i --save nodegit\r\n```\r\n\r\nHere are my logs:\r\n\r\nhttps://gist.github.com/sadasant/4fce501d8cffda53bc8fb53f4950eaa3\r\n\r\n**Also happens with NPM 6.0.0:**\r\n\r\nhttps://gist.github.com/sadasant/cf598e5d232be909e426135a3de87847\r\n\r\n---\r\n\r\n### May 1 update\r\n\r\nEven though nodegit's issue is deeper that what I'm about to mention, the following issue is the first breaking point for building nodegit on Node 10:\r\n\r\nThere was a recent change on Node 10's Function's toString method. Here's an issue that I created: https://github.com/nodejs/node/issues/20459\r\n\r\nThis change in Node 10 causes promisify-node to break, here's the relevant issue: https://github.com/nodegit/promisify-node/issues/28\r\n\r\n---\r\n\r\n### May 2 update\r\n\r\nThe exception happens when we try to run `node node_modules/.bin/node-pre-gyp install --build-from-source`. The issue seems to be that libssh2 is expected to be built using openssl-0.9.8: https://github.com/libssh2/libssh2/search?utf8=%E2%9C%93\u0026q=openssl-0.9.8\u0026type= However, node 10 moved openssl forward to 1.1.0: https://github.com/nodejs/node/search?utf8=%E2%9C%93\u0026q=OpenSSL+has+been+updated+to+1.1.0h.\u0026type=\r\n\r\nHere are my logs: https://gist.github.com/sadasant/031d3f8bf1c4e5d2ac83b3841b7807fc","author":{"url":"https://github.com/sadasant","@type":"Person","name":"sadasant"},"datePublished":"2018-04-30T21:21:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":29},"url":"https://github.com/1490/nodegit/issues/1490"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f97fbd12-82c2-2999-7d0f-a50853ae9e70 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8AB8:178E2:20F0DBA:2C8E5B9:6970861A |
| html-safe-nonce | f9952aca499b0c15cf085ba768c13be6aa0ca3ec024af823689552e641100469 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUI4OjE3OEUyOjIwRjBEQkE6MkM4RTVCOTo2OTcwODYxQSIsInZpc2l0b3JfaWQiOiI1NDAxMzY5NzQxMDA5OTEzMzcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 499b22ce54e37406d58cdb385fd17158ec2f374b9d97e4a9f7c530ddb059227b |
| hovercard-subject-tag | issue:319040360 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/1490/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c81698180f800638ccccbff2a7f80bc90587b073f25e27fa699c9e517c5a673f/nodegit/nodegit/issues/1490 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c81698180f800638ccccbff2a7f80bc90587b073f25e27fa699c9e517c5a673f/nodegit/nodegit/issues/1490 |
| og:image:alt | nodegit fails to compile on Node 10.0.0 and NPM 5.6.0. Here's a way to reproduce the issue: cd ~ mkdir test_repo cd test_repo npm init npm i --save nodegit Here are my logs: https://gist.github.com... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sadasant |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width