René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NodeGit does not expose a proper API for displaying large binary diffs","articleBody":"The diff process in libgit2 automatically assumes that files over ~536MB are binary files. This causes the diff process to assign a `GIT_DIFF_FLAG_BINARY` to the file ([see here](https://github.com/libgit2/libgit2/blob/master/src/diff_file.c#L23)). When the `GIT_DIFF_FLAG_BINARY` flag is set on a file it will eventually set that flag on the delta too causing the diff process to avoid generating hunks for the patches on the diff. Instead, it generates a [binary](https://github.com/libgit2/libgit2/blob/master/src/patch_generate.c#L256) object on any patch (I assume there is only one at this point, I have not seen otherwise).\r\n\r\nThe binary object is not exposed properly via the `ConvenientPatch` object in NodeGit. It should be so we can then expose the content of the binary object. Normally, this would probably not be an issue, but if we filter the binary content--say with Git LFS--we cannot see any diff output for files over the max file size threshold. \r\n\r\n[Here is where the binary object will be generated instead of hunks](https://github.com/libgit2/libgit2/blob/master/src/patch_generate.c#L383) as any delta with the `GIT_DIFF_FLAG_BINARY` flag calls the binary callback instead of the diff callback and never emits the diff.\r\n\r\nAnother potential issue is [deflating](https://github.com/libgit2/libgit2/blob/master/src/patch_generate.c#L274) the filtered content on the binary object. It appears that libgit2 deflates the content regardless of what it is, so this could mean that even if we expose the binary object we won't be able to actually see the filtered content. This may not be an issue, I guess we will need to see that the final content of the binary object is after it has been exposed.\r\n\r\n@implausible, if you could look into this that would be amazing. If not I will look into it in a couple weeks.","author":{"url":"https://github.com/cjhoward92","@type":"Person","name":"cjhoward92"},"datePublished":"2017-09-07T22:58:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1369/nodegit/issues/1369"}