Title: Tighter type checking on passed in nodegit methods · Issue #1127 · nodegit/nodegit · GitHub
Open Graph Title: Tighter type checking on passed in nodegit methods · Issue #1127 · nodegit/nodegit
X Title: Tighter type checking on passed in nodegit methods · Issue #1127 · nodegit/nodegit
Description: As seen here: #1120 Generated code is as such NAN_METHOD(GitTag::List) { if (info.Length() == 0 || !info[0]->IsObject()) { return Nan::ThrowError("Repository repo is required."); } Where info[0] is meant to be a GitRepo object. Templates...
Open Graph Description: As seen here: #1120 Generated code is as such NAN_METHOD(GitTag::List) { if (info.Length() == 0 || !info[0]->IsObject()) { return Nan::ThrowError("Repository repo is required."); } Where info[0] is...
X Description: As seen here: #1120 Generated code is as such NAN_METHOD(GitTag::List) { if (info.Length() == 0 || !info[0]->IsObject()) { return Nan::ThrowError("Repository repo is required."); } Whe...
Opengraph URL: https://github.com/nodegit/nodegit/issues/1127
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tighter type checking on passed in nodegit methods ","articleBody":"As seen here: https://github.com/nodegit/nodegit/issues/1120\n\nGenerated code is as such\n\n```\nNAN_METHOD(GitTag::List)\n{\n\n if (info.Length() == 0 || !info[0]-\u003eIsObject()) {\n return Nan::ThrowError(\"Repository repo is required.\");\n }\n```\n\nWhere info[0] is meant to be a GitRepo object. Templates need to be fixed up to support this. \n","author":{"url":"https://github.com/maxkorp","@type":"Person","name":"maxkorp"},"datePublished":"2016-09-15T18:08:19.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/1127/nodegit/issues/1127"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9d902216-e950-4fa2-cd45-a1098002d75a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B0C2:3A432B:3FAB728:5995FB4:6A5FAA02 |
| html-safe-nonce | 57e773f4cd74d9c3c2bca0aea7343b74f4b1e2c1782432e6ab992272c1a58006 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEMyOjNBNDMyQjozRkFCNzI4OjU5OTVGQjQ6NkE1RkFBMDIiLCJ2aXNpdG9yX2lkIjoiOTA2NTg1OTQ2MzQ2OTkwMDgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 53fc3c2a6501cc752205d8c3d403772051b78c85982734cc56b4228060fcad36 |
| hovercard-subject-tag | issue:177247523 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/1127/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9fe3993e45abd1caf3d061981800d4f4e961f8ef3eb64dee3f5d7ef23d4025d9/nodegit/nodegit/issues/1127 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9fe3993e45abd1caf3d061981800d4f4e961f8ef3eb64dee3f5d7ef23d4025d9/nodegit/nodegit/issues/1127 |
| og:image:alt | As seen here: #1120 Generated code is as such NAN_METHOD(GitTag::List) { if (info.Length() == 0 || !info[0]->IsObject()) { return Nan::ThrowError("Repository repo is required."); } Where info[0] is... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maxkorp |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b835c054d57dfb6ce72ba8f0eb8f16f0370860631609eb10df818738c61c68d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4df9bc0bde4bfd7cd95e75afdd7f103984ece3a1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width