René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fileHistoryWalk does not return all commits","articleBody":"When I compare the history returned by fileHistoryWalk to git log console output, there are a lot of commits missing from the fileHistoryWalk commits.\n\nFor example, using the atom editor repo and source:\n\n``` bash\ncd /tmp\ngit clone https://github.com/atom/atom.git\ncd atom\ngit log src/text-editor.coffee\n```\n\n...then, using a slightly modified examples/walk-history-for-file.js (see below) and compare.  The output from the example says there are 129 commits to text-editor.coffee but git log src/text-editor.coffee shows 481 commits to that file.\n\nmodified example (changed repo, test tile path and added count output:\n\n``` javascript\nvar nodegit = require(\"../\"),\n    path = require(\"path\"),\n    historyFile = \"src/text-editor.coffee\",\n    walker,\n    historyCommits = [],\n    commit,\n    repo;\n\n// This code walks the history of the master branch and prints results\n// that look very similar to calling `git log` from the command line\n\nfunction compileHistory(resultingArrayOfCommits) {\n  var lastSha;\n  if (historyCommits.length \u003e 0) {\n    lastSha = historyCommits[historyCommits.length - 1].commit.sha();\n    if (\n      resultingArrayOfCommits.length == 1 \u0026\u0026\n      resultingArrayOfCommits[0].commit.sha() == lastSha\n    ) {\n      return;\n    }\n  }\n\n  resultingArrayOfCommits.forEach(function(entry) {\n    historyCommits.push(entry);\n  });\n\n  lastSha = historyCommits[historyCommits.length - 1].commit.sha();\n\n  walker = repo.createRevWalk();\n  walker.push(lastSha);\n  walker.sorting(nodegit.Revwalk.SORT.TIME);\n\n  return walker.fileHistoryWalk(historyFile, 500)\n    .then(compileHistory);\n}\n\n//nodegit.Repository.open(path.resolve(__dirname, \"../.git\"))\nnodegit.Repository.open(\"/tmp/atom/.git\")\n  .then(function(r) {\n    repo = r;\n    return repo.getMasterCommit();\n  })\n  .then(function(firstCommitOnMaster){\n    // History returns an event.\n    walker = repo.createRevWalk();\n    walker.push(firstCommitOnMaster.sha());\n    walker.sorting(nodegit.Revwalk.SORT.Time);\n\n    return walker.fileHistoryWalk(historyFile, 500);\n  })\n  .then(compileHistory)\n  .then(function() {\n    historyCommits.forEach(function(entry) {\n      commit = entry.commit;\n      console.log(\"commit \" + commit.sha());\n      console.log(\"Author:\", commit.author().name() +\n        \" \u003c\" + commit.author().email() + \"\u003e\");\n      console.log(\"Date:\", commit.date());\n      console.log(\"\\n    \" + commit.message());\n    });\n    console.log(\"\\n\\n\" + historyCommits.length + \" total commits\");\n  })\n  .done();\n\n```\n","author":{"url":"https://github.com/littlebee","@type":"Person","name":"littlebee"},"datePublished":"2016-07-11T01:19:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":15},"url":"https://github.com/1068/nodegit/issues/1068"}