René's URL Explorer Experiment


Title: Fix segfault when reading reflog with extra newlines by srajko · Pull Request #2 · nodegit/libgit2 · GitHub

Open Graph Title: Fix segfault when reading reflog with extra newlines by srajko · Pull Request #2 · nodegit/libgit2

X Title: Fix segfault when reading reflog with extra newlines by srajko · Pull Request #2 · nodegit/libgit2

Description: This addresses the issue mentioned in libgit2#3458 where git_reflog_read segfaults when reading a reflog that has a newline in the middle of a reflog message. It is a subset of libgit2#3463, limited to fixing the segfault. I'm posting this as a separate NodeGit PR in case we want to avoid the segfault until the full libgit2#3463 gets merged. Rebased on top of https://github.com/libgit2/libgit2/tree/maint/v0.23 as per #1.

Open Graph Description: This addresses the issue mentioned in libgit2#3458 where git_reflog_read segfaults when reading a reflog that has a newline in the middle of a reflog message. It is a subset of libgit2#3463, limite...

X Description: This addresses the issue mentioned in libgit2#3458 where git_reflog_read segfaults when reading a reflog that has a newline in the middle of a reflog message. It is a subset of libgit2#3463, limite...

Opengraph URL: https://github.com/nodegit/libgit2/pull/2

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eef8e31e-b357-d8f1-087f-0bf6821d22c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC76:7F9F4:222E03:2E5817:6A60FE3D
html-safe-nonceb6f5976ca5b8d35c9576020544591db9f1e094e09aebb1556dbc3e047e06734a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzc2OjdGOUY0OjIyMkUwMzoyRTU4MTc6NkE2MEZFM0QiLCJ2aXNpdG9yX2lkIjoiMzQ3MTkxNTI3NTk2ODkwNDc2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfc6e70f6310aaffb09a693a62070a8784f6c8f4d57b972603bc6afc00dae268c
hovercard-subject-tagpull_request:48115677
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodegit/libgit2/pull/2/files
twitter:imagehttps://avatars.githubusercontent.com/u/291007?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/291007?s=400&v=4
og:image:altThis addresses the issue mentioned in libgit2#3458 where git_reflog_read segfaults when reading a reflog that has a newline in the middle of a reflog message. It is a subset of libgit2#3463, limite...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9029e642b81338577ec563d0cede79b18d6f1471b9ecdd8e364313b9cc67dd06
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodegit/libgit2 git https://github.com/nodegit/libgit2.git
octolytics-dimension-user_id657068
octolytics-dimension-user_loginnodegit
octolytics-dimension-repository_id30660191
octolytics-dimension-repository_nwonodegit/libgit2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id901662
octolytics-dimension-repository_parent_nwolibgit2/libgit2
octolytics-dimension-repository_network_root_id901662
octolytics-dimension-repository_network_root_nwolibgit2/libgit2
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0af5dc40dcb0f82accd92a80d9517702c13746f0
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodegit/libgit2/pull/2/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Flibgit2%2Fpull%2F2%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodegit%2Flibgit2%2Fpull%2F2%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodegit%2Flibgit2
Reloadhttps://github.com/nodegit/libgit2/pull/2/files
Reloadhttps://github.com/nodegit/libgit2/pull/2/files
Reloadhttps://github.com/nodegit/libgit2/pull/2/files
Please reload this pagehttps://github.com/nodegit/libgit2/pull/2/files
nodegit https://github.com/nodegit
libgit2https://github.com/nodegit/libgit2
libgit2/libgit2https://github.com/libgit2/libgit2
Notifications https://github.com/login?return_to=%2Fnodegit%2Flibgit2
Fork 6 https://github.com/login?return_to=%2Fnodegit%2Flibgit2
Star 4 https://github.com/login?return_to=%2Fnodegit%2Flibgit2
Code https://github.com/nodegit/libgit2
Pull requests 0 https://github.com/nodegit/libgit2/pulls
Actions https://github.com/nodegit/libgit2/actions
Projects https://github.com/nodegit/libgit2/projects
Security and quality 0 https://github.com/nodegit/libgit2/security
Insights https://github.com/nodegit/libgit2/pulse
Code https://github.com/nodegit/libgit2
Pull requests https://github.com/nodegit/libgit2/pulls
Actions https://github.com/nodegit/libgit2/actions
Projects https://github.com/nodegit/libgit2/projects
Security and quality https://github.com/nodegit/libgit2/security
Insights https://github.com/nodegit/libgit2/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodegit%2Flibgit2%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodegit%2Flibgit2%2Fissues%2Fnew%2Fchoose
johnhaley81https://github.com/johnhaley81
nodegit:maint/v0.23https://github.com/nodegit/libgit2/tree/maint/v0.23
srajko:reflog-segfault-fixhttps://github.com/srajko/libgit2/tree/reflog-segfault-fix
Conversation 2 https://github.com/nodegit/libgit2/pull/2
Commits 4 https://github.com/nodegit/libgit2/pull/2/commits
Checks 0 https://github.com/nodegit/libgit2/pull/2/checks
Files changed 4 https://github.com/nodegit/libgit2/pull/2/files
Fix segfault when reading reflog with extra newlines https://github.com/nodegit/libgit2/pull/2/files#top
Show all changes 4 commits https://github.com/nodegit/libgit2/pull/2/files
34fa7d6 Prevent segfault when parsing a reflog with oid parse error srajko Oct 9, 2015 https://github.com/nodegit/libgit2/pull/2/commits/34fa7d6a2f4d5b09e6a120c16618c426c32169c8
0f0969a Removing extra-newline branch from testrepo.git srajko Oct 9, 2015 https://github.com/nodegit/libgit2/pull/2/commits/0f0969aa09f47198b0e62bf9542e2cab6c95eb1c
0469c8e Check for expected OID parse error in test srajko Oct 10, 2015 https://github.com/nodegit/libgit2/pull/2/commits/0469c8e17290a095cf8e63b9cae93a51d1f6d8f0
05a1fc6 Clean up reflog reading error test srajko Oct 14, 2015 https://github.com/nodegit/libgit2/pull/2/commits/05a1fc62818dfa37bcdfda4591364c85b83d185e
Clear filters https://github.com/nodegit/libgit2/pull/2/files
Please reload this pagehttps://github.com/nodegit/libgit2/pull/2/files
Please reload this pagehttps://github.com/nodegit/libgit2/pull/2/files
error-handling.md https://github.com/nodegit/libgit2/pull/2/files#diff-64e77fa41a0849414fe2490e400ce595f0dfc6b340bde62e11334417a0aac9fc
refdb_fs.c https://github.com/nodegit/libgit2/pull/2/files#diff-bff93947e7968a506e744eab91a8c9322168cefbb9bbd4c05ae4ef3d89764d08
reflog.c https://github.com/nodegit/libgit2/pull/2/files#diff-2582a95cb91983da6e56a543253badd6908d12898149e263e4f3c13503fcbc03
extra-newline https://github.com/nodegit/libgit2/pull/2/files#diff-bf083282c88ebfd23526dfaae8b60f52a6fa6ccb04a8e4988821b337497f6756
docs/error-handling.mdhttps://github.com/nodegit/libgit2/pull/2/files#diff-64e77fa41a0849414fe2490e400ce595f0dfc6b340bde62e11334417a0aac9fc
View file https://github.com/srajko/libgit2/blob/05a1fc62818dfa37bcdfda4591364c85b83d185e/docs/error-handling.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/libgit2/pull/2/{{ revealButtonHref }}
https://github.com/nodegit/libgit2/pull/2/files#diff-64e77fa41a0849414fe2490e400ce595f0dfc6b340bde62e11334417a0aac9fc
https://github.com/nodegit/libgit2/pull/2/files#diff-64e77fa41a0849414fe2490e400ce595f0dfc6b340bde62e11334417a0aac9fc
src/refdb_fs.chttps://github.com/nodegit/libgit2/pull/2/files#diff-bff93947e7968a506e744eab91a8c9322168cefbb9bbd4c05ae4ef3d89764d08
View file https://github.com/srajko/libgit2/blob/05a1fc62818dfa37bcdfda4591364c85b83d185e/src/refdb_fs.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/libgit2/pull/2/{{ revealButtonHref }}
https://github.com/nodegit/libgit2/pull/2/files#diff-bff93947e7968a506e744eab91a8c9322168cefbb9bbd4c05ae4ef3d89764d08
https://github.com/nodegit/libgit2/pull/2/files#diff-bff93947e7968a506e744eab91a8c9322168cefbb9bbd4c05ae4ef3d89764d08
tests/refs/reflog/reflog.chttps://github.com/nodegit/libgit2/pull/2/files#diff-2582a95cb91983da6e56a543253badd6908d12898149e263e4f3c13503fcbc03
View file https://github.com/srajko/libgit2/blob/05a1fc62818dfa37bcdfda4591364c85b83d185e/tests/refs/reflog/reflog.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/libgit2/pull/2/{{ revealButtonHref }}
https://github.com/nodegit/libgit2/pull/2/files#diff-2582a95cb91983da6e56a543253badd6908d12898149e263e4f3c13503fcbc03
https://github.com/nodegit/libgit2/pull/2/files#diff-2582a95cb91983da6e56a543253badd6908d12898149e263e4f3c13503fcbc03
tests/resources/testrepo.git/logs/refs/heads/extra-newlinehttps://github.com/nodegit/libgit2/pull/2/files#diff-bf083282c88ebfd23526dfaae8b60f52a6fa6ccb04a8e4988821b337497f6756
View file https://github.com/srajko/libgit2/blob/05a1fc62818dfa37bcdfda4591364c85b83d185e/tests/resources/testrepo.git/logs/refs/heads/extra-newline
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodegit/libgit2/pull/2/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.