René's URL Explorer Experiment


Title: Allow cookies from all subdomains by RubenVerborgh · Pull Request #834 · nodeSolidServer/node-solid-server · GitHub

Open Graph Title: Allow cookies from all subdomains by RubenVerborgh · Pull Request #834 · nodeSolidServer/node-solid-server

X Title: Allow cookies from all subdomains by RubenVerborgh · Pull Request #834 · nodeSolidServer/node-solid-server

Description: A side-effect of #793 is that the security mechanism of #526 is not just applied to the cookie-based login method, but to all login methods (WebID-TLS, WebID-OIDC). #526 rejected cookies as authent...

Open Graph Description: A side-effect of #793 is that the security mechanism of #526 is not just applied to the cookie-based login method, but to all login methods (WebID-TLS, WebID-OIDC). #526 rejected cookies as authent...

X Description: A side-effect of #793 is that the security mechanism of #526 is not just applied to the cookie-based login method, but to all login methods (WebID-TLS, WebID-OIDC). #526 rejected cookies as authent...

Opengraph URL: https://github.com/nodeSolidServer/node-solid-server/pull/834

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cb367f64-6ea9-e892-79d4-0e6357f91f95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA972:159FF8:2A08810:35F5335:69760200
html-safe-nonced07897dcd5179dc320b3951287a6a71b45c7da77fdd2979a63f85cb89b996771
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTcyOjE1OUZGODoyQTA4ODEwOjM1RjUzMzU6Njk3NjAyMDAiLCJ2aXNpdG9yX2lkIjoiMzU0OTU1NTY2MTc1NjMwMTgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56599e1871279c6783b201fa1a403a3ee8a90622c639013fa94c4ae49681563f
hovercard-subject-tagpull_request:219816090
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodeSolidServer/node-solid-server/834/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bb2e4751928ef5e165b40a20e5b89da3a85b22457b1a37bbd98710ad66ca432a/nodeSolidServer/node-solid-server/pull/834
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb2e4751928ef5e165b40a20e5b89da3a85b22457b1a37bbd98710ad66ca432a/nodeSolidServer/node-solid-server/pull/834
og:image:altA side-effect of #793 is that the security mechanism of #526 is not just applied to the cookie-based login method, but to all login methods (WebID-TLS, WebID-OIDC). #526 rejected cookies as authent...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRubenVerborgh
hostnamegithub.com
expected-hostnamegithub.com
Nonec6814b4cc7afd45cd6e64525d0cff0e76dd802f315a5b0e55a7abda1d1d070d0
turbo-cache-controlno-preview
go-importgithub.com/nodeSolidServer/node-solid-server git https://github.com/nodeSolidServer/node-solid-server.git
octolytics-dimension-user_id104446421
octolytics-dimension-user_loginnodeSolidServer
octolytics-dimension-repository_id24306004
octolytics-dimension-repository_nwonodeSolidServer/node-solid-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24306004
octolytics-dimension-repository_network_root_nwonodeSolidServer/node-solid-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ea235bfed58ef16c8a5642b3ac64b74f10c9f52
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodeSolidServer/node-solid-server/pull/834#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F834
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F834
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodeSolidServer%2Fnode-solid-server
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/834
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/834
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/834
nodeSolidServer https://github.com/nodeSolidServer
node-solid-serverhttps://github.com/nodeSolidServer/node-solid-server
Notifications https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Fork 305 https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Star 1.8k https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Code https://github.com/nodeSolidServer/node-solid-server
Issues 295 https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests 21 https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects 0 https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security 0 https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Code https://github.com/nodeSolidServer/node-solid-server
Issues https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodeSolidServer/node-solid-server/pull/834#issue-comment-box
RubenVerborghhttps://github.com/RubenVerborgh
develophttps://github.com/nodeSolidServer/node-solid-server/tree/develop
fix/allow-subdomain-cookieshttps://github.com/nodeSolidServer/node-solid-server/tree/fix/allow-subdomain-cookies
Allow cookies from all subdomains https://github.com/nodeSolidServer/node-solid-server/pull/834#top
RubenVerborghhttps://github.com/RubenVerborgh
develophttps://github.com/nodeSolidServer/node-solid-server/tree/develop
fix/allow-subdomain-cookieshttps://github.com/nodeSolidServer/node-solid-server/tree/fix/allow-subdomain-cookies
Conversation 5 https://github.com/nodeSolidServer/node-solid-server/pull/834
Commits 1 https://github.com/nodeSolidServer/node-solid-server/pull/834/commits
Checks 0 https://github.com/nodeSolidServer/node-solid-server/pull/834/checks
Files changed https://github.com/nodeSolidServer/node-solid-server/pull/834/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/{{ revealButtonHref }}
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#issue-366042829
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
#793https://github.com/nodeSolidServer/node-solid-server/pull/793
#526https://github.com/nodeSolidServer/node-solid-server/pull/526
#526https://github.com/nodeSolidServer/node-solid-server/pull/526
https://alice.solid.communityhttps://alice.solid.community
https://solid.communityhttps://solid.community
https://my.self/#mehttps://my.self/#me
https://solid.communityhttps://solid.community
https://my.self/#mehttps://my.self/#me
https://my.selfhttps://my.self
https://solid.communityhttps://solid.community
https://my.self/#mehttps://my.self/#me
#793https://github.com/nodeSolidServer/node-solid-server/pull/793
@kidehenhttps://github.com/kidehen
#793 (comment)https://github.com/nodeSolidServer/node-solid-server/pull/793#issuecomment-426341408
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
blocker https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Ablocker
security https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Asecurity
authentication https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Aauthentication
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#event-1880208308
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
5.0.0https://github.com/nodeSolidServer/node-solid-server/milestone/8
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#event-1880208314
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#event-1880208327
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
kidehenhttps://github.com/kidehen
kjetilkhttps://github.com/kjetilk
megothhttps://github.com/megoth
October 2, 2018 19:20https://github.com/nodeSolidServer/node-solid-server/pull/834#event-1880208339
https://github.com/kjetilk
kjetilkhttps://github.com/kjetilk
Oct 2, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/834#pullrequestreview-160893192
View reviewed changes https://github.com/nodeSolidServer/node-solid-server/pull/834/files
lib/models/solid-host.jshttps://github.com/nodeSolidServer/node-solid-server/pull/834/files#diff-f61cddb750d9fa736e0b240eafb89b4e620035e46d2a38c8d717b6aa34bc9716
kjetilkhttps://github.com/kjetilk
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#discussion_r222088017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
RubenVerborghhttps://github.com/RubenVerborgh
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#discussion_r222093780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.com/kjetilk
kjetilkhttps://github.com/kjetilk
Oct 2, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/834#pullrequestreview-160894587
View reviewed changes https://github.com/nodeSolidServer/node-solid-server/pull/834/files
kjetilkhttps://github.com/kjetilk
https://github.com/nodeSolidServer/node-solid-server/pull/834#pullrequestreview-160894587
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.com/RubenVerborgh
Allow cookies from all subdomains.https://github.com/nodeSolidServer/node-solid-server/pull/834/commits/0170a221c2edef027562d0e2e9b6600effe5d448
0170a22https://github.com/nodeSolidServer/node-solid-server/pull/834/commits/0170a221c2edef027562d0e2e9b6600effe5d448
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
force-pushedhttps://github.com/nodeSolidServer/node-solid-server/compare/51e43c8b3a7cbcb28bd6b45a7493fb2b873f2d9a..0170a221c2edef027562d0e2e9b6600effe5d448
51e43c8https://github.com/nodeSolidServer/node-solid-server/commit/51e43c8b3a7cbcb28bd6b45a7493fb2b873f2d9a
0170a22https://github.com/nodeSolidServer/node-solid-server/commit/0170a221c2edef027562d0e2e9b6600effe5d448
Compare https://github.com/nodeSolidServer/node-solid-server/compare/51e43c8b3a7cbcb28bd6b45a7493fb2b873f2d9a..0170a221c2edef027562d0e2e9b6600effe5d448
October 2, 2018 20:07https://github.com/nodeSolidServer/node-solid-server/pull/834#event-1880309253
https://github.com/kidehen
kidehenhttps://github.com/kidehen
Oct 2, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/834#pullrequestreview-160902143
View reviewed changes https://github.com/nodeSolidServer/node-solid-server/pull/834/files/0170a221c2edef027562d0e2e9b6600effe5d448
kidehenhttps://github.com/kidehen
https://github.com/nodeSolidServer/node-solid-server/pull/834#pullrequestreview-160902143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
interop pagehttps://github.com/solid/node-solid-server/wiki/Running-Test-Implementations-of-Solid-compatible-servers
@RubenVerborghhttps://github.com/RubenVerborgh
confirmation tweethttps://twitter.com/kidehen/status/1047210041630253057
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#issuecomment-426416275
@kidehenhttps://github.com/kidehen
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
Oct 2, 2018https://github.com/nodeSolidServer/node-solid-server/pull/834#event-1880339826
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
Oct 2, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/834#ref-pullrequest-366068435
Block cookie auth from non-subdomains, but allow all other auth from everywhere #835 https://github.com/nodeSolidServer/node-solid-server/pull/835
https://github.com/AH7
AH7https://github.com/AH7
May 14, 2022 https://github.com/nodeSolidServer/node-solid-server/pull/834#ref-pullrequest-1235835438
[Snyk] Security upgrade inquirer from 1.2.3 to 6.5.1 AH7/node-solid-server#25 https://github.com/AH7/node-solid-server/pull/25
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F834
https://github.com/kjetilk
kjetilk https://github.com/kjetilk
https://github.com/nodeSolidServer/node-solid-server/pull/834/files/51e43c8b3a7cbcb28bd6b45a7493fb2b873f2d9a
https://github.com/megoth
megoth https://github.com/megoth
https://github.com/kidehen
kidehen https://github.com/kidehen
https://github.com/nodeSolidServer/node-solid-server/pull/834/files/0170a221c2edef027562d0e2e9b6600effe5d448
https://github.com/RubenVerborgh
RubenVerborgh https://github.com/RubenVerborgh
authentication https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Aauthentication
blocker https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Ablocker
security https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Asecurity
5.0.0 https://github.com/nodeSolidServer/node-solid-server/milestone/8
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/834
https://github.com/RubenVerborgh
https://github.com/kjetilk
https://github.com/kidehen
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.