René's URL Explorer Experiment


Title: Fix .acl lookup for paths with spaces by RubenVerborgh · Pull Request #660 · nodeSolidServer/node-solid-server · GitHub

Open Graph Title: Fix .acl lookup for paths with spaces by RubenVerborgh · Pull Request #660 · nodeSolidServer/node-solid-server

X Title: Fix .acl lookup for paths with spaces by RubenVerborgh · Pull Request #660 · nodeSolidServer/node-solid-server

Description: In #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and sometimes implemented incorrectly—as apparently was the case for ACLs. This pull request does the following: It introduces a LegacyResourceMapper, which implements the URL to filename mapping that is currently used in v4.x, and now incorporates an URL encoding fix. I have wired up this mapper into the faulty .acl lookup component, such that it now properly decodes percent escapes. The LegacyResourceMapper extends the new ResourceMapper introduced in #643, which captures the future URL to filename mapping. This new mapper has not been wired up yet, since it breaks compatibility and needs to be part of the 5.x release. In the future, we want to wire up this LegacyResourceMapper to get rid of the error-prone inline mapping code (#661), which will allow us to transition easily to the new ResourceMapper (#662).

Open Graph Description: In #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...

X Description: In #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...

Opengraph URL: https://github.com/nodeSolidServer/node-solid-server/pull/660

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6003ec43-98b3-44a3-7eb1-7bf644a38617
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1DC:18DE62:7031634:9092A6A:6976A8E6
html-safe-nonce3c2c3934ed7401777de90653ff0e2734b1156f9677e6ad745d5f0a14c101ca84
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMURDOjE4REU2Mjo3MDMxNjM0OjkwOTJBNkE6Njk3NkE4RTYiLCJ2aXNpdG9yX2lkIjoiODIxMTQzMzY3MzAyNzEzNTcxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac399998e1ac179ed597a2531f018a18f7d255cd075221b76bc1e4696416ddeeff
hovercard-subject-tagpull_request:185593486
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodeSolidServer/node-solid-server/pull/660/files
twitter:imagehttps://avatars.githubusercontent.com/u/675313?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/675313?s=400&v=4
og:image:altIn #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodeSolidServer/node-solid-server git https://github.com/nodeSolidServer/node-solid-server.git
octolytics-dimension-user_id104446421
octolytics-dimension-user_loginnodeSolidServer
octolytics-dimension-repository_id24306004
octolytics-dimension-repository_nwonodeSolidServer/node-solid-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24306004
octolytics-dimension-repository_network_root_nwonodeSolidServer/node-solid-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b577f6be6482e336e3c30e8daefa30144947b17
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodeSolidServer/node-solid-server/pull/660/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F660%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F660%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodeSolidServer%2Fnode-solid-server
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
nodeSolidServer https://github.com/nodeSolidServer
node-solid-serverhttps://github.com/nodeSolidServer/node-solid-server
Notifications https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Fork 305 https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Star 1.8k https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Code https://github.com/nodeSolidServer/node-solid-server
Issues 296 https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests 21 https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects 0 https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security 0 https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Code https://github.com/nodeSolidServer/node-solid-server
Issues https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
RubenVerborghhttps://github.com/RubenVerborgh
develophttps://github.com/nodeSolidServer/node-solid-server/tree/develop
fix/mapping-percent-encodedhttps://github.com/nodeSolidServer/node-solid-server/tree/fix/mapping-percent-encoded
Conversation 1 https://github.com/nodeSolidServer/node-solid-server/pull/660
Commits 5 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits
Checks 0 https://github.com/nodeSolidServer/node-solid-server/pull/660/checks
Files changed https://github.com/nodeSolidServer/node-solid-server/pull/660/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
Fix .acl lookup for paths with spaces https://github.com/nodeSolidServer/node-solid-server/pull/660/files#top
Show all changes 5 commits https://github.com/nodeSolidServer/node-solid-server/pull/660/files
321dc6d Reduce regex usage. RubenVerborgh Mar 13, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/321dc6dafb405ad97ee71aae33b6f53e57a952f0
eb29ddd Handle percent encoding. RubenVerborgh May 1, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/eb29ddd0403d4095d2c26907be446398d2dfe16f
3a42fd4 Add LegacyResourceMapper. RubenVerborgh May 2, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/3a42fd497d76b4dfa49d06844127e558186b8cba
a704e96 Use LegacyResourceMapper in allow handler. RubenVerborgh May 3, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/a704e96a4ff330f5a86cfea3a074e668879f1b8c
c121cce Include ports in URL generation. RubenVerborgh May 3, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/c121ccea2779bec3a142d1aa5a0d6884f0d83b9a
Clear filters https://github.com/nodeSolidServer/node-solid-server/pull/660/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
allow.js https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
legacy-resource-mapper.js https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-c9f0c989e7b04a9a4d708827d8e580bb37a1d38927dc57b146b12aaea069f8e3
resource-mapper.js https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-19e0e988901663e2a77d6b5837da3472103eae5f6c85fd441581545b42649268
legacy-resource-mapper-test.js https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9b590ffff773538e753cb6ab6eb806cb76473c6421133b332392299746dec859
resource-mapper-test.js https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-aef1a447470e8629513326b9afd4516823922f8348a13767a654df22c69ee63c
lib/handlers/allow.jshttps://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
View file https://github.com/nodeSolidServer/node-solid-server/blob/c121ccea2779bec3a142d1aa5a0d6884f0d83b9a/lib/handlers/allow.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/660/{{ revealButtonHref }}
https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
lib/legacy-resource-mapper.jshttps://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-c9f0c989e7b04a9a4d708827d8e580bb37a1d38927dc57b146b12aaea069f8e3
View file https://github.com/nodeSolidServer/node-solid-server/blob/c121ccea2779bec3a142d1aa5a0d6884f0d83b9a/lib/legacy-resource-mapper.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/660/{{ revealButtonHref }}
lib/resource-mapper.jshttps://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-19e0e988901663e2a77d6b5837da3472103eae5f6c85fd441581545b42649268
View file https://github.com/nodeSolidServer/node-solid-server/blob/c121ccea2779bec3a142d1aa5a0d6884f0d83b9a/lib/resource-mapper.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/660/{{ revealButtonHref }}
https://github.com/nodeSolidServer/node-solid-server/pull/660/files#diff-19e0e988901663e2a77d6b5837da3472103eae5f6c85fd441581545b42649268
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.