René's URL Explorer Experiment


Title: Fix .acl lookup for paths with spaces by RubenVerborgh · Pull Request #660 · nodeSolidServer/node-solid-server · GitHub

Open Graph Title: Fix .acl lookup for paths with spaces by RubenVerborgh · Pull Request #660 · nodeSolidServer/node-solid-server

X Title: Fix .acl lookup for paths with spaces by RubenVerborgh · Pull Request #660 · nodeSolidServer/node-solid-server

Description: In #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...

Open Graph Description: In #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...

X Description: In #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...

Opengraph URL: https://github.com/nodeSolidServer/node-solid-server/pull/660

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:35a6e5f5-d0f1-a082-9e50-a844b0fedaf5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E02:14207:B632E3B:EB26261:69768572
html-safe-noncef3779a980aca91d239963465bd5119821687c6c212c3655da7003544ee6b288d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTAyOjE0MjA3OkI2MzJFM0I6RUIyNjI2MTo2OTc2ODU3MiIsInZpc2l0b3JfaWQiOiI1MDY1MjQ3OTQ1NDc3NDkwMDM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfd7d23eb511e1be1211e9b8c16dc4fa05fae91baeec454abafe099a250398712
hovercard-subject-tagpull_request:185593486
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodeSolidServer/node-solid-server/660/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/262cc9aade9faeb19aea1ee8cadefb5b6c5b6254fde1763b50a136d370d18853/nodeSolidServer/node-solid-server/pull/660
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/262cc9aade9faeb19aea1ee8cadefb5b6c5b6254fde1763b50a136d370d18853/nodeSolidServer/node-solid-server/pull/660
og:image:altIn #656, we found that looking up .acl files breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and someti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRubenVerborgh
hostnamegithub.com
expected-hostnamegithub.com
None032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411
turbo-cache-controlno-preview
go-importgithub.com/nodeSolidServer/node-solid-server git https://github.com/nodeSolidServer/node-solid-server.git
octolytics-dimension-user_id104446421
octolytics-dimension-user_loginnodeSolidServer
octolytics-dimension-repository_id24306004
octolytics-dimension-repository_nwonodeSolidServer/node-solid-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24306004
octolytics-dimension-repository_network_root_nwonodeSolidServer/node-solid-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b577f6be6482e336e3c30e8daefa30144947b17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodeSolidServer/node-solid-server/pull/660#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F660
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F660
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodeSolidServer%2Fnode-solid-server
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/660
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/660
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/660
nodeSolidServer https://github.com/nodeSolidServer
node-solid-serverhttps://github.com/nodeSolidServer/node-solid-server
Notifications https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Fork 305 https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Star 1.8k https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Code https://github.com/nodeSolidServer/node-solid-server
Issues 296 https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests 21 https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects 0 https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security 0 https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Code https://github.com/nodeSolidServer/node-solid-server
Issues https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodeSolidServer/node-solid-server/pull/660#issue-comment-box
RubenVerborghhttps://github.com/RubenVerborgh
develophttps://github.com/nodeSolidServer/node-solid-server/tree/develop
fix/mapping-percent-encodedhttps://github.com/nodeSolidServer/node-solid-server/tree/fix/mapping-percent-encoded
Fix .acl lookup for paths with spaces https://github.com/nodeSolidServer/node-solid-server/pull/660#top
RubenVerborghhttps://github.com/RubenVerborgh
develophttps://github.com/nodeSolidServer/node-solid-server/tree/develop
fix/mapping-percent-encodedhttps://github.com/nodeSolidServer/node-solid-server/tree/fix/mapping-percent-encoded
Conversation 1 https://github.com/nodeSolidServer/node-solid-server/pull/660
Commits 5 https://github.com/nodeSolidServer/node-solid-server/pull/660/commits
Checks 0 https://github.com/nodeSolidServer/node-solid-server/pull/660/checks
Files changed https://github.com/nodeSolidServer/node-solid-server/pull/660/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/{{ revealButtonHref }}
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
May 3, 2018https://github.com/nodeSolidServer/node-solid-server/pull/660#issue-319754513
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660
#656https://github.com/nodeSolidServer/node-solid-server/issues/656
#643https://github.com/nodeSolidServer/node-solid-server/pull/643
#661https://github.com/nodeSolidServer/node-solid-server/issues/661
#662https://github.com/nodeSolidServer/node-solid-server/issues/662
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660
RubenVerborghhttps://github.com/RubenVerborgh
May 2, 2018 14:05https://github.com/nodeSolidServer/node-solid-server/pull/660#commits-pushed-321dc6d
https://github.com/RubenVerborgh
Reduce regex usage.https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/321dc6dafb405ad97ee71aae33b6f53e57a952f0
321dc6dhttps://github.com/nodeSolidServer/node-solid-server/pull/660/commits/321dc6dafb405ad97ee71aae33b6f53e57a952f0
https://github.com/RubenVerborgh
Handle percent encoding.https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/eb29ddd0403d4095d2c26907be446398d2dfe16f
eb29dddhttps://github.com/nodeSolidServer/node-solid-server/pull/660/commits/eb29ddd0403d4095d2c26907be446398d2dfe16f
https://github.com/RubenVerborgh
Add LegacyResourceMapper.https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/3a42fd497d76b4dfa49d06844127e558186b8cba
3a42fd4https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/3a42fd497d76b4dfa49d06844127e558186b8cba
https://github.com/RubenVerborgh
Use LegacyResourceMapper in allow handler.https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/a704e96a4ff330f5a86cfea3a074e668879f1b8c
a704e96https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/a704e96a4ff330f5a86cfea3a074e668879f1b8c
#656https://github.com/nodeSolidServer/node-solid-server/issues/656
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
bug https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Abug
priority-high https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Apriority-high
ready for review https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3A%22ready%20for%20review%22
Epic https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3AEpic
security https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Asecurity
May 3, 2018https://github.com/nodeSolidServer/node-solid-server/pull/660#event-1606711360
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
May 3, 2018https://github.com/nodeSolidServer/node-solid-server/pull/660#event-1606711370
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
timblhttps://github.com/timbl
May 3, 2018 00:24https://github.com/nodeSolidServer/node-solid-server/pull/660#event-1606711379
Wire up LegacyResourceMapper #661 https://github.com/nodeSolidServer/node-solid-server/issues/661
.acl lookup breaks when the path contains spaces #656 https://github.com/nodeSolidServer/node-solid-server/issues/656
https://github.com/timbl
timblhttps://github.com/timbl
May 3, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660#pullrequestreview-117346065
View reviewed changes https://github.com/nodeSolidServer/node-solid-server/pull/660/files/a704e96a4ff330f5a86cfea3a074e668879f1b8c
timblhttps://github.com/timbl
https://github.com/nodeSolidServer/node-solid-server/pull/660#pullrequestreview-117346065
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660
https://github.com/RubenVerborgh
Include ports in URL generation.https://github.com/nodeSolidServer/node-solid-server/pull/660/commits/c121ccea2779bec3a142d1aa5a0d6884f0d83b9a
c121ccehttps://github.com/nodeSolidServer/node-solid-server/pull/660/commits/c121ccea2779bec3a142d1aa5a0d6884f0d83b9a
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
1551b58https://github.com/nodeSolidServer/node-solid-server/commit/1551b58e379c233aafada4c978fd85f7c35951a2
May 3, 2018https://github.com/nodeSolidServer/node-solid-server/pull/660#event-1608326311
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
May 3, 2018 18:07https://github.com/nodeSolidServer/node-solid-server/pull/660#event-1608326509
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
May 8, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660#ref-issue-299941723
401 error on fetch() after logging in with OIDC #638 https://github.com/nodeSolidServer/node-solid-server/issues/638
https://github.com/RubenVerborgh
RubenVerborghhttps://github.com/RubenVerborgh
Nov 19, 2018 https://github.com/nodeSolidServer/node-solid-server/pull/660#ref-issue-382209149
ResourceMapper transition actions #946 https://github.com/nodeSolidServer/node-solid-server/issues/946
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F660
https://github.com/timbl
timbl https://github.com/timbl
https://github.com/nodeSolidServer/node-solid-server/pull/660/files/a704e96a4ff330f5a86cfea3a074e668879f1b8c
https://github.com/RubenVerborgh
RubenVerborgh https://github.com/RubenVerborgh
bug https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Abug
Epic https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3AEpic
priority-high https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Apriority-high
ready for review https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3A%22ready%20for%20review%22
security https://github.com/nodeSolidServer/node-solid-server/issues?q=state%3Aopen%20label%3Asecurity
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/660
https://github.com/RubenVerborgh
https://github.com/timbl
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.