René's URL Explorer Experiment


Title: Fix verifyDelegator() logic in the allow handler by dmitrizagidulin · Pull Request #475 · nodeSolidServer/node-solid-server · GitHub

Open Graph Title: Fix verifyDelegator() logic in the allow handler by dmitrizagidulin · Pull Request #475 · nodeSolidServer/node-solid-server

X Title: Fix verifyDelegator() logic in the allow handler by dmitrizagidulin · Pull Request #475 · nodeSolidServer/node-solid-server

Description: Fixes issue #473.

Open Graph Description: Fixes issue #473.

X Description: Fixes issue #473.

Opengraph URL: https://github.com/nodeSolidServer/node-solid-server/pull/475

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:20764da1-e371-7544-cc26-4716896b9c3b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8826:255D99:4D375C1:699F2DF:69780FD6
html-safe-nonce318d633783f05b57d580d1569f61778a607f5ff4d8a3199302312f69bcc7b6a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODI2OjI1NUQ5OTo0RDM3NUMxOjY5OUYyREY6Njk3ODBGRDYiLCJ2aXNpdG9yX2lkIjoiOTA0ODk4NjQ1NzAwMTU3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac49efb06936886ed8d7fa977d7770a923edc555dfc3cdc6fc9c5060f13480727b
hovercard-subject-tagpull_request:99153320
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodeSolidServer/node-solid-server/pull/475/files
twitter:imagehttps://avatars.githubusercontent.com/u/947005?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/947005?s=400&v=4
og:image:altFixes issue #473.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee71ed39771d00f42ce2fc9320895c8c608c164191e118eae487fc3bd0af6886d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodeSolidServer/node-solid-server git https://github.com/nodeSolidServer/node-solid-server.git
octolytics-dimension-user_id104446421
octolytics-dimension-user_loginnodeSolidServer
octolytics-dimension-repository_id24306004
octolytics-dimension-repository_nwonodeSolidServer/node-solid-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24306004
octolytics-dimension-repository_network_root_nwonodeSolidServer/node-solid-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release371710c20276ca72b3e82b0f41ece556a0038443
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodeSolidServer/node-solid-server/pull/475/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F475%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F475%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodeSolidServer%2Fnode-solid-server
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
Reloadhttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
nodeSolidServer https://github.com/nodeSolidServer
node-solid-serverhttps://github.com/nodeSolidServer/node-solid-server
Notifications https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Fork 305 https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Star 1.8k https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server
Code https://github.com/nodeSolidServer/node-solid-server
Issues 296 https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests 21 https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects 0 https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security 0 https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Code https://github.com/nodeSolidServer/node-solid-server
Issues https://github.com/nodeSolidServer/node-solid-server/issues
Pull requests https://github.com/nodeSolidServer/node-solid-server/pulls
Actions https://github.com/nodeSolidServer/node-solid-server/actions
Projects https://github.com/nodeSolidServer/node-solid-server/projects
Wiki https://github.com/nodeSolidServer/node-solid-server/wiki
Security https://github.com/nodeSolidServer/node-solid-server/security
Insights https://github.com/nodeSolidServer/node-solid-server/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose
dmitrizagidulinhttps://github.com/dmitrizagidulin
masterhttps://github.com/nodeSolidServer/node-solid-server/tree/master
dz_fix_delegationhttps://github.com/nodeSolidServer/node-solid-server/tree/dz_fix_delegation
Conversation 54 https://github.com/nodeSolidServer/node-solid-server/pull/475
Commits 8 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits
Checks 0 https://github.com/nodeSolidServer/node-solid-server/pull/475/checks
Files changed https://github.com/nodeSolidServer/node-solid-server/pull/475/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
Fix verifyDelegator() logic in the allow handler https://github.com/nodeSolidServer/node-solid-server/pull/475/files#top
Show all changes 8 commits https://github.com/nodeSolidServer/node-solid-server/pull/475/files
82a97db Fix verifyDelegator() logic in the allow handler dmitrizagidulin Dec 22, 2016 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/82a97db455fa14e46972e8514be72d907c4dba4e
e8da502 Refactor getUserId() dmitrizagidulin Dec 22, 2016 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/e8da502f52b135f8bedc222b19aac64b07881608
8bc4a08 Refactor getUserId() and verifyDelegator() to return promises dmitrizagidulin Jan 3, 2017 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/8bc4a08d365806bfe85f4664ebf064a93e1e2de1
3f47217 Add tests for getUserId() and verifyDelegator() dmitrizagidulin Jan 4, 2017 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/3f472175804971ffc430443b2c91ebcd341386c8
9c4f0c7 Bump mocha version dmitrizagidulin Jan 20, 2017 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/9c4f0c764a88a071c423561d9affcd61148948d6
f3d5a79 Addressing PR feedback dmitrizagidulin Jan 20, 2017 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/f3d5a79be30569cf775115fbe1d24f2604b491d5
9da1238 Expand docstring on verifyDelegator() dmitrizagidulin Jan 20, 2017 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/9da1238d4476f6708c8ddf612b68d1c88927ea56
b98b1e4 Remove unneeded done() invocations dmitrizagidulin Jan 23, 2017 https://github.com/nodeSolidServer/node-solid-server/pull/475/commits/b98b1e48a98caf3245bf00d354400f473c2d2589
Clear filters https://github.com/nodeSolidServer/node-solid-server/pull/475/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
allow.js https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
utils.js https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-5dfe38baf287dcf756a17c2dd63483781b53bf4b669e10efdd01e74bcd8e780a
package.json https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
allow.js https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-e4cae9bc5f4ff047f4c40e41507a971eaa8716da8ac1f1d821305f90a53d66a7
utils.js https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-56d361e6893cf9d961de277f3986602b66ace5d977e446d4161c664a95a48f5b
lib/handlers/allow.jshttps://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
View file https://github.com/nodeSolidServer/node-solid-server/blob/b98b1e48a98caf3245bf00d354400f473c2d2589/lib/handlers/allow.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/475/{{ revealButtonHref }}
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
nicolahttps://github.com/nicola
Jan 21, 2017https://github.com/nodeSolidServer/node-solid-server/pull/475/files#r97205289
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
dmitrizagidulinhttps://github.com/dmitrizagidulin
Jan 21, 2017https://github.com/nodeSolidServer/node-solid-server/pull/475/files#r97205346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@nicolahttps://github.com/nicola
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
dan-fhttps://github.com/dan-f
Jan 10, 2017https://github.com/nodeSolidServer/node-solid-server/pull/475/files#r95386895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
dmitrizagidulinhttps://github.com/dmitrizagidulin
Jan 10, 2017https://github.com/nodeSolidServer/node-solid-server/pull/475/files#r95396051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-9bdf319234f98fd9a5e3b778603a8083d1a4a1354761b7e7bb961f6a7762d89b
dan-fhttps://github.com/dan-f
Jan 10, 2017https://github.com/nodeSolidServer/node-solid-server/pull/475/files#r95383562
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
lib/utils.jshttps://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-5dfe38baf287dcf756a17c2dd63483781b53bf4b669e10efdd01e74bcd8e780a
View file https://github.com/nodeSolidServer/node-solid-server/blob/b98b1e48a98caf3245bf00d354400f473c2d2589/lib/utils.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/475/{{ revealButtonHref }}
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-5dfe38baf287dcf756a17c2dd63483781b53bf4b669e10efdd01e74bcd8e780a
dan-fhttps://github.com/dan-f
Jan 10, 2017https://github.com/nodeSolidServer/node-solid-server/pull/475/files#r95385143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-5dfe38baf287dcf756a17c2dd63483781b53bf4b669e10efdd01e74bcd8e780a
package.jsonhttps://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/nodeSolidServer/node-solid-server/blob/b98b1e48a98caf3245bf00d354400f473c2d2589/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/475/{{ revealButtonHref }}
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
test/allow.jshttps://github.com/nodeSolidServer/node-solid-server/pull/475/files#diff-e4cae9bc5f4ff047f4c40e41507a971eaa8716da8ac1f1d821305f90a53d66a7
View file https://github.com/nodeSolidServer/node-solid-server/blob/b98b1e48a98caf3245bf00d354400f473c2d2589/test/allow.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodeSolidServer/node-solid-server/pull/475/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodeSolidServer/node-solid-server/pull/475/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.