| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:92204432-6f0f-2e17-84bc-b4ec684e9786 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD92:17A029:1AE8AE5:2514A80:6971F240 |
| html-safe-nonce | d892faf643211d1e4618d9b98a88d4214d4ac3083fb6d60317ec4527f1345a24 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDkyOjE3QTAyOToxQUU4QUU1OjI1MTRBODA6Njk3MUYyNDAiLCJ2aXNpdG9yX2lkIjoiNDcxNTI3MDQ4NjY2MzIzMDAxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 89b1c959d8584b71ce9dde8c0ff59441fd851add02fa4bb00e2e89c579694e03 |
| hovercard-subject-tag | pull_request:333632423 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodeSolidServer/node-solid-server/1333/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/adcfeaf71da4d6f57c797a89a462da4aa043ac1cb06832a41546c82a3c94d7fb/nodeSolidServer/node-solid-server/pull/1333 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/adcfeaf71da4d6f57c797a89a462da4aa043ac1cb06832a41546c82a3c94d7fb/nodeSolidServer/node-solid-server/pull/1333 |
| og:image:alt | The tests for WebID TLS didn't actually test NSS. I have updated the tests properly which show that TLS is broken on NSS. Yet, because TLS will soon be depricated I will not fix. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jaxoncreed |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d9da1aa47d387dfb2aca0f2e5c19150dc936b8128a6b2ecd6a02fc26a378fff |
| turbo-cache-control | no-preview |
| go-import | github.com/nodeSolidServer/node-solid-server git https://github.com/nodeSolidServer/node-solid-server.git |
| octolytics-dimension-user_id | 104446421 |
| octolytics-dimension-user_login | nodeSolidServer |
| octolytics-dimension-repository_id | 24306004 |
| octolytics-dimension-repository_nwo | nodeSolidServer/node-solid-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24306004 |
| octolytics-dimension-repository_network_root_nwo | nodeSolidServer/node-solid-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4332d3e3368b9bce3dfd3c4a2643112933072734 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodeSolidServer/node-solid-server/pull/1333#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F1333 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F1333 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodeSolidServer%2Fnode-solid-server |
| Reload | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| Reload | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| Reload | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
|
nodeSolidServer
| https://github.com/nodeSolidServer |
| node-solid-server | https://github.com/nodeSolidServer/node-solid-server |
|
Notifications
| https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server |
|
Fork
305
| https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server |
|
Star
1.8k
| https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server |
|
Code
| https://github.com/nodeSolidServer/node-solid-server |
|
Issues
295
| https://github.com/nodeSolidServer/node-solid-server/issues |
|
Pull requests
21
| https://github.com/nodeSolidServer/node-solid-server/pulls |
|
Actions
| https://github.com/nodeSolidServer/node-solid-server/actions |
|
Projects
0
| https://github.com/nodeSolidServer/node-solid-server/projects |
|
Wiki
| https://github.com/nodeSolidServer/node-solid-server/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodeSolidServer/node-solid-server/security |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
|
Insights
| https://github.com/nodeSolidServer/node-solid-server/pulse |
|
Code
| https://github.com/nodeSolidServer/node-solid-server |
|
Issues
| https://github.com/nodeSolidServer/node-solid-server/issues |
|
Pull requests
| https://github.com/nodeSolidServer/node-solid-server/pulls |
|
Actions
| https://github.com/nodeSolidServer/node-solid-server/actions |
|
Projects
| https://github.com/nodeSolidServer/node-solid-server/projects |
|
Wiki
| https://github.com/nodeSolidServer/node-solid-server/wiki |
|
Security
| https://github.com/nodeSolidServer/node-solid-server/security |
|
Insights
| https://github.com/nodeSolidServer/node-solid-server/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FnodeSolidServer%2Fnode-solid-server%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodeSolidServer/node-solid-server/pull/1333#issue-comment-box |
| jaxoncreed | https://github.com/jaxoncreed |
| master | https://github.com/nodeSolidServer/node-solid-server/tree/master |
| fixTLSTests | https://github.com/nodeSolidServer/node-solid-server/tree/fixTLSTests |
|
Fix tls tests
| https://github.com/nodeSolidServer/node-solid-server/pull/1333#top |
| jaxoncreed | https://github.com/jaxoncreed |
| master | https://github.com/nodeSolidServer/node-solid-server/tree/master |
| fixTLSTests | https://github.com/nodeSolidServer/node-solid-server/tree/fixTLSTests |
|
Conversation
4
| https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
|
Commits
7
| https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits |
|
Checks
0
| https://github.com/nodeSolidServer/node-solid-server/pull/1333/checks |
|
Files changed
| https://github.com/nodeSolidServer/node-solid-server/pull/1333/files |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| https://github.co/hiddenchars |
| https://github.com/nodeSolidServer/node-solid-server/pull/{{ revealButtonHref }} |
|
| https://github.com/jaxoncreed |
| jaxoncreed | https://github.com/jaxoncreed |
| Oct 29, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#issue-513936548 |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| October 24, 2019 13:38 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#commits-pushed-1a92a91 |
| Fix TLS Tests | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/1a92a912c1d2c1e0e81a002d303e5c98c78dc550 |
| 1a92a91 | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/1a92a912c1d2c1e0e81a002d303e5c98c78dc550 |
| Set up file structure for tls tests | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/53c063bdb07ed98c8be9c995c518e86067926fb1 |
| 53c063b | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/53c063bdb07ed98c8be9c995c518e86067926fb1 |
| TLS test has parsable webID | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/c0bea97484fcc61abd8f537526de93f0e8dc57ca |
| c0bea97 | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/c0bea97484fcc61abd8f537526de93f0e8dc57ca |
| Skipped tls tests | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/778095ad37a2ece22f19871aab37a2fed26ba416 |
| 778095a | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/778095ad37a2ece22f19871aab37a2fed26ba416 |
| Clean up | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/63e47bb19e525f7dce442fd761ec1fdb76324913 |
| 63e47bb | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/63e47bb19e525f7dce442fd761ec1fdb76324913 |
| https://github.com/jaxoncreed |
| jaxoncreed | https://github.com/jaxoncreed |
| Oct 29, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#event-2752424545 |
| Code cleanup | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/86a4487ea31ab19aadd1edc31362a29f46113ae2 |
| 86a4487 | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/86a4487ea31ab19aadd1edc31362a29f46113ae2 |
| https://github.com/michielbdejong |
| michielbdejong | https://github.com/michielbdejong |
|
Nov 1, 2019
| https://github.com/nodeSolidServer/node-solid-server/pull/1333#pullrequestreview-310353769 |
|
View reviewed changes
| https://github.com/nodeSolidServer/node-solid-server/pull/1333/files/86a4487ea31ab19aadd1edc31362a29f46113ae2 |
| test/integration/acl-tls-test.js | https://github.com/nodeSolidServer/node-solid-server/pull/1333/files/86a4487ea31ab19aadd1edc31362a29f46113ae2#diff-7d044c16a2ca0aac89fada6f74c0fdfda4afa3595825ad3bcf5bef72ae33c9d7 |
| michielbdejong | https://github.com/michielbdejong |
| Nov 1, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#discussion_r341498924 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| michielbdejong | https://github.com/michielbdejong |
| Nov 1, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#discussion_r341499303 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| michielbdejong | https://github.com/michielbdejong |
| Nov 1, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#discussion_r341499754 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| solid/solid-spec#171 (comment) | https://github.com/solid/solid-spec/pull/171#issuecomment-506350514 |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| https://github.com/michielbdejong |
| michielbdejong | https://github.com/michielbdejong |
| Nov 1, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#issuecomment-548720784 |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
| Clarified why tests are skipped | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/b183c7a0b6116c126de2e42eeb931f53b074a00b |
| b183c7a | https://github.com/nodeSolidServer/node-solid-server/pull/1333/commits/b183c7a0b6116c126de2e42eeb931f53b074a00b |
| https://github.com/jaxoncreed |
| jaxoncreed | https://github.com/jaxoncreed |
| e117cfc | https://github.com/nodeSolidServer/node-solid-server/commit/e117cfc9e2b79321b80c1377f52b7f5105344e2c |
| Nov 1, 2019 | https://github.com/nodeSolidServer/node-solid-server/pull/1333#event-2762643590 |
| https://github.com/melvincarvalho |
| melvincarvalho | https://github.com/melvincarvalho |
|
Jan 8, 2026
| https://github.com/nodeSolidServer/node-solid-server/pull/1333#ref-pullrequest-3794734721 |
|
fix: re-enable WebID-TLS tests (tiny bug fix from 2019)
#1842
| https://github.com/nodeSolidServer/node-solid-server/pull/1842 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FnodeSolidServer%2Fnode-solid-server%2Fpull%2F1333 |
|
| https://github.com/michielbdejong |
|
michielbdejong
| https://github.com/michielbdejong |
|
| https://github.com/nodeSolidServer/node-solid-server/pull/1333/files/86a4487ea31ab19aadd1edc31362a29f46113ae2 |
| Please reload this page | https://github.com/nodeSolidServer/node-solid-server/pull/1333 |
|
| https://github.com/jaxoncreed |
|
| https://github.com/michielbdejong |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |