Title: on-behalf-of header crashes server · Issue #473 · nodeSolidServer/node-solid-server · GitHub
Open Graph Title: on-behalf-of header crashes server · Issue #473 · nodeSolidServer/node-solid-server
X Title: on-behalf-of header crashes server · Issue #473 · nodeSolidServer/node-solid-server
Description: When using WebID delegation, the on-behalf-of header is sent by the user agent. Currently this will crash node solid server. It would be better to throw an error message, and keep the server running, or fix the delegation code in allow.j...
Open Graph Description: When using WebID delegation, the on-behalf-of header is sent by the user agent. Currently this will crash node solid server. It would be better to throw an error message, and keep the server runnin...
X Description: When using WebID delegation, the on-behalf-of header is sent by the user agent. Currently this will crash node solid server. It would be better to throw an error message, and keep the server runnin...
Opengraph URL: https://github.com/nodeSolidServer/node-solid-server/issues/473
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"on-behalf-of header crashes server","articleBody":"When using WebID delegation, the on-behalf-of header is sent by the user agent. Currently this will crash node solid server.\r\n\r\nIt would be better to throw an error message, and keep the server running, or fix the delegation code in allow.js \r\n\r\nhttps://github.com/solid/node-solid-server/blob/master/lib/handlers/allow.js\r\n\r\nThe root problem lies in the function : \r\n\r\n function verifyDelegator (host, ldp, baseUri, delegator, delegatee, callback) {\r\n\r\nWhich takes 6 parameters. It is being called \r\n\r\n verifyDelegator(req.hostname, delegator, req.session.userId, function\r\n\r\nWith only 4 parameters. Meaning that the callback is sent instead of the delegate URI. And the string function on the callback will throw an exception.\r\n\r\n@dmitrizagidulin any ideas on what the logic *should* be here?","author":{"url":"https://github.com/melvincarvalho","@type":"Person","name":"melvincarvalho"},"datePublished":"2016-12-18T23:29:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/473/node-solid-server/issues/473"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:52263459-f109-f018-e0a7-39890696a2b6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CDD4:1889FD:1064D8E:16B71DF:69776D9F |
| html-safe-nonce | 76feb0bb8f6b06e575d7b6c29eac1917bef181e8bf2f94d24ecaafbf05f66548 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREQ0OjE4ODlGRDoxMDY0RDhFOjE2QjcxREY6Njk3NzZEOUYiLCJ2aXNpdG9yX2lkIjoiOTA0NjA0MTUzMTk4NjE3NzQzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 37d9a217f345132ed8d9206fb978bfd845903e0c85d9307bab0c372668a02ad3 |
| hovercard-subject-tag | issue:196306864 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodeSolidServer/node-solid-server/473/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f2ace03735ce0ed80f5c6f0e74fb95f1272a2f5c84d92c1c8c83b6ae50683a63/nodeSolidServer/node-solid-server/issues/473 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f2ace03735ce0ed80f5c6f0e74fb95f1272a2f5c84d92c1c8c83b6ae50683a63/nodeSolidServer/node-solid-server/issues/473 |
| og:image:alt | When using WebID delegation, the on-behalf-of header is sent by the user agent. Currently this will crash node solid server. It would be better to throw an error message, and keep the server runnin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | melvincarvalho |
| hostname | github.com |
| expected-hostname | github.com |
| None | 425384cc392ce2ddd1a7a0c1e7043ab4192d4c04452a2ed7f2f38d2fa9293b5a |
| turbo-cache-control | no-preview |
| go-import | github.com/nodeSolidServer/node-solid-server git https://github.com/nodeSolidServer/node-solid-server.git |
| octolytics-dimension-user_id | 104446421 |
| octolytics-dimension-user_login | nodeSolidServer |
| octolytics-dimension-repository_id | 24306004 |
| octolytics-dimension-repository_nwo | nodeSolidServer/node-solid-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24306004 |
| octolytics-dimension-repository_network_root_nwo | nodeSolidServer/node-solid-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 72de26f7ca9bdb0559ebf1e63e6c685ee2c520ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width