René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Get ResourceMapper back to its minimal interface","articleBody":"The purpose of `ResourceMapper` was to put the knowledge for URL-to-file and file-to-URL conversion in one place and one place only. That's why only two methods were exposed: `mapUrlToFile` and `mapFileToUrl`, and they were very deeply tested. This avoided a whole range of bugs caused by spaces, escapes, etc. You can see this old state [here](https://github.com/solid/node-solid-server/blob/51ee61e7d9b89f48db957f7eadee5ca120f892c8/lib/resource-mapper.js).\r\n\r\nHowever, [later versions](https://github.com/solid/node-solid-server/blob/v5.1.1/lib/resource-mapper.js) started exposing extra methods, such as `resolveUrl`, `getFullPath`.\r\n\r\nOn the one hand, it is uncertain whether these are as well-tested. On the other hand, it leads to modules again [rolling their own resolving](https://github.com/solid/node-solid-server/blob/bdc5acba326f215c3d32eb2b234ec73d0f5cc9ce/lib/handlers/put.js#L39-L40) and introducing errors in the process. @timbl has found cases where URLs suddenly have unescaped spaces and are thus invalid (#1211). In the linked example, we see a bug happening:\r\n\r\n```javascript\r\n// This is a file path (unescaped spaces)\r\nconst path = ldp.resourceMapper.getFullPath(req)\r\n// Woops, now suddenly it is a URL (invalid, because unescaped spaces!)\r\nconst requestUri = await ldp.resourceMapper.resolveUrl(req.hostname, path)\r\n```\r\n\r\nPropose resolution: do not expose `resolveUrl` and `getFullPath` (underscore them); only `mapUrlToFile` and `mapFileToUrl` should be used.","author":{"url":"https://github.com/RubenVerborgh","@type":"Person","name":"RubenVerborgh"},"datePublished":"2019-06-01T22:59:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1212/node-solid-server/issues/1212"}