René's URL Explorer Experiment


Title: Point validateSignature() callers to the SAML methods, not to paths that are going away by cjbarth · Pull Request #522 · node-saml/node-saml · GitHub

Open Graph Title: Point validateSignature() callers to the SAML methods, not to paths that are going away by cjbarth · Pull Request #522 · node-saml/node-saml

X Title: Point validateSignature() callers to the SAML methods, not to paths that are going away by cjbarth · Pull Request #522 · node-saml/node-saml

Description: A SAML library not dependent on any frameworks that runs in Node. - Point validateSignature() callers to the SAML methods, not to paths that are going away by cjbarth · Pull Request #522 · node-saml/node-saml

Open Graph Description: Description 5.2.0 deprecated validateSignature(), which is in lib/xml and isn't public API, and told its callers to move to two places. Neither one lasts: The JSDoc says "use getVerifiedX...

X Description: Description 5.2.0 deprecated validateSignature(), which is in lib/xml and isn't public API, and told its callers to move to two places. Neither one lasts: The JSDoc says "use getV...

Opengraph URL: https://github.com/node-saml/node-saml/pull/522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ba9d9a9d-2515-57f6-1959-016704153535
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC06:3E754C:264823A:32CC336:6AF9B016
html-safe-noncea189770bb79d8f4ac7f9b824a54c0653f0edf49a671e4252b5cef52bdf512eb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzA2OjNFNzU0QzoyNjQ4MjNBOjMyQ0MzMzY6NkFGOUIwMTYiLCJ2aXNpdG9yX2lkIjoiNzU2MDU1MTkwMDY5NzQ0MDI3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace757fc062c7b9b5fdb589d3569a5a8dcd32a0822efafbbf1f71cb641e37bab41
hovercard-subject-tagpull_request:5039064747
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/node-saml/node-saml/522/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4f9e8f146233a81a62df8fa92b6bfc1ad1fd24dc0d57d0f3ab4ca5882bf647e4/node-saml/node-saml/pull/522
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4f9e8f146233a81a62df8fa92b6bfc1ad1fd24dc0d57d0f3ab4ca5882bf647e4/node-saml/node-saml/pull/522
og:image:altDescription 5.2.0 deprecated validateSignature(), which is in lib/xml and isn't public API, and told its callers to move to two places. Neither one lasts: The JSDoc says "use getVerifiedX...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjbarth
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/node-saml/node-saml git https://github.com/node-saml/node-saml.git
octolytics-dimension-user_id67655348
octolytics-dimension-user_loginnode-saml
octolytics-dimension-repository_id367110144
octolytics-dimension-repository_nwonode-saml/node-saml
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id367110144
octolytics-dimension-repository_network_root_nwonode-saml/node-saml
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/node-saml/node-saml/pull/522#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F522
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F522
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=node-saml%2Fnode-saml
Reloadhttps://github.com/node-saml/node-saml/pull/522
Reloadhttps://github.com/node-saml/node-saml/pull/522
Reloadhttps://github.com/node-saml/node-saml/pull/522
node-samlhttps://github.com/node-saml
node-samlhttps://github.com/node-saml/node-saml
Codehttps://github.com/node-saml/node-saml
Issues38 (38)https://github.com/node-saml/node-saml/issues
Pull requests14 (14)https://github.com/node-saml/node-saml/pulls
Discussionshttps://github.com/node-saml/node-saml/discussions
Actionshttps://github.com/node-saml/node-saml/actions
Projectshttps://github.com/node-saml/node-saml/projects
Security and quality4 (4)https://github.com/node-saml/node-saml/security
Insightshttps://github.com/node-saml/node-saml/pulse
https://github.com/node-saml/node-saml
cjbarthhttps://github.com/cjbarth
node-saml:masterhttps://github.com/node-saml/node-saml/tree/master
cjbarth:docs/validate-signature-migrationhttps://github.com/cjbarth/node-saml/tree/docs/validate-signature-migration
Conversationhttps://github.com/node-saml/node-saml/pull/522
Commits2 (2)https://github.com/node-saml/node-saml/pull/522/commits
Checkshttps://github.com/node-saml/node-saml/pull/522/checks
Files changedhttps://github.com/node-saml/node-saml/pull/522/files
Point validateSignature() callers to the SAML methods, not to paths that are going awayhttps://github.com/node-saml/node-saml/pull/522#top
cjbarthhttps://github.com/cjbarth
node-saml:masterhttps://github.com/node-saml/node-saml/tree/master
cjbarth:docs/validate-signature-migrationhttps://github.com/cjbarth/node-saml/tree/docs/validate-signature-migration
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
Oct 27, 2026https://github.com/node-saml/node-saml/pull/522#issue-6065271005
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
Close deep imports under lib/ with an exports map #458https://github.com/node-saml/node-saml/issues/458
Deprecate deep imports under lib/, and export from the root the types its API uses #441https://github.com/node-saml/node-saml/issues/441
Add XmlDSigVerifier wrapper for SignedXml xml-crypto#519https://github.com/node-saml/xml-crypto/pull/519
XmlDSigVerifier: verify the enveloped signature of a given element xml-crypto#627https://github.com/node-saml/xml-crypto/issues/627
#429https://github.com/node-saml/node-saml/issues/429
Remove the validateSignature export #429https://github.com/node-saml/node-saml/issues/429
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
https://github.com/cjbarth
https://github.com/claude
Point validateSignature() callers to the SAML methods, not to paths t…https://github.com/node-saml/node-saml/pull/522/commits/477f83a326149b802ec1de3448b717640188fe5f
477f83ahttps://github.com/node-saml/node-saml/pull/522/commits/477f83a326149b802ec1de3448b717640188fe5f
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
5.2.1https://github.com/node-saml/node-saml/milestone/5
Oct 27, 2026https://github.com/node-saml/node-saml/pull/522#event-34399134478
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
documentation https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Adocumentation
Oct 27, 2026https://github.com/node-saml/node-saml/pull/522#event-34399134641
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Oct 27, 2026https://github.com/node-saml/node-saml/pull/522#issuecomment-6450278202
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
https://app.coderabbit.ai/change-stack/node-saml/node-saml/pull/522?scope=ghh_OusAJGA4HG8ljoOV0wJvVx8NmnZIjc2DdjmxOu0xZWA&cs_source=review_comment
477f83ahttps://github.com/node-saml/node-saml/commit/477f83a326149b802ec1de3448b717640188fe5f
d91d761https://github.com/node-saml/node-saml/commit/d91d761afd6b71fd11b5811b5e77733e5640b7ea
node-saml/node-saml#419https://github.com/node-saml/node-saml/issues/419
node-saml/node-saml#521https://github.com/node-saml/node-saml/pull/521
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=node-saml/node-saml&utm_content=522
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 27, 2026https://github.com/node-saml/node-saml/pull/522#issuecomment-6450307581
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
Codecovhttps://app.codecov.io/gh/node-saml/node-saml/pull/522?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=node-saml
72a39dchttps://app.codecov.io/gh/node-saml/node-saml/commit/72a39dcf46a93a8679123db78b22ff82d6dd4096?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=node-saml
d91d761https://app.codecov.io/gh/node-saml/node-saml/commit/d91d761afd6b71fd11b5811b5e77733e5640b7ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=node-saml
☔ View full report in Codecov by Harnesshttps://app.codecov.io/gh/node-saml/node-saml/pull/522?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=node-saml
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=node-saml
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Oct 27, 2026 https://github.com/node-saml/node-saml/pull/522#pullrequestreview-5672373894
View reviewed changes https://github.com/node-saml/node-saml/pull/522/files/477f83a326149b802ec1de3448b717640188fe5f
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/node-saml/node-saml/pull/522#pullrequestreview-5672373894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3d083fbhttps://github.com/node-saml/node-saml/commit/3d083fb2e55765c1e1dcbc853f99ffbb498bb2e4
477f83ahttps://github.com/node-saml/node-saml/commit/477f83a326149b802ec1de3448b717640188fe5f
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
README.mdhttps://github.com/node-saml/node-saml/pull/522/files/477f83a326149b802ec1de3448b717640188fe5f#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
https://github.com/cjbarth
https://github.com/claude
Say which part of what the SAML methods return was verifiedhttps://github.com/node-saml/node-saml/pull/522/commits/d91d761afd6b71fd11b5811b5e77733e5640b7ea
d91d761https://github.com/node-saml/node-saml/pull/522/commits/d91d761afd6b71fd11b5811b5e77733e5640b7ea
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Oct 27, 2026 https://github.com/node-saml/node-saml/pull/522#ref-pullrequest-6064507121
Add allowUnsignedRedirectLogout, so a caller whose IdP doesn't sign can move off the deprecated validateRedirectAsync form #521 https://github.com/node-saml/node-saml/pull/521
https://github.co/hiddenchars
https://github.com/node-saml/node-saml/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F522
https://github.com/apps/coderabbitai
coderabbitai[bot] https://github.com/apps/coderabbitai
https://github.com/node-saml/node-saml/pull/522/files/d91d761afd6b71fd11b5811b5e77733e5640b7ea
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
documentation https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Adocumentation
5.2.1 https://github.com/node-saml/node-saml/milestone/5
Please reload this pagehttps://github.com/node-saml/node-saml/pull/522
https://github.com/cjbarth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.