| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4b4f73ee-6126-1dc5-2328-47123c4468f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A20:1CA15F:AB4C5E:E295F9:6AF9B088 |
| html-safe-nonce | 069d346bfc5cb95b39a3118aa3c1c22efe551e1b94bb47c8df40caaba732af4b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTIwOjFDQTE1RjpBQjRDNUU6RTI5NUY5OjZBRjlCMDg4IiwidmlzaXRvcl9pZCI6IjM4MjQ3ODM3MDczNDQ1ODA3NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b7e9ba7f34adb706527b3468f70238f356e21fa0d84f55f178ebe65ac5fd9dc4 |
| hovercard-subject-tag | pull_request:3807440503 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/node-saml/node-saml/413/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12963a6c1868069d8aeab89a2982e8d7d3f7595357b1fc689d1a42bb7bee26a1/node-saml/node-saml/pull/413 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12963a6c1868069d8aeab89a2982e8d7d3f7595357b1fc689d1a42bb7bee26a1/node-saml/node-saml/pull/413 |
| og:image:alt | Fixes #227
Problem
When a SAML assertion carries an attribute that exists but has no real value, node-saml currently loses that information in profile.attributes:
An attribute with no AttributeVal... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | arpitjain099 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-cache |
| go-import | github.com/node-saml/node-saml git https://github.com/node-saml/node-saml.git |
| octolytics-dimension-user_id | 67655348 |
| octolytics-dimension-user_login | node-saml |
| octolytics-dimension-repository_id | 367110144 |
| octolytics-dimension-repository_nwo | node-saml/node-saml |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 367110144 |
| octolytics-dimension-repository_network_root_nwo | node-saml/node-saml |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/node-saml/node-saml/pull/413#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F413 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F413 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=node-saml%2Fnode-saml |
| Reload | https://github.com/node-saml/node-saml/pull/413 |
| Reload | https://github.com/node-saml/node-saml/pull/413 |
| Reload | https://github.com/node-saml/node-saml/pull/413 |
| node-saml | https://github.com/node-saml |
| node-saml | https://github.com/node-saml/node-saml |
| Code | https://github.com/node-saml/node-saml |
| Issues38 (38) | https://github.com/node-saml/node-saml/issues |
| Pull requests14 (14) | https://github.com/node-saml/node-saml/pulls |
| Discussions | https://github.com/node-saml/node-saml/discussions |
| Actions | https://github.com/node-saml/node-saml/actions |
| Projects | https://github.com/node-saml/node-saml/projects |
| Security and quality4 (4) | https://github.com/node-saml/node-saml/security |
| Insights | https://github.com/node-saml/node-saml/pulse |
| https://github.com/node-saml/node-saml |
| arpitjain099 | https://github.com/arpitjain099 |
| node-saml:master | https://github.com/node-saml/node-saml/tree/master |
| arpitjain099:fix/empty-saml-attributes-227 | https://github.com/arpitjain099/node-saml/tree/fix/empty-saml-attributes-227 |
| Conversation | https://github.com/node-saml/node-saml/pull/413 |
| Commits1 (1) | https://github.com/node-saml/node-saml/pull/413/commits |
| Checks | https://github.com/node-saml/node-saml/pull/413/checks |
| Files changed | https://github.com/node-saml/node-saml/pull/413/files |
| fix: keep empty and valueless SAML attributes in profile.attributes | https://github.com/node-saml/node-saml/pull/413#top |
| arpitjain099 | https://github.com/arpitjain099 |
| node-saml:master | https://github.com/node-saml/node-saml/tree/master |
| arpitjain099:fix/empty-saml-attributes-227 | https://github.com/arpitjain099/node-saml/tree/fix/empty-saml-attributes-227 |
|
| https://github.com/arpitjain099 |
| arpitjain099 | https://github.com/arpitjain099 |
| Jun 5, 2026 | https://github.com/node-saml/node-saml/pull/413#issue-4593839484 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
| #227 | https://github.com/node-saml/node-saml/issues/227 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Jun 5, 2026 | https://github.com/node-saml/node-saml/pull/413#issuecomment-4627762488 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
| https://app.coderabbit.ai/change-stack/node-saml/node-saml/pull/413?cs_source=review_comment |
| 85a1b13 | https://github.com/node-saml/node-saml/commit/85a1b1352ad1be69c3970759467bb3d589c66c9d |
| d06629a | https://github.com/node-saml/node-saml/commit/d06629a5e06d22bb0f551d0d398bf9b6a09c4fd6 |
| CodeRabbit | https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=node-saml/node-saml&utm_content=413 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
| https://github.com/cjbarth |
| cjbarth | https://github.com/cjbarth |
| v6 | https://github.com/node-saml/node-saml/milestone/2 |
| Sep 17, 2026 | https://github.com/node-saml/node-saml/pull/413#event-31283913125 |
| https://github.com/cjbarth |
| cjbarth | https://github.com/cjbarth |
|
Sep 17, 2026
| https://github.com/node-saml/node-saml/pull/413#ref-pullrequest-5492308043 |
|
Warn when an attribute reaches the profile with no usable value
#427
| https://github.com/node-saml/node-saml/pull/427 |
| https://github.com/cjbarth |
| cjbarth | https://github.com/cjbarth |
| Sep 24, 2026 | https://github.com/node-saml/node-saml/pull/413#issuecomment-5815632450 |
| #427 | https://github.com/node-saml/node-saml/pull/427 |
| #427 | https://github.com/node-saml/node-saml/pull/427 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
|
| https://github.com/arpitjain099 |
| fix: keep empty and valueless SAML attributes in profile.attributes | https://github.com/node-saml/node-saml/pull/413/commits/d06629a5e06d22bb0f551d0d398bf9b6a09c4fd6 |
| d06629a | https://github.com/node-saml/node-saml/pull/413/commits/d06629a5e06d22bb0f551d0d398bf9b6a09c4fd6 |
| https://github.com/arpitjain099 |
| arpitjain099 | https://github.com/arpitjain099 |
| force-pushed | https://github.com/node-saml/node-saml/compare/85a1b1352ad1be69c3970759467bb3d589c66c9d..d06629a5e06d22bb0f551d0d398bf9b6a09c4fd6 |
| 85a1b13 | https://github.com/node-saml/node-saml/commit/85a1b1352ad1be69c3970759467bb3d589c66c9d |
| d06629a | https://github.com/node-saml/node-saml/commit/d06629a5e06d22bb0f551d0d398bf9b6a09c4fd6 |
|
Compare
| https://github.com/node-saml/node-saml/compare/85a1b1352ad1be69c3970759467bb3d589c66c9d..d06629a5e06d22bb0f551d0d398bf9b6a09c4fd6 |
| September 29, 2026 14:48 | https://github.com/node-saml/node-saml/pull/413#event-32089185370 |
| https://github.com/arpitjain099 |
| arpitjain099 | https://github.com/arpitjain099 |
| Sep 29, 2026 | https://github.com/node-saml/node-saml/pull/413#issuecomment-5892662073 |
| #427 | https://github.com/node-saml/node-saml/pull/427 |
| #427 | https://github.com/node-saml/node-saml/pull/427 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
| https://github.com/cjbarth |
| cjbarth | https://github.com/cjbarth |
|
bug
| https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Abug |
| Oct 5, 2026 | https://github.com/node-saml/node-saml/pull/413#event-32506209116 |
| https://github.co/hiddenchars |
| https://github.com/node-saml/node-saml/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F413 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
|
bug
| https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Abug |
|
v6
| https://github.com/node-saml/node-saml/milestone/2 |
|
[BUG] Empty and Null Attributes are not returned in profile.attributes
| https://github.com/node-saml/node-saml/issues/227 |
| Please reload this page | https://github.com/node-saml/node-saml/pull/413 |
|
| https://github.com/arpitjain099 |
|
| https://github.com/cjbarth |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |