René's URL Explorer Experiment


Title: Remove unused function arguments by cjbarth · Pull Request #367 · node-saml/node-saml · GitHub

Open Graph Title: Remove unused function arguments by cjbarth · Pull Request #367 · node-saml/node-saml

X Title: Remove unused function arguments by cjbarth · Pull Request #367 · node-saml/node-saml

Description: A SAML library not dependent on any frameworks that runs in Node. - Remove unused function arguments by cjbarth · Pull Request #367 · node-saml/node-saml

Open Graph Description: As was pointed out in this comment, the changes made in #214 were incomplete. This PR addresses this, but doing so is a breaking change.

X Description: As was pointed out in this comment, the changes made in #214 were incomplete. This PR addresses this, but doing so is a breaking change.

Opengraph URL: https://github.com/node-saml/node-saml/pull/367

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2691e025-9da2-032c-056c-f4ac55508116
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7FC:37FDA8:34D330:4AA44B:6AF9B077
html-safe-nonceb3bfd7090f2881da4d64fbd7a642f53cf034c51cbab22586b20ddeae1b89979f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0ZDOjM3RkRBODozNEQzMzA6NEFBNDRCOjZBRjlCMDc3IiwidmlzaXRvcl9pZCI6Ijc1ODQxOTUyMTc4OTM0MTgxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac33754d02899b10d2ee6087584d5b47801a856cec3affe3c76c0fbe6d6f840a5b
hovercard-subject-tagpull_request:1817022574
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/node-saml/node-saml/367/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c73d39e015f661a75aa0ccc0aa935793606309cbe127349bdfec5e92d36b7311/node-saml/node-saml/pull/367
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c73d39e015f661a75aa0ccc0aa935793606309cbe127349bdfec5e92d36b7311/node-saml/node-saml/pull/367
og:image:altAs was pointed out in this comment, the changes made in #214 were incomplete. This PR addresses this, but doing so is a breaking change.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjbarth
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/node-saml/node-saml git https://github.com/node-saml/node-saml.git
octolytics-dimension-user_id67655348
octolytics-dimension-user_loginnode-saml
octolytics-dimension-repository_id367110144
octolytics-dimension-repository_nwonode-saml/node-saml
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id367110144
octolytics-dimension-repository_network_root_nwonode-saml/node-saml
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/node-saml/node-saml/pull/367#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F367
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F367
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=node-saml%2Fnode-saml
Reloadhttps://github.com/node-saml/node-saml/pull/367
Reloadhttps://github.com/node-saml/node-saml/pull/367
Reloadhttps://github.com/node-saml/node-saml/pull/367
node-samlhttps://github.com/node-saml
node-samlhttps://github.com/node-saml/node-saml
Codehttps://github.com/node-saml/node-saml
Issues38 (38)https://github.com/node-saml/node-saml/issues
Pull requests14 (14)https://github.com/node-saml/node-saml/pulls
Discussionshttps://github.com/node-saml/node-saml/discussions
Actionshttps://github.com/node-saml/node-saml/actions
Projectshttps://github.com/node-saml/node-saml/projects
Security and quality4 (4)https://github.com/node-saml/node-saml/security
Insightshttps://github.com/node-saml/node-saml/pulse
https://github.com/node-saml/node-saml
cjbarthhttps://github.com/cjbarth
node-saml:masterhttps://github.com/node-saml/node-saml/tree/master
cjbarth:host-refactorhttps://github.com/cjbarth/node-saml/tree/host-refactor
Conversationhttps://github.com/node-saml/node-saml/pull/367
Commits1 (1)https://github.com/node-saml/node-saml/pull/367/commits
Checkshttps://github.com/node-saml/node-saml/pull/367/checks
Files changedhttps://github.com/node-saml/node-saml/pull/367/files
Remove unused function argumentshttps://github.com/node-saml/node-saml/pull/367#top
cjbarthhttps://github.com/cjbarth
node-saml:masterhttps://github.com/node-saml/node-saml/tree/master
cjbarth:host-refactorhttps://github.com/cjbarth/node-saml/tree/host-refactor
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
Apr 11, 2024https://github.com/node-saml/node-saml/pull/367#issue-2236651029
thishttps://github.com/node-saml/passport-saml/issues/909#issuecomment-2048493744
#214https://github.com/node-saml/node-saml/pull/214
Please reload this pagehttps://github.com/node-saml/node-saml/pull/367
https://github.com/cjbarth
Remove unused function argumentshttps://github.com/node-saml/node-saml/pull/367/commits/3304715cdcc8b0e3697c45413f6b97a1ce18e3d8
3304715https://github.com/node-saml/node-saml/pull/367/commits/3304715cdcc8b0e3697c45413f6b97a1ce18e3d8
node-saml#214https://github.com/node-saml/node-saml/pull/214
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
enhancement https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Aenhancement
breaking-change https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Abreaking-change
Apr 11, 2024https://github.com/node-saml/node-saml/pull/367#event-12429739546
https://github.com/srd90
srd90https://github.com/srd90
Nov 12, 2024 https://github.com/node-saml/node-saml/pull/367#ref-issue-2652599333
[ENHANCE] host parameter for getAuthorize*() is not used at all #381 https://github.com/node-saml/node-saml/issues/381
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
v6https://github.com/node-saml/node-saml/milestone/2
Jul 27, 2025https://github.com/node-saml/node-saml/pull/367#event-18841639628
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
Aug 18, 2025https://github.com/node-saml/node-saml/pull/367#event-19210108797
[ENHANCE] host parameter for getAuthorize*() is not used at all #381 https://github.com/node-saml/node-saml/issues/381
https://github.com/markstos
markstoshttps://github.com/markstos
Sep 17, 2026 https://github.com/node-saml/node-saml/pull/367#pullrequestreview-5230232530
View reviewed changes https://github.com/node-saml/node-saml/pull/367/files/3304715cdcc8b0e3697c45413f6b97a1ce18e3d8
markstoshttps://github.com/markstos
https://github.com/node-saml/node-saml/pull/367#pullrequestreview-5230232530
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/node-saml/node-saml/pull/367
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
Sep 17, 2026 https://github.com/node-saml/node-saml/pull/367#ref-pullrequest-5489961121
Deprecate the unused host argument on the getAuthorize* methods #421 https://github.com/node-saml/node-saml/pull/421
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
Sep 28, 2026 https://github.com/node-saml/node-saml/pull/367#ref-pullrequest-3267449527
Remove unused host parameter #398 https://github.com/node-saml/node-saml/pull/398
https://github.com/cjbarth
cjbarthhttps://github.com/cjbarth
Oct 10, 2026 https://github.com/node-saml/node-saml/pull/367#ref-pullrequest-5794367583
Warn once when getAuthorizeFormAsync is called with a host argument #499 https://github.com/node-saml/node-saml/pull/499
https://github.co/hiddenchars
https://github.com/node-saml/node-saml/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnode-saml%2Fnode-saml%2Fpull%2F367
https://github.com/markstos
markstos https://github.com/markstos
https://github.com/node-saml/node-saml/pull/367/files/3304715cdcc8b0e3697c45413f6b97a1ce18e3d8
Please reload this pagehttps://github.com/node-saml/node-saml/pull/367
breaking-change https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Abreaking-change
enhancement https://github.com/node-saml/node-saml/issues?q=state%3Aopen%20label%3Aenhancement
v6 https://github.com/node-saml/node-saml/milestone/2
[ENHANCE] host parameter for getAuthorize*() is not used at all https://github.com/node-saml/node-saml/issues/381
Please reload this pagehttps://github.com/node-saml/node-saml/pull/367
https://github.com/cjbarth
https://github.com/markstos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.