René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unexpected GMTOffset when field contains date only","articleBody":"**Describe the bug**\r\nWhen a `TS` field (such as `PID-7` Date/Time of Birth) contains a date and time without an offset, TSComponentOne.GMTOffset contains the placeholder -99.\r\n\r\nWhen a `TS` field contains a date only, without time or offset, TSComponentOne.GMTOffset contains the local offset instead of the expected placeholder -99.\r\n\r\n**To Reproduce**\r\n``` cs\r\nforeach (var value in new[] { \"20230603\", \"202306031234\", \"20230603+0800\", \"202306031234+0800\" })\r\n{\r\n  var message = new NHapi.Model.V24.Message.ADT_A05();\r\n  message.PID.DateTimeOfBirth.TimeOfAnEvent.Value = value;\r\n\r\n  Console.WriteLine(message.PID.DateTimeOfBirth.TimeOfAnEvent.GMTOffset);\r\n}\r\n\r\n// expected -99, -99, 800, 800\r\n// actual 800, -99, 800, 800\r\n```\r\n\r\n**Expected behaviour**\r\nWhen a `TS` field contains a date only, without time or offset, TSComponentOne.GMTOffset contains the placeholder -99.\r\n\r\n**Environmental Details (please complete the following information):**\r\n\r\n- OS: Windows 10\r\n- Target Framework: netstandard2.0\r\n- Version: 3.1.1\r\n- HL7 Version: 2.3.1 and 2.4\r\n\r\n**Additional context**\r\nThis appears to be specific behavior in the setter for CommonTS.Value as shown below, which seems really strange. I'd expect the offset to be ignored for a date-only value, since it's only meaningful in the presence of a time.\r\n\r\n``` cs\r\n// if the offset does not exist and a time value does not exist then\r\n// we must provide a default offset = to the local time zone\r\nif (timeVal == null \u0026\u0026 offsetExists == false)\r\n{\r\n  var defaultOffset = DataTypeUtil.LocalGMTOffset;\r\n  tm = new CommonTM();\r\n  tm.Offset = defaultOffset;\r\n} // end if\r\n\r\n// if we have a time value then make a new time object and set it to the\r\n// input time value (as long as the time val has time + offset or just time only)\r\nif (timeVal != null \u0026\u0026 timeValIsOffsetOnly == false)\r\n{\r\n  // must make sure that the time component contains both hours and minutes\r\n  // at the very least -- must be at least 4chars in length.\r\n  if (timeValLessOffset.Length \u003c 4) { ... }}\r\n\r\n  tm = new CommonTM();\r\n  tm.Value = timeVal;\r\n}\r\n``` ","author":{"url":"https://github.com/stormcrow79","@type":"Person","name":"stormcrow79"},"datePublished":"2024-04-26T08:15:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/558/nHapi/issues/558"}