René's URL Explorer Experiment


Title: installinstallmacos.py: Fix bad_dir check, and make warning louder by craig65535 · Pull Request #87 · munki/macadmin-scripts · GitHub

Open Graph Title: installinstallmacos.py: Fix bad_dir check, and make warning louder by craig65535 · Pull Request #87 · munki/macadmin-scripts

X Title: installinstallmacos.py: Fix bad_dir check, and make warning louder by craig65535 · Pull Request #87 · munki/macadmin-scripts

Description: Scripts of possible interest to macOS admins. Contribute to munki/macadmin-scripts development by creating an account on GitHub.

Open Graph Description: When reporting #86 I noticed that installinstallmacos.py checks which directory it is being run from, but that check was not working for me. This changes the check so it works with both the "b...

X Description: When reporting #86 I noticed that installinstallmacos.py checks which directory it is being run from, but that check was not working for me. This changes the check so it works with both the &qu...

Opengraph URL: https://github.com/munki/macadmin-scripts/pull/87

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9b2eb0e1-d241-e6de-6d9c-9e42b1fb5589
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8A8:246CE:70426E6:952B356:6A5DFD4F
html-safe-noncea21c4bbafafd5240cea483442c9e8679840d25f222ee15ed5e7037d598a33602
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEE4OjI0NkNFOjcwNDI2RTY6OTUyQjM1Njo2QTVERkQ0RiIsInZpc2l0b3JfaWQiOiI3OTMxMzAwMzQ5NjI1NjMwMDMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac776e0a29a77567e18a18cdea8de089f161e9b1637014f42646d6dc52f0b34f28
hovercard-subject-tagpull_request:608344780
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/munki/macadmin-scripts/87/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/24c498e1ab4ce4aaccfc74b0951947cc436b343e19145558be9ab70b7328631c/munki/macadmin-scripts/pull/87
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/24c498e1ab4ce4aaccfc74b0951947cc436b343e19145558be9ab70b7328631c/munki/macadmin-scripts/pull/87
og:image:altWhen reporting #86 I noticed that installinstallmacos.py checks which directory it is being run from, but that check was not working for me. This changes the check so it works with both the "b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecraig65535
hostnamegithub.com
expected-hostnamegithub.com
None7c1de870f4c0eff05971cd22970403a1239a98dc1a35e52a43594f23fc4d546f
turbo-cache-controlno-cache
go-importgithub.com/munki/macadmin-scripts git https://github.com/munki/macadmin-scripts.git
octolytics-dimension-user_id8826633
octolytics-dimension-user_loginmunki
octolytics-dimension-repository_id110171937
octolytics-dimension-repository_nwomunki/macadmin-scripts
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id110171937
octolytics-dimension-repository_network_root_nwomunki/macadmin-scripts
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee90635d4b07e4a20ff548df2e2bfea2179c6a3f3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/munki/macadmin-scripts/pull/87#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmunki%2Fmacadmin-scripts%2Fpull%2F87
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmunki%2Fmacadmin-scripts%2Fpull%2F87
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=munki%2Fmacadmin-scripts
Reloadhttps://github.com/munki/macadmin-scripts/pull/87
Reloadhttps://github.com/munki/macadmin-scripts/pull/87
Reloadhttps://github.com/munki/macadmin-scripts/pull/87
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
munki https://github.com/munki
macadmin-scriptshttps://github.com/munki/macadmin-scripts
Notifications https://github.com/login?return_to=%2Fmunki%2Fmacadmin-scripts
Fork 520 https://github.com/login?return_to=%2Fmunki%2Fmacadmin-scripts
Star 2.4k https://github.com/login?return_to=%2Fmunki%2Fmacadmin-scripts
Code https://github.com/munki/macadmin-scripts
Issues 1 https://github.com/munki/macadmin-scripts/issues
Pull requests 6 https://github.com/munki/macadmin-scripts/pulls
Actions https://github.com/munki/macadmin-scripts/actions
Projects https://github.com/munki/macadmin-scripts/projects
Security and quality 0 https://github.com/munki/macadmin-scripts/security
Insights https://github.com/munki/macadmin-scripts/pulse
Code https://github.com/munki/macadmin-scripts
Issues https://github.com/munki/macadmin-scripts/issues
Pull requests https://github.com/munki/macadmin-scripts/pulls
Actions https://github.com/munki/macadmin-scripts/actions
Projects https://github.com/munki/macadmin-scripts/projects
Security and quality https://github.com/munki/macadmin-scripts/security
Insights https://github.com/munki/macadmin-scripts/pulse
craig65535https://github.com/craig65535
munki:mainhttps://github.com/munki/macadmin-scripts/tree/main
craig65535:warn-siphttps://github.com/craig65535/macadmin-scripts/tree/warn-sip
Conversationhttps://github.com/munki/macadmin-scripts/pull/87
Commits8 (8)https://github.com/munki/macadmin-scripts/pull/87/commits
Checkshttps://github.com/munki/macadmin-scripts/pull/87/checks
Files changedhttps://github.com/munki/macadmin-scripts/pull/87/files
installinstallmacos.py: Fix bad_dir check, and make warning louderhttps://github.com/munki/macadmin-scripts/pull/87#top
craig65535https://github.com/craig65535
munki:mainhttps://github.com/munki/macadmin-scripts/tree/main
craig65535:warn-siphttps://github.com/craig65535/macadmin-scripts/tree/warn-sip
https://github.com/craig65535
craig65535https://github.com/craig65535
Apr 3, 2021https://github.com/munki/macadmin-scripts/pull/87#issue-849599357
#86https://github.com/munki/macadmin-scripts/issues/86
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
craig65535https://github.com/craig65535
April 3, 2021 01:12https://github.com/munki/macadmin-scripts/pull/87#commits-pushed-072b65b
https://github.com/craig65535
fix bad_dir check, and make warning louderhttps://github.com/munki/macadmin-scripts/pull/87/commits/072b65bbdf6e76070c01f95d467f2d3c522fa306
072b65bhttps://github.com/munki/macadmin-scripts/pull/87/commits/072b65bbdf6e76070c01f95d467f2d3c522fa306
https://github.com/craig65535
remove debug printhttps://github.com/munki/macadmin-scripts/pull/87/commits/217e987a584e26fb63740a5582330e61a3736631
217e987https://github.com/munki/macadmin-scripts/pull/87/commits/217e987a584e26fb63740a5582330e61a3736631
https://github.com/craig65535
craig65535https://github.com/craig65535
Apr 3, 2021https://github.com/munki/macadmin-scripts/pull/87#event-4547853811
https://github.com/craig65535
craig65535https://github.com/craig65535
Apr 3, 2021 https://github.com/munki/macadmin-scripts/pull/87#ref-issue-847359843
Are Big Sur installers working? #86 https://github.com/munki/macadmin-scripts/issues/86
https://github.com/craig65535
make more readablehttps://github.com/munki/macadmin-scripts/pull/87/commits/aeaa732a6f7597828fb1d884902fc83bfd2755b4
aeaa732https://github.com/munki/macadmin-scripts/pull/87/commits/aeaa732a6f7597828fb1d884902fc83bfd2755b4
https://github.com/craig65535
craig65535https://github.com/craig65535
Apr 20, 2021https://github.com/munki/macadmin-scripts/pull/87#issuecomment-823498867
@gregneaglehttps://github.com/gregneagle
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
https://github.com/craig65535
craig65535https://github.com/craig65535
May 20, 2021https://github.com/munki/macadmin-scripts/pull/87#issuecomment-845454329
@gregneaglehttps://github.com/gregneagle
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
https://github.com/gregneagle
gregneaglehttps://github.com/gregneagle
May 24, 2021 https://github.com/munki/macadmin-scripts/pull/87#pullrequestreview-666993590
View reviewed changes https://github.com/munki/macadmin-scripts/pull/87/files/aeaa732a6f7597828fb1d884902fc83bfd2755b4
installinstallmacos.pyhttps://github.com/munki/macadmin-scripts/pull/87/files/aeaa732a6f7597828fb1d884902fc83bfd2755b4#diff-c0e878cd2b951a191b82af8550185d95ed26be63a38299f95f5294e4fd55d771
gregneaglehttps://github.com/gregneagle
May 24, 2021https://github.com/munki/macadmin-scripts/pull/87#discussion_r638137592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
craig65535https://github.com/craig65535
May 24, 2021https://github.com/munki/macadmin-scripts/pull/87#discussion_r638203208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gregneaglehttps://github.com/gregneagle
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
gregneaglehttps://github.com/gregneagle
May 24, 2021https://github.com/munki/macadmin-scripts/pull/87#discussion_r638205911
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
gregneaglehttps://github.com/gregneagle
May 24, 2021https://github.com/munki/macadmin-scripts/pull/87#discussion_r638274566
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
craig65535https://github.com/craig65535
May 25, 2021https://github.com/munki/macadmin-scripts/pull/87#discussion_r638485239
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gregneaglehttps://github.com/gregneagle
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
https://github.com/gregneagle
gregneaglehttps://github.com/gregneagle
May 24, 2021 https://github.com/munki/macadmin-scripts/pull/87#pullrequestreview-666994144
View reviewed changes https://github.com/munki/macadmin-scripts/pull/87/files/aeaa732a6f7597828fb1d884902fc83bfd2755b4
installinstallmacos.pyhttps://github.com/munki/macadmin-scripts/pull/87/files/aeaa732a6f7597828fb1d884902fc83bfd2755b4#diff-c0e878cd2b951a191b82af8550185d95ed26be63a38299f95f5294e4fd55d771
gregneaglehttps://github.com/gregneagle
May 24, 2021https://github.com/munki/macadmin-scripts/pull/87#discussion_r638138087
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
craig65535https://github.com/craig65535
May 24, 2021 12:46https://github.com/munki/macadmin-scripts/pull/87#commits-pushed-55779df
https://github.com/craig65535
use os.path.joinhttps://github.com/munki/macadmin-scripts/pull/87/commits/55779df5a2921aff5a7ed004e2f845c6d743f305
55779dfhttps://github.com/munki/macadmin-scripts/pull/87/commits/55779df5a2921aff5a7ed004e2f845c6d743f305
https://github.com/craig65535
Fix some pylint warningshttps://github.com/munki/macadmin-scripts/pull/87/commits/90dd3b9bc296f1cc5d14ddb36f1877d391764a53
90dd3b9https://github.com/munki/macadmin-scripts/pull/87/commits/90dd3b9bc296f1cc5d14ddb36f1877d391764a53
https://github.com/craig65535
Address commentshttps://github.com/munki/macadmin-scripts/pull/87/commits/4f32302c8d8bdf601294e64002ae58bd3ba052ad
4f32302https://github.com/munki/macadmin-scripts/pull/87/commits/4f32302c8d8bdf601294e64002ae58bd3ba052ad
https://github.com/craig65535
use startswith instead of inhttps://github.com/munki/macadmin-scripts/pull/87/commits/999029544be629b77cbb0ebfb779e04353a3639b
9990295https://github.com/munki/macadmin-scripts/pull/87/commits/999029544be629b77cbb0ebfb779e04353a3639b
https://github.com/craig65535
revert to avoid future conflicthttps://github.com/munki/macadmin-scripts/pull/87/commits/ea4ae17cd1362b7d1f573af6fc16f059dc8d73ae
ea4ae17https://github.com/munki/macadmin-scripts/pull/87/commits/ea4ae17cd1362b7d1f573af6fc16f059dc8d73ae
https://github.com/craig65535
craig65535https://github.com/craig65535
Jun 7, 2021https://github.com/munki/macadmin-scripts/pull/87#issuecomment-855599971
@gregneaglehttps://github.com/gregneagle
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
https://github.co/hiddenchars
https://github.com/munki/macadmin-scripts/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmunki%2Fmacadmin-scripts%2Fpull%2F87
https://github.com/gregneagle
gregneagle https://github.com/gregneagle
https://github.com/munki/macadmin-scripts/pull/87/files/90dd3b9bc296f1cc5d14ddb36f1877d391764a53
Please reload this pagehttps://github.com/munki/macadmin-scripts/pull/87
https://github.com/craig65535
https://github.com/gregneagle
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.