René's URL Explorer Experiment


Title: Don't encode dataclass classes by jcrist · Pull Request #755 · msgspec/msgspec · GitHub

Open Graph Title: Don't encode dataclass classes by jcrist · Pull Request #755 · msgspec/msgspec

X Title: Don't encode dataclass classes by jcrist · Pull Request #755 · msgspec/msgspec

Description: A fast serialization and validation library, with builtin support for JSON, MessagePack, YAML, and TOML - Don't encode dataclass classes by jcrist · Pull Request #755 · msgspec/msgspec

Open Graph Description: Previously our "is this a dataclass-like thing" check would erroneously pass for dataclass classes as well as their instances. We now properly exclude classes and only encode instances. F...

X Description: Previously our "is this a dataclass-like thing" check would erroneously pass for dataclass classes as well as their instances. We now properly exclude classes and only encode inst...

Opengraph URL: https://github.com/msgspec/msgspec/pull/755

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f75e9e07-d8e8-9e0f-7c5e-b442b9be048a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB94:2EEEB5:93883E:C98393:6A4D4B4D
html-safe-nonce5fd8e8ff1979ee75b86d26bc71bf991627c7a9eb112bd38904fe0bfa184716bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjk0OjJFRUVCNTo5Mzg4M0U6Qzk4MzkzOjZBNEQ0QjREIiwidmlzaXRvcl9pZCI6Ijc4MjU2MTQxNjY2ODEyNzUyMTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7de2eaa60382ecaa06d26aea010341c3618ebd68b917630b441c4decbf0d4e6f
hovercard-subject-tagpull_request:2134710999
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/msgspec/msgspec/755/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ff06fc676962762c3210b9d95768cc17c603651975f1370c9bb4b3c07c253dc5/msgspec/msgspec/pull/755
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ff06fc676962762c3210b9d95768cc17c603651975f1370c9bb4b3c07c253dc5/msgspec/msgspec/pull/755
og:image:altPreviously our "is this a dataclass-like thing" check would erroneously pass for dataclass classes as well as their instances. We now properly exclude classes and only encode instances. F...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejcrist
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-cache
go-importgithub.com/msgspec/msgspec git https://github.com/msgspec/msgspec.git
octolytics-dimension-user_id287455683
octolytics-dimension-user_loginmsgspec
octolytics-dimension-repository_id332952543
octolytics-dimension-repository_nwomsgspec/msgspec
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id332952543
octolytics-dimension-repository_network_root_nwomsgspec/msgspec
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/msgspec/msgspec/pull/755#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgspec%2Fmsgspec%2Fpull%2F755
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgspec%2Fmsgspec%2Fpull%2F755
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=msgspec%2Fmsgspec
Reloadhttps://github.com/msgspec/msgspec/pull/755
Reloadhttps://github.com/msgspec/msgspec/pull/755
Reloadhttps://github.com/msgspec/msgspec/pull/755
Please reload this pagehttps://github.com/msgspec/msgspec/pull/755
msgspec https://github.com/msgspec
msgspechttps://github.com/msgspec/msgspec
Notifications https://github.com/login?return_to=%2Fmsgspec%2Fmsgspec
Fork 156 https://github.com/login?return_to=%2Fmsgspec%2Fmsgspec
Star 3.9k https://github.com/login?return_to=%2Fmsgspec%2Fmsgspec
Code https://github.com/msgspec/msgspec
Issues 185 https://github.com/msgspec/msgspec/issues
Pull requests 22 https://github.com/msgspec/msgspec/pulls
Actions https://github.com/msgspec/msgspec/actions
Security and quality 0 https://github.com/msgspec/msgspec/security
Insights https://github.com/msgspec/msgspec/pulse
Code https://github.com/msgspec/msgspec
Issues https://github.com/msgspec/msgspec/issues
Pull requests https://github.com/msgspec/msgspec/pulls
Actions https://github.com/msgspec/msgspec/actions
Security and quality https://github.com/msgspec/msgspec/security
Insights https://github.com/msgspec/msgspec/pulse
jcristhttps://github.com/jcrist
mainhttps://github.com/msgspec/msgspec/tree/main
dont-encode-dataclass-classeshttps://github.com/msgspec/msgspec/tree/dont-encode-dataclass-classes
Conversationhttps://github.com/msgspec/msgspec/pull/755
Commits1 (1)https://github.com/msgspec/msgspec/pull/755/commits
Checkshttps://github.com/msgspec/msgspec/pull/755/checks
Files changedhttps://github.com/msgspec/msgspec/pull/755/files
Don't encode dataclass classeshttps://github.com/msgspec/msgspec/pull/755#top
jcristhttps://github.com/jcrist
mainhttps://github.com/msgspec/msgspec/tree/main
dont-encode-dataclass-classeshttps://github.com/msgspec/msgspec/tree/dont-encode-dataclass-classes
https://github.com/jcrist
jcristhttps://github.com/jcrist
Oct 20, 2024https://github.com/msgspec/msgspec/pull/755#issue-2600812658
#681https://github.com/msgspec/msgspec/issues/681
Please reload this pagehttps://github.com/msgspec/msgspec/pull/755
https://github.com/jcrist
Don't encode dataclass classeshttps://github.com/msgspec/msgspec/pull/755/commits/755b190d90f8b55229918128fb4c0212acf8de96
755b190https://github.com/msgspec/msgspec/pull/755/commits/755b190d90f8b55229918128fb4c0212acf8de96
https://github.com/jcrist
jcristhttps://github.com/jcrist
ada66a7https://github.com/msgspec/msgspec/commit/ada66a75d3ec8dd2d0ca5c40646aeb7eeb2c7744
Oct 20, 2024https://github.com/msgspec/msgspec/pull/755#event-14755223982
https://github.com/jcrist
jcristhttps://github.com/jcrist
October 20, 2024 20:04https://github.com/msgspec/msgspec/pull/755#event-14755228655
https://github.co/hiddenchars
https://github.com/msgspec/msgspec/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgspec%2Fmsgspec%2Fpull%2F755
Json Encoder: dataclass classes are encoded to empty dict https://github.com/msgspec/msgspec/issues/681
Please reload this pagehttps://github.com/msgspec/msgspec/pull/755
https://github.com/jcrist
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.