René's URL Explorer Experiment


Title: fix: properly handle return codes in `pack_timestamp` by KowalskiThomas · Pull Request #672 · msgpack/msgpack-python · GitHub

Open Graph Title: fix: properly handle return codes in `pack_timestamp` by KowalskiThomas · Pull Request #672 · msgpack/msgpack-python

X Title: fix: properly handle return codes in `pack_timestamp` by KowalskiThomas · Pull Request #672 · msgpack/msgpack-python

Description: What is this PR? This PR makes it so that return codes of helpers called in msgpack_pack_ext are properly checked and surfaced if they're indicative of a failure. Note the "big" diff at the end of the function is an indentation change on top of the actual change -- the code used to be indented with three spaces instead of four. I changed that (should be clear looking at the diff without whitespace changes).

Open Graph Description: What is this PR? This PR makes it so that return codes of helpers called in msgpack_pack_ext are properly checked and surfaced if they're indicative of a failure. Note the "big" diff ...

X Description: What is this PR? This PR makes it so that return codes of helpers called in msgpack_pack_ext are properly checked and surfaced if they're indicative of a failure. Note the "big&...

Opengraph URL: https://github.com/msgpack/msgpack-python/pull/672

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ee2c91e3-9184-6820-e0dd-0fcf9fbd20a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E30:362D3E:426251:58A813:6A527813
html-safe-nonce763bff1fae4a66a16e82d05fa08dd067651766989e7a2cef785fd0e18e856793
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTMwOjM2MkQzRTo0MjYyNTE6NThBODEzOjZBNTI3ODEzIiwidmlzaXRvcl9pZCI6IjcwNjA1MjkwMTYzNTc0MTkwMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc58182aeb2c9b8bebe8bf931d78ef2139c4ccff1fa4bc3e95b8d32b8945629a5
hovercard-subject-tagpull_request:3660179322
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/msgpack/msgpack-python/pull/672/files
twitter:imagehttps://avatars.githubusercontent.com/u/14239160?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14239160?s=400&v=4
og:image:altWhat is this PR? This PR makes it so that return codes of helpers called in msgpack_pack_ext are properly checked and surfaced if they're indicative of a failure. Note the "big" diff ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/msgpack/msgpack-python git https://github.com/msgpack/msgpack-python.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id2242705
octolytics-dimension-repository_nwomsgpack/msgpack-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id2242705
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/msgpack/msgpack-python/pull/672/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F672%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F672%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=msgpack%2Fmsgpack-python
Reloadhttps://github.com/msgpack/msgpack-python/pull/672/files
Reloadhttps://github.com/msgpack/msgpack-python/pull/672/files
Reloadhttps://github.com/msgpack/msgpack-python/pull/672/files
Please reload this pagehttps://github.com/msgpack/msgpack-python/pull/672/files
msgpack https://github.com/msgpack
msgpack-pythonhttps://github.com/msgpack/msgpack-python
Notifications https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python
Fork 249 https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python
Star 2.1k https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python
Code https://github.com/msgpack/msgpack-python
Issues 3 https://github.com/msgpack/msgpack-python/issues
Pull requests 5 https://github.com/msgpack/msgpack-python/pulls
Discussions https://github.com/msgpack/msgpack-python/discussions
Actions https://github.com/msgpack/msgpack-python/actions
Security and quality 1 https://github.com/msgpack/msgpack-python/security
Insights https://github.com/msgpack/msgpack-python/pulse
Code https://github.com/msgpack/msgpack-python
Issues https://github.com/msgpack/msgpack-python/issues
Pull requests https://github.com/msgpack/msgpack-python/pulls
Discussions https://github.com/msgpack/msgpack-python/discussions
Actions https://github.com/msgpack/msgpack-python/actions
Security and quality https://github.com/msgpack/msgpack-python/security
Insights https://github.com/msgpack/msgpack-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmsgpack%2Fmsgpack-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python%2Fissues%2Fnew%2Fchoose
methanehttps://github.com/methane
msgpack:mainhttps://github.com/msgpack/msgpack-python/tree/main
KowalskiThomas:kowalski/fix-properly-handle-return-codes-in-pack_timestamphttps://github.com/KowalskiThomas/msgpack-python/tree/kowalski/fix-properly-handle-return-codes-in-pack_timestamp
Conversation 2 https://github.com/msgpack/msgpack-python/pull/672
Commits 1 https://github.com/msgpack/msgpack-python/pull/672/commits
Checks 25 https://github.com/msgpack/msgpack-python/pull/672/checks
Files changed 1 https://github.com/msgpack/msgpack-python/pull/672/files
fix: properly handle return codes in pack_timestamp https://github.com/msgpack/msgpack-python/pull/672/files#top
Show all changes 1 commit https://github.com/msgpack/msgpack-python/pull/672/files
8116ca3 fix: properly handle return codes in pack_timestamp KowalskiThomas Apr 30, 2026 https://github.com/msgpack/msgpack-python/pull/672/commits/8116ca37f5694494b04bdac4aeedfe7d3ae4b699
Clear filters https://github.com/msgpack/msgpack-python/pull/672/files
Please reload this pagehttps://github.com/msgpack/msgpack-python/pull/672/files
Please reload this pagehttps://github.com/msgpack/msgpack-python/pull/672/files
msgpack/pack_template.hhttps://github.com/msgpack/msgpack-python/pull/672/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
View file https://github.com/KowalskiThomas/msgpack-python/blob/8116ca37f5694494b04bdac4aeedfe7d3ae4b699/msgpack/pack_template.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-python/pull/672/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-python/pull/672/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
KowalskiThomashttps://github.com/KowalskiThomas
May 11, 2026https://github.com/msgpack/msgpack-python/pull/672/files#r3217307149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/msgpack/msgpack-python/pull/672/files
https://github.com/msgpack/msgpack-python/pull/672/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
Please reload this pagehttps://github.com/msgpack/msgpack-python/pull/672/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.