Title: fix: check `unpack_callback_uint32` result by KowalskiThomas · Pull Request #666 · msgpack/msgpack-python · GitHub
Open Graph Title: fix: check `unpack_callback_uint32` result by KowalskiThomas · Pull Request #666 · msgpack/msgpack-python
X Title: fix: check `unpack_callback_uint32` result by KowalskiThomas · Pull Request #666 · msgpack/msgpack-python
Description: What does this PR do? Similar to #665, just a return value check to propagate the error in case one happens (instead of silently ignoring it). Note that as opposed to the previous lines, we don't need to PyErr_SetString since unpack_callback_uint32 calls PyLong_FromSize_t which itself should set whatever Python error is relevant; we just need to make it clear to the caller that an error occurred. Note looking at the usages of the function (here for example, which calls into this) it seems like it checks for error values -2 and -3, but -1 will just raise ValueError("Unpack failed: error = %d" % (ret,)) -- I don't know if that's expected? Shouldn't it juse raise to raise the existing exception set by PyErr_SetString or whichever? Seems like something that should probably handled in a different PR/issue, but figured I'd raise it.
Open Graph Description: What does this PR do? Similar to #665, just a return value check to propagate the error in case one happens (instead of silently ignoring it). Note that as opposed to the previous lines, we don'...
X Description: What does this PR do? Similar to #665, just a return value check to propagate the error in case one happens (instead of silently ignoring it). Note that as opposed to the previous lines, we don&...
Opengraph URL: https://github.com/msgpack/msgpack-python/pull/666
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d5b94406-bf74-ec8a-7ee9-b5e4bef7ffec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9606:1B61E6:C7FA5:112C58:6A526BC4 |
| html-safe-nonce | 6e0b47c4b9881971a7140eacddcdc93f54f9a6c8f9247f1f36e41cd4d954db42 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjA2OjFCNjFFNjpDN0ZBNToxMTJDNTg6NkE1MjZCQzQiLCJ2aXNpdG9yX2lkIjoiNTY0NzAwMzU4NTAxNzQ0MTIyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0f35bc9473179e80565ac722a31d394daa1af163e745dcffe512d7bf1cb88c65 |
| hovercard-subject-tag | pull_request:3557649282 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/msgpack/msgpack-python/pull/666/files |
| twitter:image | https://avatars.githubusercontent.com/u/14239160?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14239160?s=400&v=4 |
| og:image:alt | What does this PR do? Similar to #665, just a return value check to propagate the error in case one happens (instead of silently ignoring it). Note that as opposed to the previous lines, we don'... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/msgpack/msgpack-python git https://github.com/msgpack/msgpack-python.git |
| octolytics-dimension-user_id | 198264 |
| octolytics-dimension-user_login | msgpack |
| octolytics-dimension-repository_id | 2242705 |
| octolytics-dimension-repository_nwo | msgpack/msgpack-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2242705 |
| octolytics-dimension-repository_network_root_nwo | msgpack/msgpack-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width