| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5da2812a-fa0a-97b1-3c6b-30fda33f9da7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A534:30E8A:32B559B:43461B8:69745060 |
| html-safe-nonce | 482e058d6c097df9acb1ca4bd888573eaac3f0d915df740ffb69c010924933de |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTM0OjMwRThBOjMyQjU1OUI6NDM0NjFCODo2OTc0NTA2MCIsInZpc2l0b3JfaWQiOiI1MTM1MTIwMjY4NzQ1MDAzMTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0ad86c39f7957875ce5a863cd9aefe54344c730b5d2d478d4996a6a332306d6f |
| hovercard-subject-tag | pull_request:219107175 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/msgpack/msgpack-python/310/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f948dd9db52f8b4eaa6bae1de650df1e172b10fe4abc2a8aeb00c1ce1e19ba44/msgpack/msgpack-python/pull/310 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f948dd9db52f8b4eaa6bae1de650df1e172b10fe4abc2a8aeb00c1ce1e19ba44/msgpack/msgpack-python/pull/310 |
| og:image:alt | The original batch wasn't working for jython and seemed to be more a lack of implicit type casting in older objects and alternate implementation pythons. This seems less intrusive, more straig... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devendor |
| hostname | github.com |
| expected-hostname | github.com |
| None | e0b95d743b7672c9ac0e1032d5f117950182dc164a83434a7db86510e8f0b37c |
| turbo-cache-control | no-preview |
| go-import | github.com/msgpack/msgpack-python git https://github.com/msgpack/msgpack-python.git |
| octolytics-dimension-user_id | 198264 |
| octolytics-dimension-user_login | msgpack |
| octolytics-dimension-repository_id | 2242705 |
| octolytics-dimension-repository_nwo | msgpack/msgpack-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2242705 |
| octolytics-dimension-repository_network_root_nwo | msgpack/msgpack-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fe7e2e8de6e57740bca50402351ea656f7a4bf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/msgpack/msgpack-python/pull/310#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F310 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F310 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=msgpack%2Fmsgpack-python |
| Reload | https://github.com/msgpack/msgpack-python/pull/310 |
| Reload | https://github.com/msgpack/msgpack-python/pull/310 |
| Reload | https://github.com/msgpack/msgpack-python/pull/310 |
|
msgpack
| https://github.com/msgpack |
| msgpack-python | https://github.com/msgpack/msgpack-python |
|
Notifications
| https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python |
|
Fork
238
| https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python |
|
Star
2.1k
| https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python |
|
Code
| https://github.com/msgpack/msgpack-python |
|
Issues
3
| https://github.com/msgpack/msgpack-python/issues |
|
Pull requests
3
| https://github.com/msgpack/msgpack-python/pulls |
|
Discussions
| https://github.com/msgpack/msgpack-python/discussions |
|
Actions
| https://github.com/msgpack/msgpack-python/actions |
|
Security
0
| https://github.com/msgpack/msgpack-python/security |
|
Insights
| https://github.com/msgpack/msgpack-python/pulse |
|
Code
| https://github.com/msgpack/msgpack-python |
|
Issues
| https://github.com/msgpack/msgpack-python/issues |
|
Pull requests
| https://github.com/msgpack/msgpack-python/pulls |
|
Discussions
| https://github.com/msgpack/msgpack-python/discussions |
|
Actions
| https://github.com/msgpack/msgpack-python/actions |
|
Security
| https://github.com/msgpack/msgpack-python/security |
|
Insights
| https://github.com/msgpack/msgpack-python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmsgpack%2Fmsgpack-python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-python%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/msgpack/msgpack-python/pull/310#issue-comment-box |
| methane | https://github.com/methane |
| msgpack:master | https://github.com/msgpack/msgpack-python/tree/master |
| devendor:master | https://github.com/devendor/msgpack-python/tree/master |
|
Alternate fixes for jython and legacy c python.
| https://github.com/msgpack/msgpack-python/pull/310#top |
| methane | https://github.com/methane |
| msgpack:master | https://github.com/msgpack/msgpack-python/tree/master |
| devendor:master | https://github.com/devendor/msgpack-python/tree/master |
|
Conversation
5
| https://github.com/msgpack/msgpack-python/pull/310 |
|
Commits
13
| https://github.com/msgpack/msgpack-python/pull/310/commits |
|
Checks
0
| https://github.com/msgpack/msgpack-python/pull/310/checks |
|
Files changed
| https://github.com/msgpack/msgpack-python/pull/310/files |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| https://github.co/hiddenchars |
| https://github.com/msgpack/msgpack-python/pull/{{ revealButtonHref }} |
|
| https://github.com/devendor |
| devendor | https://github.com/devendor |
| Sep 28, 2018 | https://github.com/msgpack/msgpack-python/pull/310#issue-365070721 |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| methane | https://github.com/methane |
| September 28, 2018 22:18 | https://github.com/msgpack/msgpack-python/pull/310#commits-pushed-6494e91 |
|
| https://github.com/methane |
|
| https://github.com/devendor |
| travis: Run test on Python 3.4 ( | https://github.com/msgpack/msgpack-python/pull/310/commits/6494e91846691d68b9c26093ff9f4523943f6f82 |
| msgpack#307 | https://github.com/msgpack/msgpack-python/pull/307 |
| ) | https://github.com/msgpack/msgpack-python/pull/310/commits/6494e91846691d68b9c26093ff9f4523943f6f82 |
| 6494e91 | https://github.com/msgpack/msgpack-python/pull/310/commits/6494e91846691d68b9c26093ff9f4523943f6f82 |
|
| https://github.com/devendor |
| Rolls back legacy python and jython fixes in favor of implicit type | https://github.com/msgpack/msgpack-python/pull/310/commits/88a8904de03da7d43ca168d53452f992ba1b9b22 |
| 88a8904 | https://github.com/msgpack/msgpack-python/pull/310/commits/88a8904de03da7d43ca168d53452f992ba1b9b22 |
| msgpack#303 | https://github.com/msgpack/msgpack-python/issues/303 |
| msgpack#304 | https://github.com/msgpack/msgpack-python/pull/304 |
| aa41e2f | https://github.com/devendor/msgpack-python/commit/aa41e2fef714da8c02e2cf830d408619d2cf902f |
| 5f684ae | https://github.com/devendor/msgpack-python/commit/5f684aed82d0d08079b9aa74e1d41cc2a367833d |
| b10cf78 | https://github.com/devendor/msgpack-python/commit/b10cf78f54a5daab866b19c32e45e207d838f52b |
|
| https://github.com/devendor |
| Reverts jython and legacy python / _buffer_view changes. | https://github.com/msgpack/msgpack-python/pull/310/commits/7b0e41c2c3d550e934755ac919d673c9cc407e39 |
| 7b0e41c | https://github.com/msgpack/msgpack-python/pull/310/commits/7b0e41c2c3d550e934755ac919d673c9cc407e39 |
|
| https://github.com/devendor |
| Merge remote-tracking branch 'remotes/origin/devendor_legacy_fallback' | https://github.com/msgpack/msgpack-python/pull/310/commits/5ea4d26c3837c4580c8f04b71982b94d756fef5c |
| 5ea4d26 | https://github.com/msgpack/msgpack-python/pull/310/commits/5ea4d26c3837c4580c8f04b71982b94d756fef5c |
|
| https://github.com/devendor |
| Fix original patch. | https://github.com/msgpack/msgpack-python/pull/310/commits/2baaf7b87b4ef4f5ebd15991b1fcf04577c33660 |
| 2baaf7b | https://github.com/msgpack/msgpack-python/pull/310/commits/2baaf7b87b4ef4f5ebd15991b1fcf04577c33660 |
|
| https://github.com/devendor |
| Another shot to pass py3 tests. | https://github.com/msgpack/msgpack-python/pull/310/commits/394b339b73911177b15a14857f02a037ae592808 |
| 394b339 | https://github.com/msgpack/msgpack-python/pull/310/commits/394b339b73911177b15a14857f02a037ae592808 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Oct 1, 2018
| https://github.com/msgpack/msgpack-python/pull/310#pullrequestreview-160181187 |
|
View reviewed changes
| https://github.com/msgpack/msgpack-python/pull/310/files/394b339b73911177b15a14857f02a037ae592808 |
| msgpack/fallback.py | https://github.com/msgpack/msgpack-python/pull/310/files/394b339b73911177b15a14857f02a037ae592808#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d |
| methane | https://github.com/methane |
| Oct 1, 2018 | https://github.com/msgpack/msgpack-python/pull/310#discussion_r221516736 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| devendor | https://github.com/devendor |
| Oct 1, 2018 | https://github.com/msgpack/msgpack-python/pull/310#discussion_r221639208 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| devendor | https://github.com/devendor |
| October 1, 2018 14:29 | https://github.com/msgpack/msgpack-python/pull/310#commits-pushed-ea0065f |
|
| https://github.com/devendor |
| move _unpack_from to global function. | https://github.com/msgpack/msgpack-python/pull/310/commits/ea0065ffd4f4742c0ff9cbc6abfd49b233f9920d |
| ea0065f | https://github.com/msgpack/msgpack-python/pull/310/commits/ea0065ffd4f4742c0ff9cbc6abfd49b233f9920d |
|
| https://github.com/devendor |
| fix failed test. | https://github.com/msgpack/msgpack-python/pull/310/commits/3b60399d2419921ce0d0a32d61c4fad4c83b9ab7 |
| 3b60399 | https://github.com/msgpack/msgpack-python/pull/310/commits/3b60399d2419921ce0d0a32d61c4fad4c83b9ab7 |
|
| https://github.com/devendor |
| fix failed test. | https://github.com/msgpack/msgpack-python/pull/310/commits/b86a1b8e235659e4ec6412465ceac27e47a708d2 |
| b86a1b8 | https://github.com/msgpack/msgpack-python/pull/310/commits/b86a1b8e235659e4ec6412465ceac27e47a708d2 |
|
| https://github.com/devendor |
| need coffee, thank you travis | https://github.com/msgpack/msgpack-python/pull/310/commits/88be776dc5c519c6a14de41e5cc5a8b7adf440bc |
| 88be776 | https://github.com/msgpack/msgpack-python/pull/310/commits/88be776dc5c519c6a14de41e5cc5a8b7adf440bc |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Oct 1, 2018
| https://github.com/msgpack/msgpack-python/pull/310#pullrequestreview-160339724 |
|
View reviewed changes
| https://github.com/msgpack/msgpack-python/pull/310/files/88be776dc5c519c6a14de41e5cc5a8b7adf440bc |
| msgpack/fallback.py | https://github.com/msgpack/msgpack-python/pull/310/files/88be776dc5c519c6a14de41e5cc5a8b7adf440bc#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d |
| methane | https://github.com/methane |
| Oct 1, 2018 | https://github.com/msgpack/msgpack-python/pull/310#discussion_r221642665 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| msgpack/fallback.py | https://github.com/msgpack/msgpack-python/pull/310/files/88be776dc5c519c6a14de41e5cc5a8b7adf440bc#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d |
| methane | https://github.com/methane |
| Oct 1, 2018 | https://github.com/msgpack/msgpack-python/pull/310#discussion_r221643488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| devendor | https://github.com/devendor |
| Oct 1, 2018 | https://github.com/msgpack/msgpack-python/pull/310#discussion_r221668536 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
| devendor | https://github.com/devendor |
| October 1, 2018 15:52 | https://github.com/msgpack/msgpack-python/pull/310#commits-pushed-9d4909a |
|
| https://github.com/devendor |
| Another approach to typecasting fix for jython. For some reason += th… | https://github.com/msgpack/msgpack-python/pull/310/commits/9d4909a987be6da5e29b41bed3455a9584cb6042 |
| 9d4909a | https://github.com/msgpack/msgpack-python/pull/310/commits/9d4909a987be6da5e29b41bed3455a9584cb6042 |
|
| https://github.com/devendor |
| Add a comment so the non-obvious work around doesn't get housecleaned. | https://github.com/msgpack/msgpack-python/pull/310/commits/1fabfcda692f9979e99caed6f4ef95da5cd66508 |
| 1fabfcd | https://github.com/msgpack/msgpack-python/pull/310/commits/1fabfcda692f9979e99caed6f4ef95da5cd66508 |
|
| https://github.com/devendor |
| Remove sloppy whitespace | https://github.com/msgpack/msgpack-python/pull/310/commits/9422e072653597517199163389384f32849a5278 |
| 9422e07 | https://github.com/msgpack/msgpack-python/pull/310/commits/9422e072653597517199163389384f32849a5278 |
| https://github.com/methane |
| methane | https://github.com/methane |
| 70b5f21 | https://github.com/msgpack/msgpack-python/commit/70b5f21b34b28cd50125ee337b5a399001759b73 |
| Oct 2, 2018 | https://github.com/msgpack/msgpack-python/pull/310#event-1879030382 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F310 |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
| https://github.com/msgpack/msgpack-python/pull/310/files/88be776dc5c519c6a14de41e5cc5a8b7adf440bc |
| Please reload this page | https://github.com/msgpack/msgpack-python/pull/310 |
|
| https://github.com/devendor |
|
| https://github.com/methane |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |