Title: Error in ExtensionCodec.ts? · Issue #241 · msgpack/msgpack-javascript · GitHub
Open Graph Title: Error in ExtensionCodec.ts? · Issue #241 · msgpack/msgpack-javascript
X Title: Error in ExtensionCodec.ts? · Issue #241 · msgpack/msgpack-javascript
Description: Hi, I think there is a little error here: msgpack-javascript/src/ExtensionCodec.ts Line 57 in 1fc7622 const index = 1 + type; Shouldn't it be const index = -1 - type;? Greetings Stefan
Open Graph Description: Hi, I think there is a little error here: msgpack-javascript/src/ExtensionCodec.ts Line 57 in 1fc7622 const index = 1 + type; Shouldn't it be const index = -1 - type;? Greetings Stefan
X Description: Hi, I think there is a little error here: msgpack-javascript/src/ExtensionCodec.ts Line 57 in 1fc7622 const index = 1 + type; Shouldn't it be const index = -1 - type;? Greetings Stefan
Opengraph URL: https://github.com/msgpack/msgpack-javascript/issues/241
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Error in ExtensionCodec.ts?","articleBody":"Hi,\r\n\r\nI think there is a little error here:\r\nhttps://github.com/msgpack/msgpack-javascript/blob/1fc7622d0dce18ff17077f54fab4c8c8be69b470/src/ExtensionCodec.ts#L57\r\n\r\nShouldn't it be `const index = -1 - type;`?\r\n\r\nGreetings\r\nStefan","author":{"url":"https://github.com/ste-gr","@type":"Person","name":"ste-gr"},"datePublished":"2024-03-15T15:07:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/241/msgpack-javascript/issues/241"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c942b8e7-d6f6-8f41-4d52-4f1309d6c511 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B898:23950F:D74F3F:12A60EF:6A53AAF8 |
| html-safe-nonce | 97fe6a46dac59b93571022300e9ed699b0b04f1f37552be63ca63863f557e1b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODk4OjIzOTUwRjpENzRGM0Y6MTJBNjBFRjo2QTUzQUFGOCIsInZpc2l0b3JfaWQiOiI4NDgyMDE2OTU2Mjg3MDAzMzg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 953d6c10650bf732e778c9dd785453cf469bddb734eb3805ec0250d86e59434a |
| hovercard-subject-tag | issue:2188784400 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/msgpack/msgpack-javascript/241/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dce3342224041e9ec5f8d1e7729b6bcb603efb8d6fa08d74549dd2a8aca48a4b/msgpack/msgpack-javascript/issues/241 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dce3342224041e9ec5f8d1e7729b6bcb603efb8d6fa08d74549dd2a8aca48a4b/msgpack/msgpack-javascript/issues/241 |
| og:image:alt | Hi, I think there is a little error here: msgpack-javascript/src/ExtensionCodec.ts Line 57 in 1fc7622 const index = 1 + type; Shouldn't it be const index = -1 - type;? Greetings Stefan |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ste-gr |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/msgpack/msgpack-javascript git https://github.com/msgpack/msgpack-javascript.git |
| octolytics-dimension-user_id | 198264 |
| octolytics-dimension-user_login | msgpack |
| octolytics-dimension-repository_id | 2761854 |
| octolytics-dimension-repository_nwo | msgpack/msgpack-javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2761854 |
| octolytics-dimension-repository_network_root_nwo | msgpack/msgpack-javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width