René's URL Explorer Experiment


Title: Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java · GitHub

Open Graph Title: Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java

X Title: Support JDK17 by xerial · Pull Request #660 · msgpack/msgpack-java

Description: To use JDK17 + DirectByteBuffer, we need to set two JVM options: --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED This PR adds: CI for JDK17 Add a workaround even if these JVM options are not set. Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options Related approaches: apache/spark#33947 apache/spark#34153 (--add-open JVM options to use reflection access) airlift/slice#130 Fixes #600

Open Graph Description: To use JDK17 + DirectByteBuffer, we need to set two JVM options: --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED This PR adds: CI for JDK17 Add a workaroun...

X Description: To use JDK17 + DirectByteBuffer, we need to set two JVM options: --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED This PR adds: CI for JDK17 Add a workaroun...

Opengraph URL: https://github.com/msgpack/msgpack-java/pull/660

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d60ef0ec-72b9-ed94-2b4c-0ed0a1fd9193
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B72:3A03DF:1B5A86C:2571FD9:6A53FE85
html-safe-nonce5886b30455229dc59d72fad07bb07b0d4bbee2a39b03fe182e3749d3d55c9d0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjcyOjNBMDNERjoxQjVBODZDOjI1NzFGRDk6NkE1M0ZFODUiLCJ2aXNpdG9yX2lkIjoiOTM2Mzg2MzEwNjQxNTQ4OTMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6fbff1194c2b7adb7455e3b04d21a09819b823e126b3ec7a0653e5ab02e0cf94
hovercard-subject-tagpull_request:981082752
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/msgpack/msgpack-java/pull/660/files
twitter:imagehttps://avatars.githubusercontent.com/u/57538?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57538?s=400&v=4
og:image:altTo use JDK17 + DirectByteBuffer, we need to set two JVM options: --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED This PR adds: CI for JDK17 Add a workaroun...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/msgpack/msgpack-java git https://github.com/msgpack/msgpack-java.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id1971346
octolytics-dimension-repository_nwomsgpack/msgpack-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1971346
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/msgpack/msgpack-java/pull/660/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-java%2Fpull%2F660%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-java%2Fpull%2F660%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=msgpack%2Fmsgpack-java
Reloadhttps://github.com/msgpack/msgpack-java/pull/660/files
Reloadhttps://github.com/msgpack/msgpack-java/pull/660/files
Reloadhttps://github.com/msgpack/msgpack-java/pull/660/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/660/files
msgpack https://github.com/msgpack
msgpack-javahttps://github.com/msgpack/msgpack-java
Notifications https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Fork 323 https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Star 1.5k https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Code https://github.com/msgpack/msgpack-java
Issues 60 https://github.com/msgpack/msgpack-java/issues
Pull requests 5 https://github.com/msgpack/msgpack-java/pulls
Actions https://github.com/msgpack/msgpack-java/actions
Projects https://github.com/msgpack/msgpack-java/projects
Wiki https://github.com/msgpack/msgpack-java/wiki
Security and quality 1 https://github.com/msgpack/msgpack-java/security
Insights https://github.com/msgpack/msgpack-java/pulse
Code https://github.com/msgpack/msgpack-java
Issues https://github.com/msgpack/msgpack-java/issues
Pull requests https://github.com/msgpack/msgpack-java/pulls
Actions https://github.com/msgpack/msgpack-java/actions
Projects https://github.com/msgpack/msgpack-java/projects
Wiki https://github.com/msgpack/msgpack-java/wiki
Security and quality https://github.com/msgpack/msgpack-java/security
Insights https://github.com/msgpack/msgpack-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmsgpack%2Fmsgpack-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java%2Fissues%2Fnew%2Fchoose
xerialhttps://github.com/xerial
develophttps://github.com/msgpack/msgpack-java/tree/develop
jdk17-supporthttps://github.com/msgpack/msgpack-java/tree/jdk17-support
Conversation 0 https://github.com/msgpack/msgpack-java/pull/660
Commits 4 https://github.com/msgpack/msgpack-java/pull/660/commits
Checks 0 https://github.com/msgpack/msgpack-java/pull/660/checks
Files changed https://github.com/msgpack/msgpack-java/pull/660/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/660/files
Support JDK17 https://github.com/msgpack/msgpack-java/pull/660/files#top
Show all changes 4 commits https://github.com/msgpack/msgpack-java/pull/660/files
65188ed Reproduce #600 (JDk17 error) xerial Jun 28, 2022 https://github.com/msgpack/msgpack-java/pull/660/commits/65188edfcb7a87f17dc1fdd5b5017ec555f4d3c5
3dc7e9d Add workaround for Java17 xerial Jun 28, 2022 https://github.com/msgpack/msgpack-java/pull/660/commits/3dc7e9dde81824d58e9aff3bafa68ed8c93e1370
fdb537a Add a helpful error message xerial Jun 28, 2022 https://github.com/msgpack/msgpack-java/pull/660/commits/fdb537a28129ef485675e516ced45e22a788597a
ecb4951 Add note on JDK17 xerial Jun 28, 2022 https://github.com/msgpack/msgpack-java/pull/660/commits/ecb4951a8fc1642c97c0545a0fcb1a732a9d1432
Clear filters https://github.com/msgpack/msgpack-java/pull/660/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/660/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/660/files
CI.yml https://github.com/msgpack/msgpack-java/pull/660/files#diff-3ab46ee209a127470fce3c2cf106b1a1dbadbb929a4b5b13656a4bc4ce19c0b8
README.md https://github.com/msgpack/msgpack-java/pull/660/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
build.sbt https://github.com/msgpack/msgpack-java/pull/660/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91
DirectBufferAccess.java https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
DirectBufferAccessTest.scala https://github.com/msgpack/msgpack-java/pull/660/files#diff-32ea1e1ab95e9b5df075ecc415721550bfc00941e684434c4999d4c8de80f431
.github/workflows/CI.ymlhttps://github.com/msgpack/msgpack-java/pull/660/files#diff-3ab46ee209a127470fce3c2cf106b1a1dbadbb929a4b5b13656a4bc4ce19c0b8
View file https://github.com/msgpack/msgpack-java/blob/ecb4951a8fc1642c97c0545a0fcb1a732a9d1432/.github/workflows/CI.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/660/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/660/files#diff-3ab46ee209a127470fce3c2cf106b1a1dbadbb929a4b5b13656a4bc4ce19c0b8
https://github.com/msgpack/msgpack-java/pull/660/files#diff-3ab46ee209a127470fce3c2cf106b1a1dbadbb929a4b5b13656a4bc4ce19c0b8
https://github.com/msgpack/msgpack-java/pull/660/files#diff-3ab46ee209a127470fce3c2cf106b1a1dbadbb929a4b5b13656a4bc4ce19c0b8
README.mdhttps://github.com/msgpack/msgpack-java/pull/660/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/msgpack/msgpack-java/blob/ecb4951a8fc1642c97c0545a0fcb1a732a9d1432/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/660/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/660/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/msgpack/msgpack-java/pull/660/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
build.sbthttps://github.com/msgpack/msgpack-java/pull/660/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91
View file https://github.com/msgpack/msgpack-java/blob/ecb4951a8fc1642c97c0545a0fcb1a732a9d1432/build.sbt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/660/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/660/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91
https://github.com/msgpack/msgpack-java/pull/660/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91
msgpack-core/src/main/java/org/msgpack/core/buffer/DirectBufferAccess.javahttps://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
View file https://github.com/msgpack/msgpack-java/blob/ecb4951a8fc1642c97c0545a0fcb1a732a9d1432/msgpack-core/src/main/java/org/msgpack/core/buffer/DirectBufferAccess.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/660/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/660/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
msgpack-core/src/test/scala/org/msgpack/core/buffer/DirectBufferAccessTest.scalahttps://github.com/msgpack/msgpack-java/pull/660/files#diff-32ea1e1ab95e9b5df075ecc415721550bfc00941e684434c4999d4c8de80f431
View file https://github.com/msgpack/msgpack-java/blob/ecb4951a8fc1642c97c0545a0fcb1a732a9d1432/msgpack-core/src/test/scala/org/msgpack/core/buffer/DirectBufferAccessTest.scala
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/660/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.