René's URL Explorer Experiment


Title: Improves MessageBuffer support for Java 11 by ppkarwasz · Pull Request #514 · msgpack/msgpack-java · GitHub

Open Graph Title: Improves MessageBuffer support for Java 11 by ppkarwasz · Pull Request #514 · msgpack/msgpack-java

X Title: Improves MessageBuffer support for Java 11 by ppkarwasz · Pull Request #514 · msgpack/msgpack-java

Description: Switches the MessageBuffer implementation to MessageBufferU for Java versions at least 9, which solves a couple of problems: On Java 11 (OpenJDK) jdk.internal.ref.Cleaner#clean is not open to reflection and the static initializer of DirectBufferAccess throws an IllegalAccessException. Access to java.nio.DirectByteBuffer may suffer the same problem in the future. For now we just get a warning. Since MessageBufferU overrides almost all methods of MessageBuffer, while direct ByteBuffers register a cleaner by themself, I don't see why MessageBufferU(ByteBuffer) shouldn't accept direct buffers. This should also solve bug number #482.

Open Graph Description: Switches the MessageBuffer implementation to MessageBufferU for Java versions at least 9, which solves a couple of problems: On Java 11 (OpenJDK) jdk.internal.ref.Cleaner#clean is not open to ref...

X Description: Switches the MessageBuffer implementation to MessageBufferU for Java versions at least 9, which solves a couple of problems: On Java 11 (OpenJDK) jdk.internal.ref.Cleaner#clean is not open to ref...

Opengraph URL: https://github.com/msgpack/msgpack-java/pull/514

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9d7f5602-3293-6ce9-4a81-b0762ea3f346
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD58:2F3AB6:1C911B9:253241D:6A5C7D58
html-safe-noncef4c97a1f87449cada05f0948cc38b57a94b489cb2c17b08826ac6b5efd225ac8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDU4OjJGM0FCNjoxQzkxMUI5OjI1MzI0MUQ6NkE1QzdENTgiLCJ2aXNpdG9yX2lkIjoiMzE1NzQ0Nzc5NTAwOTE1ODQ4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0d641880b640896d80775671dbb7b95f07369761dee39da7b1cdaed8de9a889b
hovercard-subject-tagpull_request:317453413
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/msgpack/msgpack-java/pull/514/files
twitter:imagehttps://avatars.githubusercontent.com/u/12533274?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12533274?s=400&v=4
og:image:altSwitches the MessageBuffer implementation to MessageBufferU for Java versions at least 9, which solves a couple of problems: On Java 11 (OpenJDK) jdk.internal.ref.Cleaner#clean is not open to ref...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/msgpack/msgpack-java git https://github.com/msgpack/msgpack-java.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id1971346
octolytics-dimension-repository_nwomsgpack/msgpack-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1971346
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/msgpack/msgpack-java/pull/514/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-java%2Fpull%2F514%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-java%2Fpull%2F514%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=msgpack%2Fmsgpack-java
Reloadhttps://github.com/msgpack/msgpack-java/pull/514/files
Reloadhttps://github.com/msgpack/msgpack-java/pull/514/files
Reloadhttps://github.com/msgpack/msgpack-java/pull/514/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/514/files
msgpack https://github.com/msgpack
msgpack-javahttps://github.com/msgpack/msgpack-java
Notifications https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Fork 323 https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Star 1.5k https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Code https://github.com/msgpack/msgpack-java
Issues 61 https://github.com/msgpack/msgpack-java/issues
Pull requests 5 https://github.com/msgpack/msgpack-java/pulls
Actions https://github.com/msgpack/msgpack-java/actions
Projects https://github.com/msgpack/msgpack-java/projects
Wiki https://github.com/msgpack/msgpack-java/wiki
Security and quality 1 https://github.com/msgpack/msgpack-java/security
Insights https://github.com/msgpack/msgpack-java/pulse
Code https://github.com/msgpack/msgpack-java
Issues https://github.com/msgpack/msgpack-java/issues
Pull requests https://github.com/msgpack/msgpack-java/pulls
Actions https://github.com/msgpack/msgpack-java/actions
Projects https://github.com/msgpack/msgpack-java/projects
Wiki https://github.com/msgpack/msgpack-java/wiki
Security and quality https://github.com/msgpack/msgpack-java/security
Insights https://github.com/msgpack/msgpack-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmsgpack%2Fmsgpack-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java%2Fissues%2Fnew%2Fchoose
xerialhttps://github.com/xerial
msgpack:develophttps://github.com/msgpack/msgpack-java/tree/develop
Conversation 11 https://github.com/msgpack/msgpack-java/pull/514
Commits 9 https://github.com/msgpack/msgpack-java/pull/514/commits
Checks 0 https://github.com/msgpack/msgpack-java/pull/514/checks
Files changed https://github.com/msgpack/msgpack-java/pull/514/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/514/files
Improves MessageBuffer support for Java 11 https://github.com/msgpack/msgpack-java/pull/514/files#top
Show all changes 9 commits https://github.com/msgpack/msgpack-java/pull/514/files
40fea89 Improves MessageBuffer support of Java 11 Sep 13, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/40fea897fbf06920053f27c517ed7a5c50f0c5a2
89d6964 Corrects code style Sep 13, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/89d696416fd5c55624ea9ada3f579406f1f67594
77a76a2 Do not switch to MessageBufferU on Java 9+ Nov 8, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/77a76a2ba3d6d594566fd842f2b9b8f714881585
f3b14bb Run Java 11 tests on universal buffer only Nov 8, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/f3b14bbb4cdda688c4e360fb05af6a1d66facf7f
55d8dd3 Fixes DirectBufferAccess#clean on Java 11 Nov 10, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/55d8dd3e753adaf817829e67aae0f9b5becba10d
293d928 Corrects style Nov 10, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/293d928fda43c1ed52e2bfbce4cb5ebd8e0e64db
42ef575 Corrects whitespace Nov 10, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/42ef57556f1d4fe1af63659a258c7029e06b9da1
bd2e6f9 Restores Java8 tests. Nov 10, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/bd2e6f9094084468596e6ca3c72a22e315d4814a
2860e9c Fixes IllegalAccessExceptions Nov 10, 2019 https://github.com/msgpack/msgpack-java/pull/514/commits/2860e9c6b55f5d5232e5d2cac9b57ade7af67f4d
Clear filters https://github.com/msgpack/msgpack-java/pull/514/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/514/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/514/files
DirectBufferAccess.java https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
MessageBuffer.java https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
MessageBufferU.java https://github.com/msgpack/msgpack-java/pull/514/files#diff-9e3269767a9a5281934eea2bb508fe8f08f42f0aad94d8639b3f9203bae0fc0a
msgpack-core/src/main/java/org/msgpack/core/buffer/DirectBufferAccess.javahttps://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
View file https://github.com/msgpack/msgpack-java/blob/2860e9c6b55f5d5232e5d2cac9b57ade7af67f4d/msgpack-core/src/main/java/org/msgpack/core/buffer/DirectBufferAccess.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/514/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-224ff980d00516b6c0d389e77bb9df2f8d527b6f28ef6e87c64a4c097413b68e
msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBuffer.javahttps://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
View file https://github.com/msgpack/msgpack-java/blob/2860e9c6b55f5d5232e5d2cac9b57ade7af67f4d/msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBuffer.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/514/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
https://github.com/msgpack/msgpack-java/pull/514/files#diff-bee643e5d648cc24cded999a62020e33f0b650ec03c4bc593a4af27777d8c37e
msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBufferU.javahttps://github.com/msgpack/msgpack-java/pull/514/files#diff-9e3269767a9a5281934eea2bb508fe8f08f42f0aad94d8639b3f9203bae0fc0a
View file https://github.com/msgpack/msgpack-java/blob/2860e9c6b55f5d5232e5d2cac9b57ade7af67f4d/msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBufferU.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/514/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/514/files#diff-9e3269767a9a5281934eea2bb508fe8f08f42f0aad94d8639b3f9203bae0fc0a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.